SOAP::getOutputToSend() - Code Metrics - Inspection of "Bump xmlseclibs version" - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#98)

unknown

created 2017-06-05 16:00 UTC

SOAP::getOutputToSend() A

↳ Parent: SOAP

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	1
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php

namespace SAML2;

/**
 * Class which implements the SOAP binding.
 *
 * @package SimpleSAMLphp
 */
class SOAP extends Binding
{
    public function getOutputToSend(Message $message)
    {
        $outputFromIdp = '<?xml version="1.0" encoding="UTF-8"?>';
        $outputFromIdp .= '<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">';
        $outputFromIdp .= '<SOAP-ENV:Body>';
        $xmlMessage = $message->toSignedXML();
        Utils::getContainer()->debugMessage($xmlMessage, 'out');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $tempOutputFromIdp = $xmlMessage->ownerDocument->saveXML($xmlMessage);
        $outputFromIdp .= $tempOutputFromIdp;
        $outputFromIdp .= '</SOAP-ENV:Body>';
        $outputFromIdp .= '</SOAP-ENV:Envelope>';

        return $outputFromIdp;
    }

    /**
     * Send a SAML 2 message using the SOAP binding.
     *
     * Note: This function never returns.
     *
     * @param \SAML2\Message $message The message we should send.
     */
    public function send(Message $message)
    {
        header('Content-Type: text/xml', true);
        print($this->getOutputToSend($message));
        exit(0);

    }

    /**
     * Receive a SAML 2 message sent using the HTTP-POST binding.
     *
     * Throws an exception if it is unable receive the message.
     *
     * @return \SAML2\Message The received message.
     * @throws \Exception
     */
    public function receive()
    {
        $postText = $this->getInputStream();

        if (empty($postText)) {
            throw new \Exception('Invalid message received to AssertionConsumerService endpoint.');
        }

        $document = DOMDocumentFactory::fromString($postText);
        $xml = $document->firstChild;
        Utils::getContainer()->debugMessage($xml, 'in');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $results = Utils::xpQuery($xml, '/soap-env:Envelope/soap-env:Body/*[1]');

        return Message::fromXML($results[0]);
    }

    protected function getInputStream()
    {
        return file_get_contents('php://input');
    }
}


1			<?php
2
3			namespace SAML2;
4
5			/**
6			* Class which implements the SOAP binding.
7			*
8			* @package SimpleSAMLphp
9			*/
10			class SOAP extends Binding
11			{
12			public function getOutputToSend(Message $message)
13			{
14			$outputFromIdp = '<?xml version="1.0" encoding="UTF-8"?>';
15			$outputFromIdp .= '<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">';
16			$outputFromIdp .= '<SOAP-ENV:Body>';
17			$xmlMessage = $message->toSignedXML();
18			Utils::getContainer()->debugMessage($xmlMessage, 'out');
			0 ignored issues – show Documentation introduced 2015-11-29 21:04 UTC by Report Bug Copy Issue Report `$xmlMessage` is of type `object<DOMElement>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			$tempOutputFromIdp = $xmlMessage->ownerDocument->saveXML($xmlMessage);
20			$outputFromIdp .= $tempOutputFromIdp;
21			$outputFromIdp .= '</SOAP-ENV:Body>';
22			$outputFromIdp .= '</SOAP-ENV:Envelope>';
23
24			return $outputFromIdp;
25			}
26
27			/**
28			* Send a SAML 2 message using the SOAP binding.
29			*
30			* Note: This function never returns.
31			*
32			* @param \SAML2\Message $message The message we should send.
33			*/
34			public function send(Message $message)
35			{
36			header('Content-Type: text/xml', true);
37			print($this->getOutputToSend($message));
38			exit(0);
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-26 14:49 UTC by Report Bug Copy Issue Report The method `send()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
39			}
40
41			/**
42			* Receive a SAML 2 message sent using the HTTP-POST binding.
43			*
44			* Throws an exception if it is unable receive the message.
45			*
46			* @return \SAML2\Message The received message.
47			* @throws \Exception
48			*/
49			public function receive()
50			{
51			$postText = $this->getInputStream();
52
53			if (empty($postText)) {
54			throw new \Exception('Invalid message received to AssertionConsumerService endpoint.');
55			}
56
57			$document = DOMDocumentFactory::fromString($postText);
58			$xml = $document->firstChild;
59			Utils::getContainer()->debugMessage($xml, 'in');
			0 ignored issues – show Documentation introduced 2015-11-29 21:04 UTC by Report Bug Copy Issue Report `$xml` is of type `object<DOMNode>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60			$results = Utils::xpQuery($xml, '/soap-env:Envelope/soap-env:Body/*[1]');
61
62			return Message::fromXML($results[0]);
63			}
64
65			protected function getInputStream()
66			{
67			return file_get_contents('php://input');
68			}
69			}
70

simplesamlphp / saml2

Pull Request — master (#98)

SOAP::getOutputToSend() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like