ResponseValidator::createResponseValidator() - Code Metrics - Inspection of "WIP: Create classes for SAML entities + metadata" - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#363)

by Tim

created 2024-12-15 09:43 UTC

ResponseValidator::createResponseValidator() A

↳ Parent: ResponseValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	3
dl	0
loc	10
rs	10

<?php

declare(strict_types=1);

namespace SimpleSAML\SAML2\Process\Validator;

use SimpleSAML\SAML2\{Binding, Metadata};
use SimpleSAML\SAML2\Process\ConstraintValidation\Response\{DestinationMatches, IsSuccessful};
filter:
    dependency_paths: ["lib/*"]

class ResponseValidator implements ValidatorInterface
{
    use ValidatorTrait;

    /**
     * @param \SimpleSAML\SAML2\Metadata\IdentityProvider  The IdP-metadata
filter:
    dependency_paths: ["lib/*"]
     * @param \SimpleSAML\SAML2\Metadata\ServiceProvider  The SP-metadata
     */
    private function __construct(
        protected ?Metadata\IdentityProvider $idpMetadata,
        protected Metadata\ServiceProvider $spMetadata,
    ) {
    }


    /**
     * @param \SimpleSAML\SAML2\Metadata\IdentityProvider|null $idpMetadata
     * @param \SimpleSAML\SAML2\Metadata\ServiceProvider $spMetadata
     * @param string $binding
     * @return \SimpleSAML\SAML2\Validator\ResponseValidator
filter:
    dependency_paths: ["lib/*"]
     */
    public static function createResponseValidator(
        ?Metadata\IdentityProvider $idpMetadata,
        Metadata\ServiceProvider $spMetadata,
        Binding $binding,
    ): ResponseValidator {
        $validator = new self($idpMetadata, $spMetadata);
        $validator->addConstraintValidator(new DestinationMatches($spMetadata, $binding));
//        $validator->addConstraintValidator(new IsSuccesful());

        return $validator;

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\SAML2\Process\Validator;
6
7			use SimpleSAML\SAML2\{Binding, Metadata};
8			use SimpleSAML\SAML2\Process\ConstraintValidation\Response\{DestinationMatches, IsSuccessful};
			0 ignored issues – show Bug introduced 2024-09-16 22:58 UTC by Report Bug Copy Issue Report The type `SimpleSAML\SAML2\Process...n\Response\IsSuccessful` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9
10			class ResponseValidator implements ValidatorInterface
11			{
12			use ValidatorTrait;
13
14			/**
15			* @param \SimpleSAML\SAML2\Metadata\IdentityProvider The IdP-metadata
			0 ignored issues – show Bug introduced 2024-09-16 22:58 UTC by Report Bug Copy Issue Report The type `SimpleSAML\SAML2\Process\Validator\The` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16			* @param \SimpleSAML\SAML2\Metadata\ServiceProvider The SP-metadata
17			*/
18			private function __construct(
19			protected ?Metadata\IdentityProvider $idpMetadata,
20			protected Metadata\ServiceProvider $spMetadata,
21			) {
22			}
23
24
25			/**
26			* @param \SimpleSAML\SAML2\Metadata\IdentityProvider\|null $idpMetadata
27			* @param \SimpleSAML\SAML2\Metadata\ServiceProvider $spMetadata
28			* @param string $binding
29			* @return \SimpleSAML\SAML2\Validator\ResponseValidator
			0 ignored issues – show Bug introduced 2024-09-16 22:58 UTC by Report Bug Copy Issue Report The type `SimpleSAML\SAML2\Validator\ResponseValidator` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
30			*/
31			public static function createResponseValidator(
32			?Metadata\IdentityProvider $idpMetadata,
33			Metadata\ServiceProvider $spMetadata,
34			Binding $binding,
35			): ResponseValidator {
36			$validator = new self($idpMetadata, $spMetadata);
37			$validator->addConstraintValidator(new DestinationMatches($spMetadata, $binding));
38			// $validator->addConstraintValidator(new IsSuccesful());
39
40			return $validator;
			0 ignored issues – show Bug Best Practice introduced 2024-09-16 22:58 UTC by Report Bug Copy Issue Report The expression `return $validator` returns the type `SimpleSAML\SAML2\Process...dator\ResponseValidator` which is incompatible with the documented return type `SimpleSAML\SAML2\Validator\ResponseValidator`. Loading history...
41			}
42			}
43

simplesamlphp / saml2

Pull Request — master (#363)

ResponseValidator::createResponseValidator() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like