Completed
Push — master ( 746563...99649c )
by Thijs
07:14
created
src/SAML2/Assertion.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
         if ($xml->getAttribute('Version') !== '2.0') {
248 248
             /* Currently a very strict check. */
249
-            throw new \Exception('Unsupported version: ' . $xml->getAttribute('Version'));
249
+            throw new \Exception('Unsupported version: '.$xml->getAttribute('Version'));
250 250
         }
251 251
 
252 252
         $this->issueInstant = Utils::xsDateTimeToTimestamp($xml->getAttribute('IssueInstant'));
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
                 continue;
347 347
             }
348 348
             if ($node->namespaceURI !== Constants::NS_SAML) {
349
-                throw new \Exception('Unknown namespace of condition: ' . var_export($node->namespaceURI, true));
349
+                throw new \Exception('Unknown namespace of condition: '.var_export($node->namespaceURI, true));
350 350
             }
351 351
             switch ($node->localName) {
352 352
                 case 'AudienceRestriction':
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
                     /* Currently ignored. */
370 370
                     break;
371 371
                 default:
372
-                    throw new \Exception('Unknown condition: ' . var_export($node->localName, true));
372
+                    throw new \Exception('Unknown condition: '.var_export($node->localName, true));
373 373
             }
374 374
         }
375 375
     }
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
 
531 531
             $type = $value->getAttribute('xsi:type');
532 532
             if ($type === 'xs:integer') {
533
-                $this->attributes[$attributeName][] = (int)$value->textContent;
533
+                $this->attributes[$attributeName][] = (int) $value->textContent;
534 534
             } else {
535 535
                 $this->attributes[$attributeName][] = trim($value->textContent);
536 536
             }
@@ -1287,7 +1287,7 @@  discard block
 block discarded – undo
1287 1287
             $document = $parentElement->ownerDocument;
1288 1288
         }
1289 1289
 
1290
-        $root = $document->createElementNS(Constants::NS_SAML, 'saml:' . 'Assertion');
1290
+        $root = $document->createElementNS(Constants::NS_SAML, 'saml:'.'Assertion');
1291 1291
         $parentElement->appendChild($root);
1292 1292
 
1293 1293
         /* Ugly hack to add another namespace declaration to the root element. */
@@ -1339,7 +1339,7 @@  discard block
 block discarded – undo
1339 1339
         if ($this->encryptedNameId === null) {
1340 1340
             Utils::addNameId($subject, $this->nameId);
1341 1341
         } else {
1342
-            $eid = $subject->ownerDocument->createElementNS(Constants::NS_SAML, 'saml:' . 'EncryptedID');
1342
+            $eid = $subject->ownerDocument->createElementNS(Constants::NS_SAML, 'saml:'.'EncryptedID');
1343 1343
             $subject->appendChild($eid);
1344 1344
             $eid->appendChild($subject->ownerDocument->importNode($this->encryptedNameId, true));
1345 1345
         }
Please login to merge, or discard this patch.
src/SAML2/Compat/Ssp/Logger.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
      */
16 16
     public function emergency($message, array $context = array())
17 17
     {
18
-        \SimpleSAML\Logger::emergency($message . var_export($context, true));
18
+        \SimpleSAML\Logger::emergency($message.var_export($context, true));
19 19
     }
20 20
 
21 21
     /**
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function alert($message, array $context = array())
32 32
     {
33
-        \SimpleSAML\Logger::alert($message . var_export($context, true));
33
+        \SimpleSAML\Logger::alert($message.var_export($context, true));
34 34
     }
35 35
 
36 36
     /**
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
      */
45 45
     public function critical($message, array $context = array())
46 46
     {
47
-        \SimpleSAML\Logger::critical($message . var_export($context, true));
47
+        \SimpleSAML\Logger::critical($message.var_export($context, true));
48 48
     }
49 49
 
50 50
     /**
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
      */
58 58
     public function error($message, array $context = array())
59 59
     {
60
-        \SimpleSAML\Logger::error($message . var_export($context, true));
60
+        \SimpleSAML\Logger::error($message.var_export($context, true));
61 61
     }
62 62
 
63 63
     /**
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     public function warning($message, array $context = array())
74 74
     {
75
-        \SimpleSAML\Logger::warning($message . var_export($context, true));
75
+        \SimpleSAML\Logger::warning($message.var_export($context, true));
76 76
     }
77 77
 
78 78
     /**
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function notice($message, array $context = array())
86 86
     {
87
-        \SimpleSAML\Logger::notice($message . var_export($context, true));
87
+        \SimpleSAML\Logger::notice($message.var_export($context, true));
88 88
     }
89 89
 
90 90
     /**
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
      */
99 99
     public function info($message, array $context = array())
100 100
     {
101
-        \SimpleSAML\Logger::info($message . var_export($context, true));
101
+        \SimpleSAML\Logger::info($message.var_export($context, true));
102 102
     }
103 103
 
104 104
     /**
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
      */
111 111
     public function debug($message, array $context = array())
112 112
     {
113
-        \SimpleSAML\Logger::debug($message . var_export($context, true));
113
+        \SimpleSAML\Logger::debug($message.var_export($context, true));
114 114
     }
115 115
 
116 116
     /**
Please login to merge, or discard this patch.
src/SAML2/Utils.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
         }
247 247
 
248 248
         foreach ($namespaces as $prefix => $uri) {
249
-            $newElement->setAttributeNS($uri, $prefix . ':__ns_workaround__', 'tmp');
249
+            $newElement->setAttributeNS($uri, $prefix.':__ns_workaround__', 'tmp');
250 250
             $newElement->removeAttributeNS($uri, '__ns_workaround__');
251 251
         }
252 252
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
             case 'true':
280 280
                 return true;
281 281
             default:
282
-                throw new \Exception('Invalid value of boolean attribute ' . var_export($attributeName, true) . ': ' . var_export($value, true));
282
+                throw new \Exception('Invalid value of boolean attribute '.var_export($attributeName, true).': '.var_export($value, true));
283 283
         }
284 284
     }
285 285
 
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
             $symKeyInfoAlgo = $symmetricKeyInfo->getAlgorith();
416 416
 
417 417
             if (in_array($symKeyInfoAlgo, $blacklist, true)) {
418
-                throw new \Exception('Algorithm disabled: ' . var_export($symKeyInfoAlgo, true));
418
+                throw new \Exception('Algorithm disabled: '.var_export($symKeyInfoAlgo, true));
419 419
             }
420 420
 
421 421
             if ($symKeyInfoAlgo === XMLSecurityKey::RSA_OAEP_MGF1P && $inputKeyAlgo === XMLSecurityKey::RSA_1_5) {
@@ -431,9 +431,9 @@  discard block
 block discarded – undo
431 431
             /* Make sure that the input key format is the same as the one used to encrypt the key. */
432 432
             if ($inputKeyAlgo !== $symKeyInfoAlgo) {
433 433
                 throw new \Exception(
434
-                    'Algorithm mismatch between input key and key used to encrypt ' .
435
-                    ' the symmetric key for the message. Key was: ' .
436
-                    var_export($inputKeyAlgo, true) . '; message was: ' .
434
+                    'Algorithm mismatch between input key and key used to encrypt '.
435
+                    ' the symmetric key for the message. Key was: '.
436
+                    var_export($inputKeyAlgo, true).'; message was: '.
437 437
                     var_export($symKeyInfoAlgo, true)
438 438
                 );
439 439
             }
@@ -447,20 +447,20 @@  discard block
 block discarded – undo
447 447
                 /* To protect against "key oracle" attacks, we need to be able to create a
448 448
                  * symmetric key, and for that we need to know the key size.
449 449
                  */
450
-                throw new \Exception('Unknown key size for encryption algorithm: ' . var_export($symmetricKey->type, true));
450
+                throw new \Exception('Unknown key size for encryption algorithm: '.var_export($symmetricKey->type, true));
451 451
             }
452 452
 
453 453
             try {
454 454
                 $key = $encKey->decryptKey($symmetricKeyInfo);
455 455
                 if (strlen($key) != $keySize) {
456 456
                     throw new \Exception(
457
-                        'Unexpected key size (' . strlen($key) * 8 . 'bits) for encryption algorithm: ' .
457
+                        'Unexpected key size ('.strlen($key)*8.'bits) for encryption algorithm: '.
458 458
                         var_export($symmetricKey->type, true)
459 459
                     );
460 460
                 }
461 461
             } catch (\Exception $e) {
462 462
                 /* We failed to decrypt this key. Log it, and substitute a "random" key. */
463
-                Utils::getContainer()->getLogger()->error('Failed to decrypt symmetric key: ' . $e->getMessage());
463
+                Utils::getContainer()->getLogger()->error('Failed to decrypt symmetric key: '.$e->getMessage());
464 464
                 /* Create a replacement key, so that it looks like we fail in the same way as if the key was correctly padded. */
465 465
 
466 466
                 /* We base the symmetric key on the encrypted key and private key, so that we always behave the
@@ -469,7 +469,7 @@  discard block
 block discarded – undo
469 469
                 $encryptedKey = $encKey->getCipherValue();
470 470
                 $pkey = openssl_pkey_get_details($symmetricKeyInfo->key);
471 471
                 $pkey = sha1(serialize($pkey), true);
472
-                $key = sha1($encryptedKey . $pkey, true);
472
+                $key = sha1($encryptedKey.$pkey, true);
473 473
 
474 474
                 /* Make sure that the key has the correct length. */
475 475
                 if (strlen($key) > $keySize) {
@@ -484,8 +484,8 @@  discard block
 block discarded – undo
484 484
             /* Make sure that the input key has the correct format. */
485 485
             if ($inputKeyAlgo !== $symKeyAlgo) {
486 486
                 throw new \Exception(
487
-                    'Algorithm mismatch between input key and key in message. ' .
488
-                    'Key was: ' . var_export($inputKeyAlgo, true) . '; message was: ' .
487
+                    'Algorithm mismatch between input key and key in message. '.
488
+                    'Key was: '.var_export($inputKeyAlgo, true).'; message was: '.
489 489
                     var_export($symKeyAlgo, true)
490 490
                 );
491 491
             }
@@ -494,7 +494,7 @@  discard block
 block discarded – undo
494 494
 
495 495
         $algorithm = $symmetricKey->getAlgorith();
496 496
         if (in_array($algorithm, $blacklist, true)) {
497
-            throw new \Exception('Algorithm disabled: ' . var_export($algorithm, true));
497
+            throw new \Exception('Algorithm disabled: '.var_export($algorithm, true));
498 498
         }
499 499
 
500 500
         /** @var string $decrypted */
@@ -506,8 +506,8 @@  discard block
 block discarded – undo
506 506
          * namespaces needed to parse the XML.
507 507
          */
508 508
         $xml = '<root xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" '.
509
-                     'xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">' .
510
-            $decrypted .
509
+                     'xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">'.
510
+            $decrypted.
511 511
             '</root>';
512 512
 
513 513
         try {
@@ -546,7 +546,7 @@  discard block
 block discarded – undo
546 546
              * Something went wrong during decryption, but for security
547 547
              * reasons we cannot tell the user what failed.
548 548
              */
549
-            Utils::getContainer()->getLogger()->error('Decryption failed: ' . $e->getMessage());
549
+            Utils::getContainer()->getLogger()->error('Decryption failed: '.$e->getMessage());
550 550
             throw new \Exception('Failed to decrypt XML element.', 0, $e);
551 551
         }
552 552
     }
@@ -708,7 +708,7 @@  discard block
 block discarded – undo
708 708
         $regex = '/^(\\d\\d\\d\\d)-(\\d\\d)-(\\d\\d)T(\\d\\d):(\\d\\d):(\\d\\d)(?:\\.\\d+)?Z$/D';
709 709
         if (preg_match($regex, $time, $matches) == 0) {
710 710
             throw new \Exception(
711
-                'Invalid SAML2 timestamp passed to xsDateTimeToTimestamp: ' . $time
711
+                'Invalid SAML2 timestamp passed to xsDateTimeToTimestamp: '.$time
712 712
             );
713 713
         }
714 714
 
Please login to merge, or discard this patch.
src/SAML2/XML/mdui/DiscoHints.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,8 +54,8 @@
 block discarded – undo
54 54
             return;
55 55
         }
56 56
 
57
-        $this->IPHint =          Utils::extractStrings($xml, Common::NS, 'IPHint');
58
-        $this->DomainHint =      Utils::extractStrings($xml, Common::NS, 'DomainHint');
57
+        $this->IPHint = Utils::extractStrings($xml, Common::NS, 'IPHint');
58
+        $this->DomainHint = Utils::extractStrings($xml, Common::NS, 'DomainHint');
59 59
         $this->GeolocationHint = Utils::extractStrings($xml, Common::NS, 'GeolocationHint');
60 60
 
61 61
         foreach (Utils::xpQuery($xml, "./*[namespace-uri()!='".Common::NS."']") as $node) {
Please login to merge, or discard this patch.