Result::addError() - Code Metrics - Inspection of "Merge pull request #57 from simplesamlphp/psr2" - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e360d...80bc96 )

by Daan van

created 2015-12-22 10:41 UTC

Result::addError() A

↳ Parent: Result

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	8
loc	8
rs	9.4286
cc	2
eloc	4
nc	2
nop	1

<?php

namespace SAML2\Assertion\Validation;

use SAML2\Exception\InvalidArgumentException;

/**
 * Simple Result object
 */
class Result

{
    /**
     * @var array
     */
    private $errors = array();

    /**
     * @param $message
     */
    public function addError($message)
    {
        if (!is_string($message)) {
            throw InvalidArgumentException::invalidType('string', $message);
        }

        $this->errors[] = $message;
    }

    /**
     * @return bool
     */
    public function isValid()
    {
        return empty($this->errors);
    }

    /**
     * @return array
     */
    public function getErrors()
    {
        return $this->errors;
    }
}


1		<?php
2
3		namespace SAML2\Assertion\Validation;
4
5		use SAML2\Exception\InvalidArgumentException;
6
7		/**
8		* Simple Result object
9		*/
10	View Code Duplication	class Result
		0 ignored issues – show Duplication introduced 2015-11-29 21:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* @var array
14		*/
15		private $errors = array();
16
17		/**
18		* @param $message
19		*/
20		public function addError($message)
21		{
22		if (!is_string($message)) {
23		throw InvalidArgumentException::invalidType('string', $message);
24		}
25
26		$this->errors[] = $message;
27		}
28
29		/**
30		* @return bool
31		*/
32		public function isValid()
33		{
34		return empty($this->errors);
35		}
36
37		/**
38		* @return array
39		*/
40		public function getErrors()
41		{
42		return $this->errors;
43		}
44		}
45

simplesamlphp / saml2

Push — master ( 4e360d...80bc96 )

Result::addError() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like