Completed
Push — master ( f8013d...9b3e48 )
by Thijs
06:13
created
src/SAML2/XML/saml/BaseIDType.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,6 @@
 block discarded – undo
70 70
     /**
71 71
      * Convert this BaseID to XML.
72 72
      *
73
-     * @param \DOMElement $element The element we are converting to XML.
74 73
      * @return \DOMElement The XML element after adding the data corresponding to this BaseID.
75 74
      */
76 75
     public function toXML(\DOMElement $parent = null)
Please login to merge, or discard this patch.
src/SAML2/XML/saml/NameIDType.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,6 @@
 block discarded – undo
77 77
     /**
78 78
      * Convert this NameIDType to XML.
79 79
      *
80
-     * @param \DOMElement $element The element we are converting to XML.
81 80
      *
82 81
      * @return \DOMElement The XML element after adding the data corresponding to this NameIDType.
83 82
      */
Please login to merge, or discard this patch.
src/SAML2/XML/mdui/DiscoHints.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,8 +54,8 @@
 block discarded – undo
54 54
             return;
55 55
         }
56 56
 
57
-        $this->IPHint =          Utils::extractStrings($xml, Common::NS, 'IPHint');
58
-        $this->DomainHint =      Utils::extractStrings($xml, Common::NS, 'DomainHint');
57
+        $this->IPHint = Utils::extractStrings($xml, Common::NS, 'IPHint');
58
+        $this->DomainHint = Utils::extractStrings($xml, Common::NS, 'DomainHint');
59 59
         $this->GeolocationHint = Utils::extractStrings($xml, Common::NS, 'GeolocationHint');
60 60
 
61 61
         foreach (Utils::xpQuery($xml, "./*[namespace-uri()!='".Common::NS."']") as $node) {
Please login to merge, or discard this patch.
src/SAML2/HTTPArtifact.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         }
40 40
 
41 41
         $generatedId = pack('H*', ((string) SimpleSAML_Utilities::stringToHex(SimpleSAML_Utilities::generateRandomBytes(20))));
42
-        $artifact = base64_encode("\x00\x04\x00\x00" . sha1($message->getIssuer(), true) . $generatedId) ;
42
+        $artifact = base64_encode("\x00\x04\x00\x00".sha1($message->getIssuer(), true).$generatedId);
43 43
         $artifactData = $message->toUnsignedXML();
44 44
         $artifactDataString = $artifactData->ownerDocument->saveXML($artifactData);
45 45
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     {
82 82
         if (array_key_exists('SAMLart', $_REQUEST)) {
83 83
             $artifact = base64_decode($_REQUEST['SAMLart']);
84
-            $endpointIndex =  bin2hex(substr($artifact, 2, 2));
84
+            $endpointIndex = bin2hex(substr($artifact, 2, 2));
85 85
             $sourceId = bin2hex(substr($artifact, 4, 20));
86 86
         } else {
87 87
             throw new \Exception('Missing SAMLart parameter.');
@@ -92,12 +92,12 @@  discard block
 block discarded – undo
92 92
         $idpMetadata = $metadataHandler->getMetaDataConfigForSha1($sourceId, 'saml20-idp-remote');
93 93
 
94 94
         if ($idpMetadata === null) {
95
-            throw new \Exception('No metadata found for remote provider with SHA1 ID: ' . var_export($sourceId, true));
95
+            throw new \Exception('No metadata found for remote provider with SHA1 ID: '.var_export($sourceId, true));
96 96
         }
97 97
 
98 98
         $endpoint = null;
99 99
         foreach ($idpMetadata->getEndpoints('ArtifactResolutionService') as $ep) {
100
-            if ($ep['index'] ===  hexdec($endpointIndex)) {
100
+            if ($ep['index'] === hexdec($endpointIndex)) {
101 101
                 $endpoint = $ep;
102 102
                 break;
103 103
             }
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
             throw new \Exception('No ArtifactResolutionService with the correct index.');
108 108
         }
109 109
 
110
-        Utils::getContainer()->getLogger()->debug("ArtifactResolutionService endpoint being used is := " . $endpoint['Location']);
110
+        Utils::getContainer()->getLogger()->debug("ArtifactResolutionService endpoint being used is := ".$endpoint['Location']);
111 111
 
112 112
         //Construct the ArtifactResolve Request
113 113
         $ar = new ArtifactResolve();
Please login to merge, or discard this patch.
src/SAML2/XML/mdui/Keywords.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
             if (strpos($keyword, "+") !== false) {
73 73
                 throw new \Exception('Keywords may not contain a "+" character.');
74 74
             }
75
-            $value .= str_replace(' ', '+', $keyword) . ' ';
75
+            $value .= str_replace(' ', '+', $keyword).' ';
76 76
         }
77 77
         $value = rtrim($value);
78 78
         $e->appendChild($doc->createTextNode($value));
Please login to merge, or discard this patch.
src/SAML2/Signature/ValidatorChain.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 
75 75
         throw new MissingConfigurationException(sprintf(
76 76
             'No certificates or fingerprints have been configured%s',
77
-            $configuration->has('entityid') ? ' for "' . $configuration->get('entityid') . '"' : ''
77
+            $configuration->has('entityid') ? ' for "'.$configuration->get('entityid').'"' : ''
78 78
         ));
79 79
     }
80 80
 }
Please login to merge, or discard this patch.
src/SAML2/Signature/FingerprintValidator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
         SignedElement $signedElement,
71 71
         CertificateProvider $configuration
72 72
     ) {
73
-        $this->certificates = array_map(function ($certificate) {
73
+        $this->certificates = array_map(function($certificate) {
74 74
             return X509::createFromCertificateData($certificate);
75 75
         }, $this->certificates);
76 76
 
Please login to merge, or discard this patch.
src/SAML2/SignedElementHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -176,8 +176,8 @@
 block discarded – undo
176 176
         foreach ($this->certificates as $cert) {
177 177
 
178 178
             /* Construct a PEM formatted certificate */
179
-            $pemCert = "-----BEGIN CERTIFICATE-----\n" .
180
-                chunk_split($cert, 64) .
179
+            $pemCert = "-----BEGIN CERTIFICATE-----\n".
180
+                chunk_split($cert, 64).
181 181
                 "-----END CERTIFICATE-----\n";
182 182
 
183 183
             /* Extract the public key from the certificate for validation. */
Please login to merge, or discard this patch.
src/SAML2/SOAP.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SAML2;
4 4
 
5 5
 use DOMDocument;
6
-
7 6
 use SAML2\XML\ecp\Response as ECPResponse;
8 7
 
9 8
 /**
Please login to merge, or discard this patch.