Completed
Pull Request — master (#56)
by Boy
04:21
created
src/SAML2/Assertion.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -651,7 +651,7 @@  discard block
 block discarded – undo
651 651
     /**
652 652
      * Check whether the NameId is encrypted.
653 653
      *
654
-     * @return TRUE if the NameId is encrypted, FALSE if not.
654
+     * @return boolean if the NameId is encrypted, FALSE if not.
655 655
      */
656 656
     public function isNameIdEncrypted()
657 657
     {
@@ -779,7 +779,7 @@  discard block
 block discarded – undo
779 779
      * This function returns NULL if there are no restrictions on how early the
780 780
      * assertion can be used.
781 781
      *
782
-     * @return int|NULL The earliest timestamp this assertion is valid.
782
+     * @return integer The earliest timestamp this assertion is valid.
783 783
      */
784 784
     public function getNotBefore()
785 785
     {
@@ -806,7 +806,7 @@  discard block
 block discarded – undo
806 806
      * This function returns NULL if there are no restrictions on how
807 807
      * late the assertion can be used.
808 808
      *
809
-     * @return int|NULL The latest timestamp this assertion is valid.
809
+     * @return integer The latest timestamp this assertion is valid.
810 810
      */
811 811
     public function getNotOnOrAfter()
812 812
     {
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
     /**
865 865
      * Retrieve the AuthnInstant of the assertion.
866 866
      *
867
-     * @return int|NULL The timestamp the user was authenticated, or NULL if the user isn't authenticated.
867
+     * @return integer The timestamp the user was authenticated, or NULL if the user isn't authenticated.
868 868
      */
869 869
     public function getAuthnInstant()
870 870
     {
@@ -1026,7 +1026,7 @@  discard block
 block discarded – undo
1026 1026
      * See:
1027 1027
      * @url http://docs.oasis-open.org/security/saml/v2.0/saml-authn-context-2.0-os.pdf
1028 1028
      *
1029
-     * @return \SAML2_XML_Chunk|NULL
1029
+     * @return SAML2_XML_Chunk
1030 1030
      */
1031 1031
     public function getAuthnContextDecl()
1032 1032
     {
@@ -1056,7 +1056,7 @@  discard block
 block discarded – undo
1056 1056
      *
1057 1057
      * The URI reference MAY directly resolve into an XML document containing the referenced declaration.
1058 1058
      *
1059
-     * @return string
1059
+     * @return SAML2_XML_Chunk
1060 1060
      */
1061 1061
     public function getAuthnContextDeclRef()
1062 1062
     {
@@ -1088,7 +1088,7 @@  discard block
 block discarded – undo
1088 1088
     /**
1089 1089
      * Retrieve all attributes.
1090 1090
      *
1091
-     * @return array All attributes, as an associative array.
1091
+     * @return DOMElement[] All attributes, as an associative array.
1092 1092
      */
1093 1093
     public function getAttributes()
1094 1094
     {
Please login to merge, or discard this patch.
src/SAML2/AuthnRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -563,7 +563,7 @@
 block discarded – undo
563 563
      * The returned NameId is in the format used by SAML2_Utils::addNameId().
564 564
      *
565 565
      * @see SAML2_Utils::addNameId()
566
-     * @return array|NULL The name identifier of the assertion.
566
+     * @return string The name identifier of the assertion.
567 567
      * @throws Exception
568 568
      */
569 569
     public function getNameId()
Please login to merge, or discard this patch.
src/SAML2/Certificate/KeyLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
      * are not configured to be used with the usage given
77 77
      *
78 78
      * @param array $configuredKeys
79
-     * @param       $usage
79
+     * @param       null|string $usage
80 80
      */
81 81
     public function loadKeys(array $configuredKeys, $usage)
82 82
     {
Please login to merge, or discard this patch.
src/SAML2/LogoutRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
     /**
103 103
      * Check whether the NameId is encrypted.
104 104
      *
105
-     * @return TRUE if the NameId is encrypted, FALSE if not.
105
+     * @return boolean if the NameId is encrypted, FALSE if not.
106 106
      */
107 107
     public function isNameIdEncrypted()
108 108
     {
Please login to merge, or discard this patch.
src/SAML2/Response.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     /**
44 44
      * Retrieve the assertions in this response.
45 45
      *
46
-     * @return SAML2_Assertion[]|SAML2_EncryptedAssertion[]
46
+     * @return SAML2_Utilities_ArrayCollection
47 47
      */
48 48
     public function getAssertions()
49 49
     {
Please login to merge, or discard this patch.
src/SAML2/Response/Processor.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      * @param SAML2_Configuration_Destination      $currentDestination
51 51
      * @param SAML2_Response                       $response
52 52
      *
53
-     * @return SAML2_Assertion[] Collection (SAML2_Utilities_ArrayCollection) of SAML2_Assertion objects
53
+     * @return SAML2_Utilities_ArrayCollection Collection (SAML2_Utilities_ArrayCollection) of SAML2_Assertion objects
54 54
      */
55 55
     public function process(
56 56
         SAML2_Configuration_ServiceProvider $serviceProviderConfiguration,
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     /**
121 121
      * @param SAML2_Response $response
122 122
      *
123
-     * @return SAML2_Assertion[]
123
+     * @return SAML2_Utilities_ArrayCollection
124 124
      */
125 125
     private function processAssertions(SAML2_Response $response)
126 126
     {
Please login to merge, or discard this patch.
src/SAML2/Utils.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -248,7 +248,7 @@
 block discarded – undo
248 248
      *
249 249
      * @param  DOMElement $node          The element we should fetch the attribute from.
250 250
      * @param  string     $attributeName The name of the attribute.
251
-     * @param  mixed      $default       The value that should be returned if the attribute doesn't exist.
251
+     * @param  false|null      $default       The value that should be returned if the attribute doesn't exist.
252 252
      * @return bool|mixed The value of the attribute, or $default if the attribute doesn't exist.
253 253
      * @throws Exception
254 254
      */
Please login to merge, or discard this patch.
src/SAML2/SOAPClient.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -208,6 +208,10 @@
 block discarded – undo
208 208
      * @param $soapmessage Soap response needs to be type DOMDocument
209 209
      * @return $soapfaultstring string|NULL
210 210
      */
211
+
212
+    /**
213
+     * @param DOMDocument $soapMessage
214
+     */
211 215
     private function getSOAPFault($soapMessage)
212 216
     {
213 217
         $soapFault = SAML2_Utils::xpQuery($soapMessage->firstChild, '/soap-env:Envelope/soap-env:Body/soap-env:Fault');
Please login to merge, or discard this patch.