Completed
Pull Request — master (#57)
by Daan van
07:20
created
src/SAML2/Assertion.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -657,7 +657,7 @@  discard block
 block discarded – undo
657 657
     /**
658 658
      * Check whether the NameId is encrypted.
659 659
      *
660
-     * @return true if the NameId is encrypted, false if not.
660
+     * @return boolean if the NameId is encrypted, false if not.
661 661
      */
662 662
     public function isNameIdEncrypted()
663 663
     {
@@ -785,7 +785,7 @@  discard block
 block discarded – undo
785 785
      * This function returns null if there are no restrictions on how early the
786 786
      * assertion can be used.
787 787
      *
788
-     * @return int|null The earliest timestamp this assertion is valid.
788
+     * @return integer The earliest timestamp this assertion is valid.
789 789
      */
790 790
     public function getNotBefore()
791 791
     {
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
      * This function returns null if there are no restrictions on how
813 813
      * late the assertion can be used.
814 814
      *
815
-     * @return int|null The latest timestamp this assertion is valid.
815
+     * @return integer The latest timestamp this assertion is valid.
816 816
      */
817 817
     public function getNotOnOrAfter()
818 818
     {
@@ -870,7 +870,7 @@  discard block
 block discarded – undo
870 870
     /**
871 871
      * Retrieve the AuthnInstant of the assertion.
872 872
      *
873
-     * @return int|null The timestamp the user was authenticated, or NULL if the user isn't authenticated.
873
+     * @return integer The timestamp the user was authenticated, or NULL if the user isn't authenticated.
874 874
      */
875 875
     public function getAuthnInstant()
876 876
     {
@@ -1032,7 +1032,7 @@  discard block
 block discarded – undo
1032 1032
      * See:
1033 1033
      * @url http://docs.oasis-open.org/security/saml/v2.0/saml-authn-context-2.0-os.pdf
1034 1034
      *
1035
-     * @return \SAML2\XML\Chunk|null
1035
+     * @return Chunk
1036 1036
      */
1037 1037
     public function getAuthnContextDecl()
1038 1038
     {
@@ -1062,7 +1062,7 @@  discard block
 block discarded – undo
1062 1062
      *
1063 1063
      * The URI reference MAY directly resolve into an XML document containing the referenced declaration.
1064 1064
      *
1065
-     * @return string
1065
+     * @return Chunk
1066 1066
      */
1067 1067
     public function getAuthnContextDeclRef()
1068 1068
     {
@@ -1094,7 +1094,7 @@  discard block
 block discarded – undo
1094 1094
     /**
1095 1095
      * Retrieve all attributes.
1096 1096
      *
1097
-     * @return array All attributes, as an associative array.
1097
+     * @return \DOMElement[] All attributes, as an associative array.
1098 1098
      */
1099 1099
     public function getAttributes()
1100 1100
     {
Please login to merge, or discard this patch.
src/SAML2/AuthnRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -569,7 +569,7 @@
 block discarded – undo
569 569
      * The returned NameId is in the format used by \SAML2\Utils::addNameId().
570 570
      *
571 571
      * @see \SAML2\Utils::addNameId()
572
-     * @return array|null The name identifier of the assertion.
572
+     * @return string The name identifier of the assertion.
573 573
      * @throws \Exception
574 574
      */
575 575
     public function getNameId()
Please login to merge, or discard this patch.
src/SAML2/LogoutRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
     /**
108 108
      * Check whether the NameId is encrypted.
109 109
      *
110
-     * @return true if the NameId is encrypted, false if not.
110
+     * @return boolean if the NameId is encrypted, false if not.
111 111
      */
112 112
     public function isNameIdEncrypted()
113 113
     {
Please login to merge, or discard this patch.
src/SAML2/Response.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     /**
46 46
      * Retrieve the assertions in this response.
47 47
      *
48
-     * @return \SAML2\Assertion[]|\SAML2\EncryptedAssertion[]
48
+     * @return Utilities\ArrayCollection
49 49
      */
50 50
     public function getAssertions()
51 51
     {
Please login to merge, or discard this patch.
src/SAML2/Response/Processor.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      * @param \SAML2\Configuration\Destination      $currentDestination
65 65
      * @param \SAML2\Response                       $response
66 66
      *
67
-     * @return \SAML2\Assertion[] Collection (\SAML2\Utilities\ArrayCollection) of \SAML2\Assertion objects
67
+     * @return \SAML2\Utilities\ArrayCollection Collection (\SAML2\Utilities\ArrayCollection) of \SAML2\Assertion objects
68 68
      */
69 69
     public function process(
70 70
         ServiceProvider $serviceProviderConfiguration,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     /**
135 135
      * @param \SAML2\Response $response
136 136
      *
137
-     * @return \SAML2\Assertion[]
137
+     * @return \SAML2\Utilities\ArrayCollection
138 138
      */
139 139
     private function processAssertions(Response $response)
140 140
     {
Please login to merge, or discard this patch.
src/SAML2/SOAPClient.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -212,6 +212,10 @@
 block discarded – undo
212 212
      * @param $soapmessage Soap response needs to be type DOMDocument
213 213
      * @return $soapfaultstring string|null
214 214
      */
215
+
216
+    /**
217
+     * @param \DOMDocument $soapMessage
218
+     */
215 219
     private function getSOAPFault($soapMessage)
216 220
     {
217 221
         $soapFault = Utils::xpQuery($soapMessage->firstChild, '/soap-env:Envelope/soap-env:Body/soap-env:Fault');
Please login to merge, or discard this patch.