EncryptedAssertion::wasSignedAtConstruction() - Code Metrics - Inspection of "Implement encrypted IDs" - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#225)

by Jaime Pérez

created 2020-04-21 11:45 UTC

EncryptedAssertion::wasSignedAtConstruction() A

↳ Parent: EncryptedAssertion

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php

declare(strict_types=1);

namespace SAML2\XML\saml;

use RobRichards\XMLSecLibs\XMLSecurityKey;
use SAML2\XML\EncryptedElementInterface;
use SAML2\XML\EncryptedElementTrait;
use SAML2\Utils;
use SAML2\XML\AbstractXMLElement;

/**
 * Class handling encrypted assertions.
 *
 * @package SimpleSAMLphp
 */
class EncryptedAssertion extends AbstractSamlElement implements EncryptedElementInterface
{
    use EncryptedElementTrait;


    /**
     * @var bool
     */
    protected $wasSignedAtConstruction = false;


    /**
     * @inheritDoc
     *
     * @return \SAML2\XML\saml\Assertion
     * @throws \Exception
     *
     * @psalm-suppress MismatchingDocblockReturnType
     * @psalm-suppress ImplementedReturnTypeMismatch
     */
    public function decrypt(XMLSecurityKey $key, array $blacklist = []): AbstractXMLElement
    {
        $assertionXML = Utils::decryptElement($this->encryptedData->toXML(), $key, $blacklist);

        Utils::getContainer()->debugMessage($assertionXML, 'decrypt');

        return new Assertion($assertionXML);

    }


    /**
     * @return bool
     */
    public function wasSignedAtConstruction(): bool
    {
        return $this->wasSignedAtConstruction;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SAML2\XML\saml;
6
7			use RobRichards\XMLSecLibs\XMLSecurityKey;
8			use SAML2\XML\EncryptedElementInterface;
9			use SAML2\XML\EncryptedElementTrait;
10			use SAML2\Utils;
11			use SAML2\XML\AbstractXMLElement;
12
13			/**
14			* Class handling encrypted assertions.
15			*
16			* @package SimpleSAMLphp
17			*/
18			class EncryptedAssertion extends AbstractSamlElement implements EncryptedElementInterface
19			{
20			use EncryptedElementTrait;
			1 ignored issue – show introduced 2020-04-21 10:53 UTC by Report Bug Copy Issue Report The trait `SAML2\XML\EncryptedElementTrait` requires some properties which are not provided by `SAML2\XML\saml\EncryptedAssertion`: `$localName`, `$namespaceURI` Loading history...
21
22			/**
23			* @var bool
24			*/
25			protected $wasSignedAtConstruction = false;
26
27
28			/**
29			* @inheritDoc
30			*
31			* @return \SAML2\XML\saml\Assertion
32			* @throws \Exception
33			*
34			* @psalm-suppress MismatchingDocblockReturnType
35			* @psalm-suppress ImplementedReturnTypeMismatch
36			*/
37			public function decrypt(XMLSecurityKey $key, array $blacklist = []): AbstractXMLElement
38			{
39			$assertionXML = Utils::decryptElement($this->encryptedData->toXML(), $key, $blacklist);
40
41			Utils::getContainer()->debugMessage($assertionXML, 'decrypt');
42
43			return new Assertion($assertionXML);
			1 ignored issue – show Bug Best Practice introduced 2020-04-21 10:33 UTC by Report Bug Copy Issue Report The expression `return new SAML2\XML\saml\Assertion($assertionXML)` returns the type `SAML2\XML\saml\Assertion` which is incompatible with the type-hinted return `SAML2\XML\AbstractXMLElement`. Loading history...
44			}
45
46
47			/**
48			* @return bool
49			*/
50			public function wasSignedAtConstruction(): bool
51			{
52			return $this->wasSignedAtConstruction;
53			}
54			}
55

simplesamlphp / saml2

Pull Request — master (#225)

EncryptedAssertion::wasSignedAtConstruction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like