Request::fromXML() - Code Metrics - Inspection of "Feature: samlp elements" - simplesamlphp/saml11 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#4)

by Tim

created 2024-12-31 00:44 UTC

Request::fromXML() B

↳ Parent: Request

Complexity

Conditions	7
Paths	1

Size

Total Lines	61
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	42
c	1
b	0
f	0
dl	0
loc	61
rs	8.3146
cc	7
nc	1
nop	1

How to fix Long Method

<?php

declare(strict_types=1);

namespace SimpleSAML\SAML11\XML\samlp;

use DateTimeImmutable;
use DOMElement;
use SimpleSAML\Assert\Assert;
use SimpleSAML\SAML11\Assert\Assert as SAMLAssert;
use SimpleSAML\SAML11\Exception\ProtocolViolationException;
use SimpleSAML\SAML11\Exception\VersionMismatchException;
use SimpleSAML\SAML11\XML\saml\AssertionIDReference;
use SimpleSAML\XML\Exception\InvalidDOMElementException;
use SimpleSAML\XML\Exception\MissingElementException;
use SimpleSAML\XML\Exception\TooManyElementsException;

use function array_merge;
use function array_pop;
use function preg_replace;

/**
 * Class representing a samlp:Request element.
 *
 * @package simplesaml/xml-saml11
 */
final class Request extends AbstractRequestType
{
    /**
     * Convert XML into Request
     *
     * @param \DOMElement $xml The XML element we should load
     * @return static
     *
     * @throws \SimpleSAML\XML\Exception\InvalidDOMElementException
     *   if the qualified name of the supplied element is wrong
     * @throws \SimpleSAML\XML\Exception\TooManyElementsException
     *   if too many child-elements of a type are specified
     * @throws \SimpleSAML\XML\Exception\MissingElementException
     *   if one of the mandatory child-elements is missing
     */
    public static function fromXML(DOMElement $xml): static
    {
        Assert::same($xml->localName, 'Request', InvalidDOMElementException::class);
        Assert::same($xml->namespaceURI, Request::NS, InvalidDOMElementException::class);

        $query = AbstractQuery::getChildrenOfClass($xml);
        Assert::maxCount($query, 1, TooManyElementsException::class);

        $subjectQuery = AbstractSubjectQuery::getChildrenOfClass($xml);
        Assert::maxCount($subjectQuery, 1, TooManyElementsException::class);

        $authenticationQuery = AuthenticationQuery::getChildrenOfClass($xml);
        Assert::maxCount($authenticationQuery, 1, TooManyElementsException::class);

        $attributeQuery = AttributeQuery::getChildrenOfClass($xml);
        Assert::maxCount($attributeQuery, 1, TooManyElementsException::class);

        $authorizationDecisionQuery = AuthorizationDecisionQuery::getChildrenOfClass($xml);
        Assert::maxCount($authorizationDecisionQuery, 1, TooManyElementsException::class);

        $query = array_merge(
            $query,
            $subjectQuery,
            $authenticationQuery,
            $attributeQuery,
            $authorizationDecisionQuery,
        );
        Assert::maxCount($query, 1, TooManyElementsException::class);

        $assertionIdReference = AssertionIDReference::getChildrenOfClass($xml);
        $assertionArtifact = AssertionArtifact::getChildrenOfClass($xml);

        Assert::true(
            !empty($query) || !empty($assertionIdReference) || !empty($assertionArtifact),
            TooManyElementsException::class,
        );
        Assert::false(
            empty($query) && empty($assertionIdReference) && empty($assertionArtifact),
            MissingElementException::class,
        );

        $majorVersion = self::getIntegerAttribute($xml, 'MajorVersion');
        Assert::same($majorVersion, 1, VersionMismatchException::class);

        $minorVersion = self::getIntegerAttribute($xml, 'MinorVersion');
        Assert::same($minorVersion, 1, VersionMismatchException::class);

        $issueInstant = self::getAttribute($xml, 'IssueInstant');
        // Strip sub-seconds - See paragraph 1.3.3 of SAML core specifications
        $issueInstant = preg_replace('/([.][0-9]+Z)$/', 'Z', $issueInstant, 1);

        SAMLAssert::validDateTime($issueInstant, ProtocolViolationException::class);
        $issueInstant = new DateTimeImmutable($issueInstant);

        return new static(
            $assertionIdReference ?: $assertionArtifact ?: array_pop($query),
            self::getAttribute($xml, 'RequestID'),
            $majorVersion,
            $minorVersion,
            $issueInstant,
            RespondWith::getChildrenOfClass($xml),
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\SAML11\XML\samlp;
6
7			use DateTimeImmutable;
8			use DOMElement;
9			use SimpleSAML\Assert\Assert;
10			use SimpleSAML\SAML11\Assert\Assert as SAMLAssert;
11			use SimpleSAML\SAML11\Exception\ProtocolViolationException;
12			use SimpleSAML\SAML11\Exception\VersionMismatchException;
13			use SimpleSAML\SAML11\XML\saml\AssertionIDReference;
14			use SimpleSAML\XML\Exception\InvalidDOMElementException;
15			use SimpleSAML\XML\Exception\MissingElementException;
16			use SimpleSAML\XML\Exception\TooManyElementsException;
17
18			use function array_merge;
19			use function array_pop;
20			use function preg_replace;
21
22			/**
23			* Class representing a samlp:Request element.
24			*
25			* @package simplesaml/xml-saml11
26			*/
27			final class Request extends AbstractRequestType
28			{
29			/**
30			* Convert XML into Request
31			*
32			* @param \DOMElement $xml The XML element we should load
33			* @return static
34			*
35			* @throws \SimpleSAML\XML\Exception\InvalidDOMElementException
36			* if the qualified name of the supplied element is wrong
37			* @throws \SimpleSAML\XML\Exception\TooManyElementsException
38			* if too many child-elements of a type are specified
39			* @throws \SimpleSAML\XML\Exception\MissingElementException
40			* if one of the mandatory child-elements is missing
41			*/
42			public static function fromXML(DOMElement $xml): static
43			{
44			Assert::same($xml->localName, 'Request', InvalidDOMElementException::class);
45			Assert::same($xml->namespaceURI, Request::NS, InvalidDOMElementException::class);
46
47			$query = AbstractQuery::getChildrenOfClass($xml);
48			Assert::maxCount($query, 1, TooManyElementsException::class);
49
50			$subjectQuery = AbstractSubjectQuery::getChildrenOfClass($xml);
51			Assert::maxCount($subjectQuery, 1, TooManyElementsException::class);
52
53			$authenticationQuery = AuthenticationQuery::getChildrenOfClass($xml);
54			Assert::maxCount($authenticationQuery, 1, TooManyElementsException::class);
55
56			$attributeQuery = AttributeQuery::getChildrenOfClass($xml);
57			Assert::maxCount($attributeQuery, 1, TooManyElementsException::class);
58
59			$authorizationDecisionQuery = AuthorizationDecisionQuery::getChildrenOfClass($xml);
60			Assert::maxCount($authorizationDecisionQuery, 1, TooManyElementsException::class);
61
62			$query = array_merge(
63			$query,
64			$subjectQuery,
65			$authenticationQuery,
66			$attributeQuery,
67			$authorizationDecisionQuery,
68			);
69			Assert::maxCount($query, 1, TooManyElementsException::class);
70
71			$assertionIdReference = AssertionIDReference::getChildrenOfClass($xml);
72			$assertionArtifact = AssertionArtifact::getChildrenOfClass($xml);
73
74			Assert::true(
75			!empty($query) \|\| !empty($assertionIdReference) \|\| !empty($assertionArtifact),
76			TooManyElementsException::class,
77			);
78			Assert::false(
79			empty($query) && empty($assertionIdReference) && empty($assertionArtifact),
80			MissingElementException::class,
81			);
82
83			$majorVersion = self::getIntegerAttribute($xml, 'MajorVersion');
84			Assert::same($majorVersion, 1, VersionMismatchException::class);
85
86			$minorVersion = self::getIntegerAttribute($xml, 'MinorVersion');
87			Assert::same($minorVersion, 1, VersionMismatchException::class);
88
89			$issueInstant = self::getAttribute($xml, 'IssueInstant');
90			// Strip sub-seconds - See paragraph 1.3.3 of SAML core specifications
91			$issueInstant = preg_replace('/([.][0-9]+Z)$/', 'Z', $issueInstant, 1);
92
93			SAMLAssert::validDateTime($issueInstant, ProtocolViolationException::class);
94			$issueInstant = new DateTimeImmutable($issueInstant);
95
96			return new static(
97			$assertionIdReference ?: $assertionArtifact ?: array_pop($query),
98			self::getAttribute($xml, 'RequestID'),
99			$majorVersion,
100			$minorVersion,
101			$issueInstant,
102			RespondWith::getChildrenOfClass($xml),
103			);
104			}
105			}
106

simplesamlphp / saml11

Pull Request — master (#4)

Request::fromXML() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like