Person::getAlias() - Code Metrics - Inspection of "Refactored some core types. More tests." - simplepie/simplepie-ng - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e52ce1...eef7fd )

by Ryan

created 2017-12-11 05:42 UTC

Person::getAlias() A

↳ Parent: Person

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Copyright (c) 2017 Ryan Parman <http://ryanparman.com>.
 * Copyright (c) 2017 Contributors.
 *
 * http://opensource.org/licenses/Apache2.0
 */

declare(strict_types=1);

namespace SimplePie\Type;

use DOMNode;
use Psr\Log\LoggerInterface;
use SimplePie\Configuration as C;
use SimplePie\Mixin as T;

class Person extends AbstractType implements TypeInterface, C\SetLoggerInterface
{
    use T\LoggerTrait;

    /**
     * The DOMNode element to parse.
     *
     * @var DOMNode
     */
    protected $node;

    /**
     * The person's name.
     *
     * @var string
     */
    protected $name;

    /**
     * The person's URL.
     *
     * @var string
     */
    protected $uri;

    /**
     * The person's email address.
     *
     * @var string
     */
    protected $email;

    /**
     * The person's avatar.
     *
     * @var string
     */
    protected $avatar;

    /**
     * Constructs a new instance of this class.
     *
     * @param DOMNode|null    $node   The `DOMNode` element to parse.
     * @param LoggerInterface $logger The PSR-3 logger.
     */
    public function __construct(?DOMNode $node = null, LoggerInterface $logger = null)
    {
        if ($node) {
            $this->logger = $logger ?? new NullLogger();
filter:
    dependency_paths: ["lib/*"]
            $this->node   = $node;
            $this->name   = new Node($this->node);

            foreach ($this->node->childNodes as $child) {
                $this->{$child->tagName} = new Node($child);
            }
        }
    }

    /**
     * Converts this object into a string representation.
     *
     * @return string
     */
    public function __toString(): string
    {
        if (null !== $this->name && (null !== $this->uri || null !== $this->email)
        ) {
            return \trim(\sprintf('%s <%s>', (string) $this->name, (string) $this->uri ?? (string) $this->email));
        }

        return \trim(
            (string) $this->name
            ?? (string) $this->uri
            ?? (string) $this->email
            ?? 'Unknown'
        );
    }

    /**
     * Gets the DOMNode element.
     *
     * @return DOMNode|null
     */
    public function getNode(): ?DOMNode
    {
        return $this->node;
    }

    /**
     * Finds the common internal alias for a given method name.
     *
     * @param string $nodeName The name of the method being called.
     *
     * @return string
     */
    protected function getAlias(string $nodeName): string
    {
        switch ($nodeName) {
            case 'url':
                return 'uri';

            default:
                return $nodeName;
        }
    }

    /**
     * Get the correct handler for a whitelisted method name.
     *
     * @param string $nodeName The name of the method being called.
     *
     * @throws SimplePieException
     *
     * @return Node
     */
    protected function getHandler(string $nodeName): Node
    {
        switch ($nodeName) {
            case 'name':
            case 'uri':
            case 'email':
            case 'avatar':
                return $this->{$nodeName} ?? new Node();

            default:
                throw new SimplePieException(
filter:
    dependency_paths: ["lib/*"]
                    \sprintf('%s is an unresolvable method.')
                );
        }
    }
}


1			<?php
2			/**
3			* Copyright (c) 2017 Ryan Parman <http://ryanparman.com>.
4			* Copyright (c) 2017 Contributors.
5			*
6			* http://opensource.org/licenses/Apache2.0
7			*/
8
9			declare(strict_types=1);
10
11			namespace SimplePie\Type;
12
13			use DOMNode;
14			use Psr\Log\LoggerInterface;
15			use SimplePie\Configuration as C;
16			use SimplePie\Mixin as T;
17
18			class Person extends AbstractType implements TypeInterface, C\SetLoggerInterface
19			{
20			use T\LoggerTrait;
21
22			/**
23			* The DOMNode element to parse.
24			*
25			* @var DOMNode
26			*/
27			protected $node;
28
29			/**
30			* The person's name.
31			*
32			* @var string
33			*/
34			protected $name;
35
36			/**
37			* The person's URL.
38			*
39			* @var string
40			*/
41			protected $uri;
42
43			/**
44			* The person's email address.
45			*
46			* @var string
47			*/
48			protected $email;
49
50			/**
51			* The person's avatar.
52			*
53			* @var string
54			*/
55			protected $avatar;
56
57			/**
58			* Constructs a new instance of this class.
59			*
60			* @param DOMNode\|null $node The `DOMNode` element to parse.
61			* @param LoggerInterface $logger The PSR-3 logger.
62			*/
63			public function __construct(?DOMNode $node = null, LoggerInterface $logger = null)
64			{
65			if ($node) {
66			$this->logger = $logger ?? new NullLogger();
			0 ignored issues – show Bug introduced 2017-12-11 03:35 UTC by Report Bug Copy Issue Report The type `SimplePie\Type\NullLogger` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
67			$this->node = $node;
68			$this->name = new Node($this->node);
69
70			foreach ($this->node->childNodes as $child) {
71			$this->{$child->tagName} = new Node($child);
72			}
73			}
74			}
75
76			/**
77			* Converts this object into a string representation.
78			*
79			* @return string
80			*/
81			public function __toString(): string
82			{
83			if (null !== $this->name && (null !== $this->uri \|\| null !== $this->email)
84			) {
85			return \trim(\sprintf('%s <%s>', (string) $this->name, (string) $this->uri ?? (string) $this->email));
86			}
87
88			return \trim(
89			(string) $this->name
90			?? (string) $this->uri
91			?? (string) $this->email
92			?? 'Unknown'
93			);
94			}
95
96			/**
97			* Gets the DOMNode element.
98			*
99			* @return DOMNode\|null
100			*/
101			public function getNode(): ?DOMNode
102			{
103			return $this->node;
104			}
105
106			/**
107			* Finds the common internal alias for a given method name.
108			*
109			* @param string $nodeName The name of the method being called.
110			*
111			* @return string
112			*/
113			protected function getAlias(string $nodeName): string
114			{
115			switch ($nodeName) {
116			case 'url':
117			return 'uri';
118
119			default:
120			return $nodeName;
121			}
122			}
123
124			/**
125			* Get the correct handler for a whitelisted method name.
126			*
127			* @param string $nodeName The name of the method being called.
128			*
129			* @throws SimplePieException
130			*
131			* @return Node
132			*/
133			protected function getHandler(string $nodeName): Node
134			{
135			switch ($nodeName) {
136			case 'name':
137			case 'uri':
138			case 'email':
139			case 'avatar':
140			return $this->{$nodeName} ?? new Node();
141
142			default:
143			throw new SimplePieException(
			0 ignored issues – show Bug introduced 2017-12-11 05:55 UTC by Report Bug Copy Issue Report The type `SimplePie\Type\SimplePieException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
144			\sprintf('%s is an unresolvable method.')
145			);
146			}
147			}
148			}
149

simplepie / simplepie-ng

Push — master ( e52ce1...eef7fd )

Person::getAlias() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like