Feed::getHandler() - Code Metrics - Inspection of "Feature/entries (#38)" - simplepie/simplepie-ng - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a13bb5...cada17 )

by Ryan

created 2017-12-28 09:46 UTC

Feed::getHandler() D

↳ Parent: Feed

Complexity

Conditions	17
Paths	17

Size

Total Lines	38
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	17
eloc	30
nc	17
nop	2
dl	0
loc	38
rs	4.9807
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Copyright (c) 2017–2018 Ryan Parman <http://ryanparman.com>.
 * Copyright (c) 2017–2018 Contributors.
 *
 * http://opensource.org/licenses/Apache2.0
 */

declare(strict_types=1);

namespace SimplePie\Type;

use Psr\Log\NullLogger;
use SimplePie\Configuration as C;
use SimplePie\Exception\SimplePieException;
use SimplePie\Mixin as Tr;
use SimplePie\Parser\Date as DateParser;
use stdClass;

/**
 * Represents the top-level of a feed.
 */
class Feed extends AbstractType implements BranchInterface, C\SetLoggerInterface
{
    use Tr\DateTrait;
    use Tr\DeepTypeTrait;
    use Tr\LoggerTrait;
    use Tr\RootTrait;

    /**
     * The preferred namespace alias for a given XML namespace URI. Should be
     * the result of a call to `SimplePie\Util\Ns`.
     *
     * @var string
     */
    protected $namespaceAlias;

    /**
     * Constructs a new instance of this class.
     *
     * @param string $namespaceAlias [description]
     */
    public function __construct(string $namespaceAlias)
    {
        $this->root           = new stdClass();

        $this->logger         = new NullLogger();
        $this->namespaceAlias = $namespaceAlias;
    }

    /**
     * Finds the common internal alias for a given method name.
     *
     * @param string $nodeName The name of the method being called.
     *
     * @return string
     *
     * phpcs:disable Generic.Metrics.CyclomaticComplexity.MaxExceeded
     */
    public function getAlias(string $nodeName): string
    {
        switch ($nodeName) {
            case 'categories':
                return 'category';

            case 'contributors':
                return 'contributor';

            case 'entries':
            case 'items':
                return 'entry';

            case 'language':
                return 'lang';

            case 'links':
                return 'link';

            case 'pubDate':
            case 'publishDate':
            case 'publishedDate':
                return 'published';

            default:
                return $nodeName;
        }
    }

    // phpcs:enable

    /**
     * Get the correct handler for a whitelisted method name.
     *
     * @param string $nodeName The name of the method being called.
     * @param array  $args     Any arguments passed into that method. The default value is an empty array.
     *
     * @throws SimplePieException
     *
     * @return mixed Either `TypeInterface` or `TypeInterface[]`.
     *
     * phpcs:disable Generic.Metrics.CyclomaticComplexity.MaxExceeded
     */
    public function getHandler(string $nodeName, array $args = [])
    {
        switch ($nodeName) {
            case 'id':
            case 'lang':
            case 'rights':
            case 'subtitle':
            case 'summary':
            case 'title':
                return $this->getScalarSingleValue($this->getRoot(), $nodeName, $args[0] ?? null);

            case 'published':
            case 'updated':
                return (new DateParser(
                    $this->getScalarSingleValue($this->getRoot(), $nodeName, $args[0] ?? null)->getValue(),
                    $this->outputTimezone,
                    $this->createFromFormat
                ))->getDateTime();

            case 'author':
                return $this->getComplexSingleValue($this->getRoot(), $nodeName, Person::class, $args[0] ?? null);

            case 'generator':
                return $this->getComplexSingleValue($this->getRoot(), $nodeName, Generator::class, $args[0] ?? null);

            case 'icon':
            case 'logo':
                return $this->getComplexSingleValue($this->getRoot(), $nodeName, Image::class, $args[0] ?? null);

            case 'category':
            case 'contributor':
            case 'entry':
            case 'link':
                return $this->getComplexMultipleValues($this->getRoot(), $nodeName, $args[0] ?? null);

            default:
                throw new SimplePieException(
                    $this->getUnresolvableMessage($nodeName)
                );
        }
    }

    // phpcs:enable
}


1			<?php
2			/**
3			* Copyright (c) 2017–2018 Ryan Parman <http://ryanparman.com>.
4			* Copyright (c) 2017–2018 Contributors.
5			*
6			* http://opensource.org/licenses/Apache2.0
7			*/
8
9			declare(strict_types=1);
10
11			namespace SimplePie\Type;
12
13			use Psr\Log\NullLogger;
14			use SimplePie\Configuration as C;
15			use SimplePie\Exception\SimplePieException;
16			use SimplePie\Mixin as Tr;
17			use SimplePie\Parser\Date as DateParser;
18			use stdClass;
19
20			/**
21			* Represents the top-level of a feed.
22			*/
23			class Feed extends AbstractType implements BranchInterface, C\SetLoggerInterface
24			{
25			use Tr\DateTrait;
26			use Tr\DeepTypeTrait;
27			use Tr\LoggerTrait;
28			use Tr\RootTrait;
29
30			/**
31			* The preferred namespace alias for a given XML namespace URI. Should be
32			* the result of a call to `SimplePie\Util\Ns`.
33			*
34			* @var string
35			*/
36			protected $namespaceAlias;
37
38			/**
39			* Constructs a new instance of this class.
40			*
41			* @param string $namespaceAlias [description]
42			*/
43			public function __construct(string $namespaceAlias)
44			{
45			$this->root = new stdClass();
			0 ignored issues – show Documentation Bug introduced 2017-12-28 09:34 UTC by Report Bug Copy Issue Report It seems like `new stdClass()` of type `stdClass` is incompatible with the declared type `SimplePie\Mixin\stdClass` of property `$root`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
46			$this->logger = new NullLogger();
47			$this->namespaceAlias = $namespaceAlias;
48			}
49
50			/**
51			* Finds the common internal alias for a given method name.
52			*
53			* @param string $nodeName The name of the method being called.
54			*
55			* @return string
56			*
57			* phpcs:disable Generic.Metrics.CyclomaticComplexity.MaxExceeded
58			*/
59			public function getAlias(string $nodeName): string
60			{
61			switch ($nodeName) {
62			case 'categories':
63			return 'category';
64
65			case 'contributors':
66			return 'contributor';
67
68			case 'entries':
69			case 'items':
70			return 'entry';
71
72			case 'language':
73			return 'lang';
74
75			case 'links':
76			return 'link';
77
78			case 'pubDate':
79			case 'publishDate':
80			case 'publishedDate':
81			return 'published';
82
83			default:
84			return $nodeName;
85			}
86			}
87
88			// phpcs:enable
89
90			/**
91			* Get the correct handler for a whitelisted method name.
92			*
93			* @param string $nodeName The name of the method being called.
94			* @param array $args Any arguments passed into that method. The default value is an empty array.
95			*
96			* @throws SimplePieException
97			*
98			* @return mixed Either `TypeInterface` or `TypeInterface[]`.
99			*
100			* phpcs:disable Generic.Metrics.CyclomaticComplexity.MaxExceeded
101			*/
102			public function getHandler(string $nodeName, array $args = [])
103			{
104			switch ($nodeName) {
105			case 'id':
106			case 'lang':
107			case 'rights':
108			case 'subtitle':
109			case 'summary':
110			case 'title':
111			return $this->getScalarSingleValue($this->getRoot(), $nodeName, $args[0] ?? null);
112
113			case 'published':
114			case 'updated':
115			return (new DateParser(
116			$this->getScalarSingleValue($this->getRoot(), $nodeName, $args[0] ?? null)->getValue(),
117			$this->outputTimezone,
118			$this->createFromFormat
119			))->getDateTime();
120
121			case 'author':
122			return $this->getComplexSingleValue($this->getRoot(), $nodeName, Person::class, $args[0] ?? null);
123
124			case 'generator':
125			return $this->getComplexSingleValue($this->getRoot(), $nodeName, Generator::class, $args[0] ?? null);
126
127			case 'icon':
128			case 'logo':
129			return $this->getComplexSingleValue($this->getRoot(), $nodeName, Image::class, $args[0] ?? null);
130
131			case 'category':
132			case 'contributor':
133			case 'entry':
134			case 'link':
135			return $this->getComplexMultipleValues($this->getRoot(), $nodeName, $args[0] ?? null);
136
137			default:
138			throw new SimplePieException(
139			$this->getUnresolvableMessage($nodeName)
140			);
141			}
142			}
143
144			// phpcs:enable
145			}
146

simplepie / simplepie-ng

Push — master ( a13bb5...cada17 )

Feed::getHandler() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like