StoragePdo::createInstance() - Code Metrics - Inspection of "add comments / add storageMysqli / fixes / tests" - simplario/checker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 7e9581...a7de0d )

by Vlad

created 2016-11-21 21:04 UTC

StoragePdo::createInstance() B

↳ Parent: StoragePdo

Complexity

Conditions	5
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	7
nc	1
nop	1

<?php

namespace Simplario\Checker\Checker;

use Simplario\Checker\ResultException\FailException;
use Simplario\Checker\ResultException\SuccessException;

/**
 * Class StoragePdo
 *
 * @package Simplario\Checker\Checker
 */
class StoragePdo extends AbstractChecker
{
    /**
     * @var string
     */
    protected $target = 'connect';

    /**
     * @param array $connect
     *
     * @return \PDO
     */
    protected function createInstance(array $connect)
    {
        // Exception on fail connection
        $instance = new \PDO(
            isset($connect['dsn']) ? $connect['user'] : null,
            isset($connect['user']) ? $connect['user'] : null,
            isset($connect['password']) ? $connect['password'] : null,
            isset($connect['options']) ? $connect['options'] : null
        );

        return $instance;
    }

    /**
     * @param array   $connect
     * @param boolean $expectExists
     * @param array   $task
     *
     * @throws FailException
     * @throws SuccessException
     */
    protected function testExists(array $connect, $expectExists, array $task)
    {
        $exists = true;
        $msg = 'Connection exists';

        try {
            $pdo = $this->createInstance($connect);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $ex) {
            $exists = false;
            $msg = "Unable to connect to database. " . $ex->getMessage();
        }

        if ($exists === $expectExists) {
            throw new SuccessException('Ok', $task);
        }

        throw new FailException($msg, $task);
    }
}


1			<?php
2
3			namespace Simplario\Checker\Checker;
4
5			use Simplario\Checker\ResultException\FailException;
6			use Simplario\Checker\ResultException\SuccessException;
7
8			/**
9			* Class StoragePdo
10			*
11			* @package Simplario\Checker\Checker
12			*/
13			class StoragePdo extends AbstractChecker
14			{
15			/**
16			* @var string
17			*/
18			protected $target = 'connect';
19
20			/**
21			* @param array $connect
22			*
23			* @return \PDO
24			*/
25			protected function createInstance(array $connect)
26			{
27			// Exception on fail connection
28			$instance = new \PDO(
29			isset($connect['dsn']) ? $connect['user'] : null,
30			isset($connect['user']) ? $connect['user'] : null,
31			isset($connect['password']) ? $connect['password'] : null,
32			isset($connect['options']) ? $connect['options'] : null
33			);
34
35			return $instance;
36			}
37
38			/**
39			* @param array $connect
40			* @param boolean $expectExists
41			* @param array $task
42			*
43			* @throws FailException
44			* @throws SuccessException
45			*/
46			protected function testExists(array $connect, $expectExists, array $task)
47			{
48			$exists = true;
49			$msg = 'Connection exists';
50
51			try {
52			$pdo = $this->createInstance($connect);
			0 ignored issues – show Unused Code introduced 2016-11-20 17:11 UTC by Report Bug Copy Issue Report `$pdo` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
53			} catch (\Exception $ex) {
54			$exists = false;
55			$msg = "Unable to connect to database. " . $ex->getMessage();
56			}
57
58			if ($exists === $expectExists) {
59			throw new SuccessException('Ok', $task);
60			}
61
62			throw new FailException($msg, $task);
63			}
64			}
65

simplario / checker

Push — develop ( 7e9581...a7de0d )

StoragePdo::createInstance() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like