Service   A
last analyzed

Complexity

Total Complexity 9

Size/Duplication

Total Lines 93
Duplicated Lines 25.81 %

Coupling/Cohesion

Components 1
Dependencies 3

Test Coverage

Coverage 100%

Importance

Changes 0
Metric Value
wmc 9
lcom 1
cbo 3
dl 24
loc 93
ccs 21
cts 21
cp 1
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A runCommand() 0 15 2
A testExists() 12 12 3
A testWhich() 12 12 2
A testVersion() 0 14 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Simplario\Checker\Checker;
4
5
use Simplario\Checker\ResultException\FailException;
6
use Simplario\Checker\ResultException\SuccessException;
7
8
/**
9
 * Class Service
10
 *
11
 * @package Simplario\Checker\Checker
12
 */
13
class Service extends AbstractChecker
14 3
{
15
    /**
16 3
     * @var string
17 3
     */
18 3
    protected $target = 'name';
19 3
20 3
    /**
21
     * @param string $command
22 3
     *
23
     * @return string
24 3
     */
25 3
    protected function runCommand($command)
26
    {
27 3
        $output = '';
28
        $process = popen($command, 'r');
29
        while (!feof($process)) {
30 2
            $t = fread($process, 4096);
31
            $output .= $t;
32 2
        }
33
        pclose($process);
34 2
35 1
        $output = strtr($output, ["\n" => ' ', "\r" => ' ', "\t" => ' ']);
36
        $output = trim($output);
37
38 1
        return $output;
39
    }
40 1
41
    /**
42
     * @param string  $name
43 1
     * @param boolean $expectExists
44
     * @param array   $task
45 1
     *
46
     * @throws FailException
47 1
     * @throws SuccessException
48
     */
49 View Code Duplication
    protected function testExists($name, $expectExists, array $task)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
50
    {
51 1
        $output = $this->runCommand("which {$name}");
52
53 1
        if (!empty($output) === $expectExists) {
54
            throw new SuccessException('Ok', $task);
55
        }
56
57
        $msg = $expectExists ? "Service '{$name}' is not exists'" : "Service '{$name}' is exists";
58
59
        throw new FailException($msg, $task);
60
    }
61
62
    /**
63
     * @param string  $name
64
     * @param boolean $expectWhich
65
     * @param array   $task
66
     *
67
     * @throws FailException
68
     * @throws SuccessException
69
     */
70 View Code Duplication
    protected function testWhich($name, $expectWhich, array $task)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
71
    {
72
        $output = $this->runCommand("which {$name}");
73
74
        if ($output === $expectWhich) {
75
            throw new SuccessException('Ok', $task);
76
        }
77
78
        $msg = "Service '{$name}' expected: '{$expectWhich}', but have {$output}";
79
80
        throw new FailException($msg, $task);
81
    }
82
83
    /**
84
     * @param string $name
85
     * @param string $version
86
     * @param array  $task
87
     *
88
     * @throws FailException
89
     * @throws SuccessException
90
     */
91
    protected function testVersion($name, $version, array $task)
92
    {
93
        $output = $this->runCommand("{$name} -version || {$name} -v || {$name} --version");
94
95
        $pattern = "/{$version}/i";
96
97
        if (preg_match($pattern, $output)) {
98
            throw new SuccessException('Ok', $task);
99
        }
100
101
        $msg = "Service '{$name}' version fail '{$version}'";
102
103
        throw new FailException($msg, $task);
104
    }
105
}
106