Simara\Cart\Infrastructure\DoctrineCartRepository

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	0	3	1
A	__construct()	0	3	1
A	get()	0	7	2
A	find()	0	12	1
A	remove()	0	4	1

<?php

namespace Simara\Cart\Infrastructure;

use Doctrine\ORM\EntityManager;
use Simara\Cart\Domain\Cart;
use Simara\Cart\Domain\CartNotFoundException;
use Simara\Cart\Domain\CartRepository;
use TypeError;

class DoctrineCartRepository implements CartRepository
{

    /**
     * @var EntityManager
     */
    private $entityManger;

    public function __construct(EntityManager $entityManger)
    {
        $this->entityManger = $entityManger;
    }

    public function add(Cart $cart): void
    {
        $this->entityManger->persist($cart);
    }

    public function get(string $id): Cart
    {
        $result = $this->find($id);
        if ($result === null) {
            throw new CartNotFoundException();
        }
        return $result;
    }

    private function find(string $id): ?Cart
    {
        $queryBuilder = $this->entityManger->createQueryBuilder();
        $queryBuilder
            ->select('cart, items')
            ->from(Cart::class, 'cart')
            ->leftJoin('cart.items', 'items')
            ->where('cart.id = :id')
            ->setParameter(':id', $id);

        $query = $queryBuilder->getQuery();
        return $query->getResult();

The expression return $query->getResult() could return the type array which is incompatible with the type-hinted return null|Simara\Cart\Domain\Cart. Consider adding an additional type-check to rule them out.

    }

    public function remove(string $id): void
    {
        $cart = $this->get($id);
        $this->entityManger->remove($cart);
    }
}