Sms::__construct() - Code Metrics - Inspection of "Remove Recipients validation -> make server handle..." - simPod/SMSManager - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4f3d6d...5eac22 )

by Šimon

created 2018-05-09 11:26 UTC

Sms::__construct() A

↳ Parent: Sms

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	16
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	13
nc	2
nop	5
crap	6

<?php

declare(strict_types=1);

namespace SimPod\SmsManager;

class Sms
{
    /** @var string */
    protected $message;

    /** @var RequestType */
    protected $type;

    /** @var string[] */
    protected $recipients = [];

    /** @var string|null */
    protected $sender;

    /** @var int|null */
    protected $customId;

    /**
     * @param string[] $recipients
     */
    public function __construct(
        string $message,
        array $recipients,
        ?RequestType $type = null,
        ?string $sender = null,
        ?int $customId = null
    ) {
        $this->message = $message;

        if ($type === null) {
            $type = RequestType::getRequestTypeHigh();
        }
        $this->type       = $type;
        $this->sender     = $sender;
        $this->customId   = $customId;
        $this->recipients = $recipients;
    }

    public function getMessage() : string
    {
        return $this->message;
    }

    public function getType() : RequestType
    {
        return $this->type;
    }

    /**
     * @return string[]
     */
    public function getRecipients() : array
    {
        return $this->recipients;
    }

    public function getSender() : ?string
    {
        return $this->sender;
    }

    public function getCustomId() : ?int
    {
        return $this->customId;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimPod\SmsManager;
6
7			class Sms
8			{
9			/** @var string */
10			protected $message;
11
12			/** @var RequestType */
13			protected $type;
14
15			/** @var string[] */
16			protected $recipients = [];
17
18			/** @var string\|null */
19			protected $sender;
20
21			/** @var int\|null */
22			protected $customId;
23
24			/**
25			* @param string[] $recipients
26			*/
27			public function __construct(
28			string $message,
29			array $recipients,
30			?RequestType $type = null,
31			?string $sender = null,
32			?int $customId = null
33			) {
34			$this->message = $message;
35
36			if ($type === null) {
37			$type = RequestType::getRequestTypeHigh();
38			}
39			$this->type = $type;
40			$this->sender = $sender;
41			$this->customId = $customId;
42			$this->recipients = $recipients;
43			}
44
45			public function getMessage() : string
46			{
47			return $this->message;
48			}
49
50			public function getType() : RequestType
51			{
52			return $this->type;
53			}
54
55			/**
56			* @return string[]
57			*/
58			public function getRecipients() : array
59			{
60			return $this->recipients;
61			}
62
63			public function getSender() : ?string
64			{
65			return $this->sender;
66			}
67
68			public function getCustomId() : ?int
69			{
70			return $this->customId;
71			}
72			}
73

simPod / SMSManager

GitHub Access Token became invalid

Push — master ( 4f3d6d...5eac22 )

Sms::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like