| Conditions | 6 |
| Paths | 12 |
| Total Lines | 56 |
| Code Lines | 28 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 57 | private static function getMigrationQueries(PDO $connection, ?string $tableName = null): array |
||
| 58 | { |
||
| 59 | $driver = $connection->getAttribute(PDO::ATTR_DRIVER_NAME); |
||
| 60 | $createdAtDefault = ($driver === 'pgsql') ? 'DEFAULT NOW()' : 'DEFAULT CURRENT_TIMESTAMP'; |
||
| 61 | $table = $tableName ?: (defined('CACHEER_TABLE') ? CACHEER_TABLE : 'cacheer_table'); |
||
| 62 | |||
| 63 | if ($driver === 'sqlite') { |
||
| 64 | $query = " |
||
| 65 | CREATE TABLE IF NOT EXISTS {$table} ( |
||
| 66 | id INTEGER PRIMARY KEY AUTOINCREMENT, |
||
| 67 | cacheKey VARCHAR(255) NOT NULL, |
||
| 68 | cacheData TEXT NOT NULL, |
||
| 69 | cacheNamespace VARCHAR(255), |
||
| 70 | expirationTime DATETIME NOT NULL, |
||
| 71 | created_at DATETIME $createdAtDefault, |
||
| 72 | UNIQUE(cacheKey, cacheNamespace) |
||
| 73 | ); |
||
| 74 | CREATE INDEX IF NOT EXISTS idx_{$table}_cacheKey ON {$table} (cacheKey); |
||
| 75 | CREATE INDEX IF NOT EXISTS idx_{$table}_cacheNamespace ON {$table} (cacheNamespace); |
||
| 76 | CREATE INDEX IF NOT EXISTS idx_{$table}_expirationTime ON {$table} (expirationTime); |
||
| 77 | CREATE INDEX IF NOT EXISTS idx_{$table}_key_namespace ON {$table} (cacheKey, cacheNamespace); |
||
| 78 | "; |
||
| 79 | } elseif ($driver === 'pgsql') { |
||
| 80 | $query = " |
||
| 81 | CREATE TABLE IF NOT EXISTS {$table} ( |
||
| 82 | id SERIAL PRIMARY KEY, |
||
| 83 | cacheKey VARCHAR(255) NOT NULL, |
||
| 84 | cacheData TEXT NOT NULL, |
||
| 85 | cacheNamespace VARCHAR(255), |
||
| 86 | expirationTime TIMESTAMP NOT NULL, |
||
| 87 | created_at TIMESTAMP $createdAtDefault, |
||
| 88 | UNIQUE(cacheKey, cacheNamespace) |
||
| 89 | ); |
||
| 90 | CREATE INDEX IF NOT EXISTS idx_{$table}_cacheKey ON {$table} (cacheKey); |
||
| 91 | CREATE INDEX IF NOT EXISTS idx_{$table}_cacheNamespace ON {$table} (cacheNamespace); |
||
| 92 | CREATE INDEX IF NOT EXISTS idx_{$table}_expirationTime ON {$table} (expirationTime); |
||
| 93 | CREATE INDEX IF NOT EXISTS idx_{$table}_key_namespace ON {$table} (cacheKey, cacheNamespace); |
||
| 94 | "; |
||
| 95 | } else { |
||
| 96 | $query = " |
||
| 97 | CREATE TABLE IF NOT EXISTS {$table} ( |
||
| 98 | id INT(11) NOT NULL AUTO_INCREMENT PRIMARY KEY, |
||
| 99 | cacheKey VARCHAR(255) NOT NULL, |
||
| 100 | cacheData LONGTEXT NOT NULL, |
||
| 101 | cacheNamespace VARCHAR(255) NULL, |
||
| 102 | expirationTime DATETIME NOT NULL, |
||
| 103 | created_at TIMESTAMP $createdAtDefault, |
||
| 104 | UNIQUE KEY unique_cache_key_namespace (cacheKey, cacheNamespace), |
||
| 105 | KEY idx_{$table}_cacheKey (cacheKey), |
||
| 106 | KEY idx_{$table}_cacheNamespace (cacheNamespace), |
||
| 107 | KEY idx_{$table}_expirationTime (expirationTime), |
||
| 108 | KEY idx_{$table}_key_namespace (cacheKey, cacheNamespace) |
||
| 109 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4; |
||
| 110 | "; |
||
| 111 | } |
||
| 112 | return array_filter(array_map('trim', explode(';', $query))); |
||
| 113 | } |
||
| 115 |