Completed
Push — master ( 2a03e3...273839 )
by Damian
9s
created
tests/DataExtractor/CsvTableReaderTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,18 +6,18 @@
 block discarded – undo
6 6
 {
7 7
 	public function testCsvReading() {
8 8
 
9
-		$csv = new CsvTableReader(__DIR__ . '/fixture/input.csv');
9
+		$csv = new CsvTableReader(__DIR__.'/fixture/input.csv');
10 10
 		$this->assertEquals(['Col1', 'Col2', 'Col3'], $csv->getColumns());
11 11
 
12 12
 		$extractedData = [];
13
-		foreach($csv as $record) {
13
+		foreach ($csv as $record) {
14 14
 			$extractedData[] = $record;
15 15
 		}
16 16
 
17 17
 		$this->assertEquals(
18 18
 			[
19
-				[ 'Col1' => 'One', 'Col2' => 2, 'Col3' => 'Three' ],
20
-				[ 'Col1' => 'Hello, Sam', 'Col2' => 5, 'Col3' => "Nice to meet you\nWhat is your name?" ]
19
+				['Col1' => 'One', 'Col2' => 2, 'Col3' => 'Three'],
20
+				['Col1' => 'Hello, Sam', 'Col2' => 5, 'Col3' => "Nice to meet you\nWhat is your name?"]
21 21
 			],
22 22
 			$extractedData
23 23
 		);
Please login to merge, or discard this patch.
src/Webroot.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 	 * Calls sniff once and then caches
17 17
 	 */
18 18
 	public function details() {
19
-		if(!$this->details) $this->details = $this->sniff();
19
+		if (!$this->details) $this->details = $this->sniff();
20 20
 		return $this->details;
21 21
 	}
22 22
 
@@ -26,16 +26,16 @@  discard block
 block discarded – undo
26 26
 	public function sniff() {
27 27
 		global $snifferFileContent;
28 28
 
29
-		if(!$snifferFileContent) $snifferFileContent = file_get_contents(PACKAGE_ROOT . 'src/sspak-sniffer.php');
29
+		if (!$snifferFileContent) $snifferFileContent = file_get_contents(PACKAGE_ROOT.'src/sspak-sniffer.php');
30 30
 
31
-		$remoteSniffer = '/tmp/sspak-sniffer-' . rand(100000,999999) . '.php';
31
+		$remoteSniffer = '/tmp/sspak-sniffer-'.rand(100000, 999999).'.php';
32 32
 		$this->uploadContent($snifferFileContent, $remoteSniffer);
33 33
 
34 34
 		$result = $this->execSudo(array('/usr/bin/env', 'php', $remoteSniffer, $this->path));
35 35
 		$this->unlink($remoteSniffer);
36 36
 
37 37
 		$parsed = @unserialize($result['output']);
38
-		if(!$parsed) throw new Exception("Could not parse sspak-sniffer content:\n{$result['output']}\n");
38
+		if (!$parsed) throw new Exception("Could not parse sspak-sniffer content:\n{$result['output']}\n");
39 39
 		return $parsed;
40 40
 	}
41 41
 
@@ -44,19 +44,19 @@  discard block
 block discarded – undo
44 44
 	 * @param  string $command Shell command, either a fully escaped string or an array
45 45
 	 */
46 46
 	public function execSudo($command) {
47
-		if($this->sudo) {
48
-			if(is_array($command)) $command = $this->executor->commandArrayToString($command);
47
+		if ($this->sudo) {
48
+			if (is_array($command)) $command = $this->executor->commandArrayToString($command);
49 49
 			// Try running sudo without asking for a password
50 50
 			try {
51
-				return $this->exec("sudo -n -u " . escapeshellarg($this->sudo) . " " . $command);
51
+				return $this->exec("sudo -n -u ".escapeshellarg($this->sudo)." ".$command);
52 52
 
53 53
 			// Otherwise capture SUDO password ourselves and pass it in through STDIN
54
-			} catch(Exception $e) {
54
+			} catch (Exception $e) {
55 55
 				echo "[sspak sudo] Enter your password: ";
56
-				$stdin = fopen( 'php://stdin', 'r');
56
+				$stdin = fopen('php://stdin', 'r');
57 57
 				$password = fgets($stdin);
58 58
 
59
-				return $this->exec("sudo -S -p '' -u " . escapeshellarg($this->sudo) . " " . $command, array('inputContent' => $password));
59
+				return $this->exec("sudo -S -p '' -u ".escapeshellarg($this->sudo)." ".$command, array('inputContent' => $password));
60 60
 			}
61 61
 
62 62
 		} else {
@@ -75,8 +75,8 @@  discard block
 block discarded – undo
75 75
 
76 76
 		// Check the database type
77 77
 		$dbFunction = 'putdb_'.$details['db_type'];
78
-		if(!method_exists($this,$dbFunction)) {
79
-			throw new Exception("Can't process database type '" . $details['db_type'] . "'");
78
+		if (!method_exists($this, $dbFunction)) {
79
+			throw new Exception("Can't process database type '".$details['db_type']."'");
80 80
 		}
81 81
 
82 82
 		// Extract DB direct from sspak file
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 		$hostArg = '';
96 96
 		$portArg = '';
97 97
 		if (!empty($conf['db_server']) && $conf['db_server'] != 'localhost') {
98
-			if (strpos($conf['db_server'], ':')!==false) {
98
+			if (strpos($conf['db_server'], ':') !== false) {
99 99
 				// Handle "server:port" format.
100 100
 				$server = explode(':', $conf['db_server'], 2);
101 101
 				$hostArg = escapeshellarg("--host=".$server[0]);
@@ -104,9 +104,9 @@  discard block
 block discarded – undo
104 104
 				$hostArg = escapeshellarg("--host=".$conf['db_server']);
105 105
 			}
106 106
 		}
107
-		$dbCommand = "create database if not exists `" . addslashes($conf['db_database']) . "`";
108
-		if($dropdb) {
109
-			$dbCommand = "drop database if exists `" . addslashes($conf['db_database']) . "`; " . $dbCommand;
107
+		$dbCommand = "create database if not exists `".addslashes($conf['db_database'])."`";
108
+		if ($dropdb) {
109
+			$dbCommand = "drop database if exists `".addslashes($conf['db_database'])."`; ".$dbCommand;
110 110
 		}
111 111
 
112 112
 		$this->exec("echo '$dbCommand' | mysql $usernameArg $passwordArg $hostArg $portArg");
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
 		// Create database if needed
128 128
 		$result = $this->exec("echo \"select count(*) from pg_catalog.pg_database where datname = $databaseArg\" | $passwordArg psql $usernameArg $hostArg $databaseArg -qt");
129
-		if(trim($result['output']) == '0') {
129
+		if (trim($result['output']) == '0') {
130 130
 			$this->exec("$passwordArg createdb $usernameArg $hostArg $databaseArg");
131 131
 		}
132 132
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 		$assetsPathExec = $this->exec("if [ -L {$assetsPath} ]; then readlink -f {$assetsPath}; else echo {$assetsPath}; fi");
145 145
 		$assetsPath = trim($assetsPathExec["output"]);
146 146
 
147
-		$assetsOldPath = $assetsPath . '.old';
147
+		$assetsOldPath = $assetsPath.'.old';
148 148
 		$assetsParentArg = escapeshellarg(dirname($assetsPath));
149 149
 
150 150
 		// Move existing assets to assets.old
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	public function putgit($details) {
169 169
 		$this->exec(array('git', 'clone', $details['remote'], $this->path));
170
-		$this->exec("cd $this->path && git checkout " . escapeshellarg($details['branch']));
170
+		$this->exec("cd $this->path && git checkout ".escapeshellarg($details['branch']));
171 171
 		return true;
172 172
 	}
173 173
 }
Please login to merge, or discard this patch.
src/sspak-sniffer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -7,13 +7,13 @@  discard block
 block discarded – undo
7 7
  */
8 8
 
9 9
 // Argument parsing
10
-if(empty($_SERVER['argv'][1])) {
10
+if (empty($_SERVER['argv'][1])) {
11 11
 	echo "Usage: {$_SERVER['argv'][0]} (site-docroot)\n";
12 12
 	exit(1);
13 13
 }
14 14
 
15 15
 $basePath = $_SERVER['argv'][1];
16
-if($basePath[0] != '/') $basePath = getcwd() . '/' . $basePath;
16
+if ($basePath[0] != '/') $basePath = getcwd().'/'.$basePath;
17 17
 
18 18
 // SilverStripe bootstrap
19 19
 define('BASE_PATH', realpath($basePath));
@@ -23,15 +23,15 @@  discard block
 block discarded – undo
23 23
 $_SERVER['HTTP_HOST'] = 'localhost';
24 24
 chdir(BASE_PATH);
25 25
 
26
-if(file_exists(BASE_PATH.'/sapphire/core/Core.php')) {
26
+if (file_exists(BASE_PATH.'/sapphire/core/Core.php')) {
27 27
 	//SS 2.x
28
-	require_once(BASE_PATH . '/sapphire/core/Core.php');
29
-} else if(file_exists(BASE_PATH.'/framework/core/Core.php')) {
28
+	require_once(BASE_PATH.'/sapphire/core/Core.php');
29
+} else if (file_exists(BASE_PATH.'/framework/core/Core.php')) {
30 30
 	//SS 3.x
31
-	require_once(BASE_PATH. '/framework/core/Core.php');
32
-} else if(file_exists(BASE_PATH.'/vendor/silverstripe/framework')) {
31
+	require_once(BASE_PATH.'/framework/core/Core.php');
32
+} else if (file_exists(BASE_PATH.'/vendor/silverstripe/framework')) {
33 33
 	//SS 4.x
34
-	require_once(BASE_PATH. '/vendor/autoload.php');
34
+	require_once(BASE_PATH.'/vendor/autoload.php');
35 35
 	$kernel = new SilverStripe\Core\CoreKernel(BASE_PATH);
36 36
 	//boot the parts of the kernel to populate the DB config
37 37
 	foreach (array('bootDatabaseEnvVars', 'bootDatabaseGlobals') as $bootMethod) {
@@ -41,13 +41,13 @@  discard block
 block discarded – undo
41 41
 	}
42 42
 	$databaseConfig = SilverStripe\ORM\DB::getConfig();
43 43
 } else {
44
-	echo "Couldn't locate framework's Core.php. Perhaps " . BASE_PATH . " is not a SilverStripe project?\n";
44
+	echo "Couldn't locate framework's Core.php. Perhaps ".BASE_PATH." is not a SilverStripe project?\n";
45 45
 	exit(2);
46 46
 }
47 47
 
48 48
 $output = array();
49
-foreach($databaseConfig as $k => $v) {
50
-	$output['db_' . $k] = $v;
49
+foreach ($databaseConfig as $k => $v) {
50
+	$output['db_'.$k] = $v;
51 51
 }
52 52
 $output['assets_path'] = ASSETS_PATH;
53 53
 
Please login to merge, or discard this patch.