SilverStripe\VersionedAdmin\Controllers\CMSPageHistoryViewerController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getEditForm()	0	19	3
A	getTabIdentifier()	0	3	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 21 and the first side effect is on line 13.

namespace SilverStripe\VersionedAdmin\Controllers;

use SilverStripe\CMS\Controllers\CMSMain;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\HiddenField;
use SilverStripe\ORM\DataObject;
use SilverStripe\VersionedAdmin\Forms\HistoryViewerField;

if (!class_exists(CMSMain::class)) {
    return;
}

/**
 * The history viewer controller replaces the {@link CMSPageHistoryController} and uses the React based
 * {@link HistoryViewerField} to display the history for a {@link DataObject} that has the {@link Versioned}
 * extension.
 */
class CMSPageHistoryViewerController extends CMSMain
{
    private static $url_segment = 'pages/history';

The private property $url_segment is not used, and could be removed.

    private static $url_rule = '/$Action/$ID/$VersionID/$OtherVersionID';

The private property $url_rule is not used, and could be removed.

    private static $url_priority = 42;

The private property $url_priority is not used, and could be removed.

    private static $required_permission_codes = 'CMS_ACCESS_CMSMain';

The private property $required_permission_codes is not used, and could be removed.

    public function getEditForm($id = null, $fields = null)
    {
        /** @var DataObject $record */
        $record = $this->getRecord($id ?: $this->currentPageID());

        /** @var Form $form */
        $form = parent::getEditForm($id);
        $form->addExtraClass('history-viewer__form');

        if ($record) {

$record is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            $fieldList = FieldList::create(
                HiddenField::create('ID', null, $record->ID),
                HistoryViewerField::create('PageHistory')
                    ->setForm($form)
            );
            $form->setFields($fieldList);
        }

        return $form;
    }

    public function getTabIdentifier()
    {
        return 'history';
    }
}