HistoryControllerFactory::create() - Code Metrics - Inspection of "NEW Allow history viewer to be activated by module..." - silverstripe/silverstripe-versioned-admin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#18)

unknown

created 2018-06-05 05:32 UTC

HistoryControllerFactory::create() A

↳ Parent: HistoryControllerFactory

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	7
nc	3
nop	2
dl	0
loc	14
rs	9.2
c	0
b	0
f	0

<?php
/**
 *
 */

namespace SilverStripe\VersionedAdmin\Factories;

use SilverStripe\CMS\Controllers\CMSPageHistoryController;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Extensible;
use SilverStripe\Core\Injector\Factory;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\VersionedAdmin\Controllers\CMSPageHistoryViewerController;

class HistoryControllerFactory implements Factory
{
    use Extensible;

    public function create($service, array $params = array())
    {
        $request = Injector::inst()->get(HTTPRequest::class);
        $id = $request->param('ID');

        if ($id) {
            $page = SiteTree::get()->byID($id);
            if ($page && $this->isEnabled($page)) {
                return Injector::inst()->create(CMSPageHistoryViewerController::class);
            }
        }

        // Injector is not used to prevent an infinite loop
        return new CMSPageHistoryController();
    }

    /**
     * Only activate for pages that have a history viewer capability applied. Modules can provide their
     * own two cents about this criteria.
     *
     * @param SiteTree $record
     * @return bool
     */
    public function isEnabled(SiteTree $record)
    {
        $enabledClasses = CMSPageHistoryViewerController::config()->enabled_pagetypes;
        foreach ($enabledClasses as $class) {
            if ($record instanceof $class) {
                return true;
            }
        }

        return false;
    }

}


1			<?php
2			/**
3			*
4			*/
5
6			namespace SilverStripe\VersionedAdmin\Factories;
7
8			use SilverStripe\CMS\Controllers\CMSPageHistoryController;
9			use SilverStripe\CMS\Model\SiteTree;
10			use SilverStripe\Control\HTTPRequest;
11			use SilverStripe\Core\Extensible;
12			use SilverStripe\Core\Injector\Factory;
13			use SilverStripe\Core\Injector\Injector;
14			use SilverStripe\VersionedAdmin\Controllers\CMSPageHistoryViewerController;
15
16			class HistoryControllerFactory implements Factory
17			{
18			use Extensible;
19
20			public function create($service, array $params = array())
21			{
22			$request = Injector::inst()->get(HTTPRequest::class);
23			$id = $request->param('ID');
24
25			if ($id) {
26			$page = SiteTree::get()->byID($id);
27			if ($page && $this->isEnabled($page)) {
28			return Injector::inst()->create(CMSPageHistoryViewerController::class);
29			}
30			}
31
32			// Injector is not used to prevent an infinite loop
33			return new CMSPageHistoryController();
34			}
35
36			/**
37			* Only activate for pages that have a history viewer capability applied. Modules can provide their
38			* own two cents about this criteria.
39			*
40			* @param SiteTree $record
41			* @return bool
42			*/
43			public function isEnabled(SiteTree $record)
44			{
45			$enabledClasses = CMSPageHistoryViewerController::config()->enabled_pagetypes;
46			foreach ($enabledClasses as $class) {
47			if ($record instanceof $class) {
48			return true;
49			}
50			}
51
52			return false;
53			}
54
55			}
56

silverstripe / silverstripe-versioned-admin

Pull Request — master (#18)

HistoryControllerFactory::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like