SilverStripe\VersionedAdmin\Extensions\FileArchiveExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getArchiveFieldClass()	0	3	1
A	getArchiveField()	0	23	3
A	isArchiveFieldEnabled()	0	3	1

<?php

namespace SilverStripe\VersionedAdmin\Extensions;

use SilverStripe\Assets\AssetControlExtension;
use SilverStripe\Assets\File;
use SilverStripe\Core\Config\Config;
use SilverStripe\Forms\GridField\GridFieldDataColumns;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Security\Member;
use SilverStripe\VersionedAdmin\ArchiveAdmin;
use SilverStripe\VersionedAdmin\ArchiveViewProvider;

/**
 * Adds a archive view for Files
 */
class FileArchiveExtension extends DataExtension implements ArchiveViewProvider
{
    /**
     * @inheritDoc
    */
    public function getArchiveFieldClass()
    {
        return File::class;

The expression return SilverStripe\Assets\File::class returns the type string which is incompatible with the return type mandated by SilverStripe\VersionedAdmin\ArchiveViewProvider::getArchiveFieldClass() of array.

    }

    /**
     * @inheritDoc
    */
    public function getArchiveField()
    {
        $listField = ArchiveAdmin::createArchiveGridField('Files', File::class);

        $listColumns = $listField->getConfig()->getComponentByType(GridFieldDataColumns::class);
        $listColumns->setDisplayFields([

The method setDisplayFields() does not exist on SilverStripe\Forms\GridField\GridFieldComponent. It seems like you code against a sub-type of SilverStripe\Forms\GridField\GridFieldComponent such as SilverStripe\Forms\GridField\GridFieldPrintButton or SilverStripe\Forms\GridField\GridFieldPrintButton or SilverStripe\Forms\GridField\GridFieldDataColumns or SilverStripe\Forms\GridField\GridFieldPrintButton or SilverStripe\Forms\Tests\GridField\GridField_URLHandlerTest\TestComponent or SilverStripe\Forms\GridField\GridFieldDetailForm.

            'Name' => File::singleton()->fieldLabel('Name'),
            'appCategory' => _t(ArchiveAdmin::class . '.COLUMN_TYPE', 'Type'),
            'LastEdited.Ago' => _t(ArchiveAdmin::class . '.COLUMN_DATEARCHIVED', 'Date Archived'),
            'Parent.Name' => _t(ArchiveAdmin::class . '.COLUMN_ORIGIN', 'Origin'),
            'AuthorID' => _t(ArchiveAdmin::class . '.COLUMN_ARCHIVEDBY', 'Archived By'),
        ]);
        $listColumns->setFieldFormatting([

The method setFieldFormatting() does not exist on SilverStripe\Forms\GridField\GridFieldComponent. It seems like you code against a sub-type of SilverStripe\Forms\GridField\GridFieldComponent such as SilverStripe\Forms\GridField\GridFieldPrintButton or SilverStripe\Forms\GridField\GridFieldPrintButton or SilverStripe\Forms\GridField\GridFieldDataColumns or SilverStripe\Forms\GridField\GridFieldPrintButton or SilverStripe\Forms\Tests\GridField\GridField_URLHandlerTest\TestComponent or SilverStripe\Forms\GridField\GridFieldDetailForm.

            'appCategory' => function ($val, $item) {
                return ucfirst($val ?: $item->i18n_singular_name());
            },
            'AuthorID' => function ($val, $item) {

The parameter $item is not used and could be removed.

                $member = Member::get_by_id($val);
                return $member ? $member->Name : null;

$member is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            },
        ]);

        return $listField;
    }

    /**
     * The files archive is only useful if archived assets are stored
     * so this checks if this option is enabled
     *
     * @return boolean
    */
    public function isArchiveFieldEnabled()
    {
        return Config::inst()->get(AssetControlExtension::class, 'keep_archived_assets');
    }
}