HistoryViewerControllerTest::testGetVersionFormThrowsExceptionWhenArgsAreMissing() - Code Metrics - silverstripe/silverstripe-versioned-admin - Measure and Improve Code Quality continuously with Scrutinizer

testGetVersionFormThrowsExceptionWhenArgsAreMissing() A
last analyzed 2020-03-31 11:10 UTC

↳ Parent: HistoryViewerControllerTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	6
Code Lines	4
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	1
eloc	4
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	6
rs	10
<?php

namespace SilverStripe\VersionedAdmin\Tests\Controllers;

use InvalidArgumentException;
use SilverStripe\Admin\LeftAndMainFormRequestHandler;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\Form;
use SilverStripe\VersionedAdmin\Controllers\HistoryViewerController;
use SilverStripe\VersionedAdmin\Tests\Controllers\HistoryViewerControllerTest\UnviewableVersionedObject;
use SilverStripe\VersionedAdmin\Tests\Controllers\HistoryViewerControllerTest\ViewableVersionedObject;

class HistoryViewerControllerTest extends SapphireTest
{
    protected static $fixture_file = 'HistoryViewerControllerTest.yml';

    protected static $extra_dataobjects = [
        ViewableVersionedObject::class,
        UnviewableVersionedObject::class,
    ];

    public function testGetClientConfig()
    {
        $controller = new HistoryViewerController();

        $clientConfig = $controller->getClientConfig();

        $this->assertArrayHasKey('versionForm', $clientConfig['form']);
        $this->assertArrayHasKey('compareForm', $clientConfig['form']);
        $this->assertArrayHasKey('schemaUrl', $clientConfig['form']['versionForm']);
    }

    public function testSchema()
    {
        $controllerMock = $this->getMockBuilder(HistoryViewerController::class)
        $controllerMock = /** @scrutinizer ignore-deprecated */ $this->getMockBuilder(HistoryViewerController::class)
            ->setMethods(['getVersionForm', 'getCompareForm', 'getSchemaResponse'])
            ->getMock();

        $controllerMock->expects($this->once())->method('getVersionForm')->with([
            'RecordClass' => 'Page',
            'RecordID' => 123,
            'RecordVersion' => 234,
            'RecordDate' => null
        ]);

        $controllerMock->expects($this->once())->method('getCompareForm')->with([
            'RecordClass' => 'Page',
            'RecordID' => 123,
            'RecordVersionFrom' => 234,
            'RecordVersionTo' => 236,
        ]);

        $controllerMock->expects($this->exactly(2))->method('getSchemaResponse')->willReturn(true);

        $request = $this->getMockBuilder(HTTPRequest::class)
        $request = /** @scrutinizer ignore-deprecated */ $this->getMockBuilder(HTTPRequest::class)
            ->setConstructorArgs(['GET', '/'])
            ->setMethods(['param'])
            ->getMock();
        $request->expects($this->once())->method('param')->with('FormName')->willReturn('versionForm');
        $request->offsetSet('RecordClass', 'Page');
        $request->offsetSet('RecordID', 123);
        $request->offsetSet('RecordVersion', 234);

        $controllerMock->schema($request);
        /** @var HTTPResponse $result */
        $result = $controllerMock->getResponse();
        $this->assertSame('application/json', $result->getHeader('Content-Type'));

        $request = $this->getMockBuilder(HTTPRequest::class)
        $request = /** @scrutinizer ignore-deprecated */ $this->getMockBuilder(HTTPRequest::class)
            ->setConstructorArgs(['GET', '/'])
            ->setMethods(['param'])
            ->getMock();
        $request->expects($this->once())->method('param')->with('FormName')->willReturn('compareForm');
        $request->offsetSet('RecordClass', 'Page');
        $request->offsetSet('RecordID', 123);
        $request->offsetSet('RecordVersion', 234);
        $request->offsetSet('RecordVersionFrom', 234);
        $request->offsetSet('RecordVersionTo', 236);

        $controllerMock->schema($request);
        /** @var HTTPResponse $result */
        $result = $controllerMock->getResponse();
        $this->assertSame('application/json', $result->getHeader('Content-Type'));
    }

    public function testGetVersionFormThrowsExceptionWhenArgsAreMissing()
    {
        $this->expectException(InvalidArgumentException::class);
        $this->expectExceptionMessageMatches('/Missing required field/');
        $controller = new HistoryViewerController();
        $controller->getVersionForm([]);
    }

    public function testGetVersionFormThrowsExceptionWhenArgsAreFalsy()
    {
        $this->expectException(InvalidArgumentException::class);
        $this->expectExceptionMessageMatches('/Missing required field/');
        $controller = new HistoryViewerController();
        $controller->getVersionForm([
            'RecordClass' => 'Page',
            'RecordID' => 0,
            'RecordVersion' => 0,
        ]);
    }

    public function testGetVersionFormThrowsExceptionWhenRecordVersionDoesntExist()
    {
        $this->expectException(\SilverStripe\Control\HTTPResponse_Exception::class);
        $this->expectExceptionCode('404');
        $controller = new HistoryViewerController();
        $controller->getVersionForm([
            'RecordClass' => UnviewableVersionedObject::class,
            'RecordID' => 99999, // doesn't exist
            'RecordVersion' => 1,
        ]);
    }

    public function testGetVersionFormThrowsExceptionWhenCanViewIsFalse()
    {
        $this->expectException(\SilverStripe\Control\HTTPResponse_Exception::class);
        $this->expectExceptionCode('403');
        $this->expectExceptionMessage('You don\'t have the necessary permissions to view Unviewable Versioned Object');
        $controller = new HistoryViewerController();
        $controller->getVersionForm([
            'RecordClass' => UnviewableVersionedObject::class,
            'RecordID' => $this->idFromFixture(UnviewableVersionedObject::class, 'record_one'),
            'RecordVersion' => 1,
        ]);
    }

    public function testGetVersionFormReturnsForm()
    {
        $controller = new HistoryViewerController();
        $result = $controller->getVersionForm([
            'RecordClass' => UnviewableVersionedObject::class,
            'RecordID' => $this->idFromFixture(ViewableVersionedObject::class, 'record_one'),
            'RecordVersion' => 1,
        ]);

        $this->assertInstanceOf(Form::class, $result);
        $this->assertInstanceOf(LeftAndMainFormRequestHandler::class, $result->getRequestHandler());
    }

    public function testVersionFormThrowsExceptionWithoutRequest()
    {
        $this->expectException(\SilverStripe\Control\HTTPResponse_Exception::class);
        $this->expectExceptionCode('400');
        $controller = new HistoryViewerController();
        $controller->versionForm(null);
    }

    public function testCompareFormThrowsExceptionWithoutRequest()
    {
        $this->expectException(\SilverStripe\Control\HTTPResponse_Exception::class);
        $this->expectExceptionCode('400');
        $controller = new HistoryViewerController();
        $controller->compareForm(null);
    }

    public function testVersionFormThrowsExceptionWhenArgsAreFalsy()
    {
        $this->expectException(InvalidArgumentException::class);
        $this->expectExceptionMessageMatches('/Missing required field/');
        $controller = new HistoryViewerController();
        $controller->getVersionForm([
            'RecordClass' => 'Page',
            'RecordID' => 0,
            'RecordVersion' => 0,
        ]);
    }

    public function testVersionFormReturnsVersionForm()
    {
        $controllerMock = $this->getMockBuilder(HistoryViewerController::class)
        $controllerMock = /** @scrutinizer ignore-deprecated */ $this->getMockBuilder(HistoryViewerController::class)
            ->setMethods(['getVersionForm'])
            ->getMock();

        $mockData = [
            'RecordClass' => 'Page',
            'RecordID' => 123,
            'RecordVersion' => 234,
        ];

        $controllerMock->expects($this->once())->method('getVersionForm')
            ->with($mockData)
            ->willReturn('mocked');

        $result = $controllerMock->versionForm(new HTTPRequest('GET', '/', $mockData));

        $this->assertSame('mocked', $result);
    }
}

silverstripe / silverstripe-versioned-admin

testGetVersionFormThrowsExceptionWhenArgsAreMissing() A last analyzed 2020-03-31 11:10 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

testGetVersionFormThrowsExceptionWhenArgsAreMissing() A
last analyzed 2020-03-31 11:10 UTC
