Completed
Pull Request — master (#677)
by Will
01:48
created
code/Model/EditableFormField/EditableMemberListField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
     private static $table_name = 'EditableMemberListField';
26 26
 
27 27
     /**
28
-     * @return FieldList
28
+     * @return \SilverStripe\Forms\FieldList
29 29
      */
30 30
     public function getCMSFields()
31 31
     {
Please login to merge, or discard this patch.
code/Model/EditableFormField/EditableOption.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\UserForms\Model\EditableFormField;
4 4
 
5
-use SilverStripe\CMS\Controllers\CMSMain;
6
-use SilverStripe\Control\Controller;
7 5
 use SilverStripe\Core\Convert;
8 6
 use SilverStripe\ORM\DataObject;
9 7
 use SilverStripe\UserForms\Model\EditableFormField\EditableMultipleOptionField;
Please login to merge, or discard this patch.
code/Model/EditableFormField/EditableRadioField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
     private static $table_name = 'EditableRadioField';
23 23
 
24 24
     /**
25
-     * @return FieldList
25
+     * @return \SilverStripe\Forms\FieldList
26 26
      */
27 27
     public function getCMSFields()
28 28
     {
Please login to merge, or discard this patch.
code/Model/EditableFormField/EditableTextField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
     }
103 103
 
104 104
     /**
105
-     * @return FieldList
105
+     * @return \SilverStripe\Forms\FieldList
106 106
      */
107 107
     public function getFieldValidationOptions()
108 108
     {
Please login to merge, or discard this patch.
code/Model/Recipient/EmailRecipient.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -540,7 +540,7 @@
 block discarded – undo
540 540
     /**
541 541
      * Validate that valid email addresses are being used
542 542
      *
543
-     * @return ValidationResult
543
+     * @return \SilverStripe\ORM\ValidationResult
544 544
      */
545 545
     public function validate()
546 546
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@  discard block
 block discarded – undo
21 21
 use SilverStripe\Forms\GridField\GridFieldToolbarHeader;
22 22
 use SilverStripe\Forms\HTMLEditor\HTMLEditorField;
23 23
 use SilverStripe\Forms\LiteralField;
24
-use SilverStripe\Forms\TabSet;
25 24
 use SilverStripe\Forms\TextareaField;
26 25
 use SilverStripe\Forms\TextField;
27 26
 use SilverStripe\ORM\ArrayList;
@@ -34,7 +33,6 @@  discard block
 block discarded – undo
34 33
 use SilverStripe\UserForms\Model\EditableFormField\EditableTextField;
35 34
 use SilverStripe\UserForms\Model\Recipient\EmailRecipientCondition;
36 35
 use SilverStripe\UserForms\Model\UserDefinedForm;
37
-use SilverStripe\UserForms\UserForm;
38 36
 use SilverStripe\View\Requirements;
39 37
 use Symbiote\GridFieldExtensions\GridFieldAddNewInlineButton;
40 38
 use Symbiote\GridFieldExtensions\GridFieldEditableColumns;
Please login to merge, or discard this patch.
tests/Model/EditableFormFieldTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use SilverStripe\Dev\FunctionalTest;
7 7
 use SilverStripe\Forms\DropdownField;
8 8
 use SilverStripe\Forms\OptionsetField;
9
-use SilverStripe\UserForms\Model\EditableFormField;
10 9
 use SilverStripe\UserForms\Model\EditableFormField\EditableCheckbox;
11 10
 use SilverStripe\UserForms\Model\EditableFormField\EditableDropdown;
12 11
 use SilverStripe\UserForms\Model\EditableFormField\EditableFileField;
Please login to merge, or discard this patch.
code/Model/Submission/SubmittedForm.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
     }
111 111
 
112 112
     /**
113
-     * @return FieldList
113
+     * @return \SilverStripe\Forms\FieldList
114 114
      */
115 115
     public function getCMSFields()
116 116
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 use SilverStripe\ORM\DataObject;
12 12
 use SilverStripe\ORM\DB;
13 13
 use SilverStripe\Security\Member;
14
-use SilverStripe\UserForms\Model\UserDefinedForm;
15 14
 use SilverStripe\UserForms\Model\Submission\SubmittedFormField;
16 15
 
17 16
 class SubmittedForm extends DataObject
Please login to merge, or discard this patch.
code/Model/EditableFormField/EditableMultipleOptionField.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 use SilverStripe\Forms\Tab;
13 13
 use SilverStripe\ORM\Map;
14 14
 use SilverStripe\UserForms\Model\EditableFormField;
15
-use SilverStripe\Versioned\Versioned;
16 15
 use Symbiote\GridFieldExtensions\GridFieldAddNewInlineButton;
17 16
 use Symbiote\GridFieldExtensions\GridFieldEditableColumns;
18 17
 use Symbiote\GridFieldExtensions\GridFieldOrderableRows;
Please login to merge, or discard this patch.
tests/Control/UserDefinedFormControllerTest.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -259,6 +259,10 @@
 block discarded – undo
259 259
         return $form;
260 260
     }
261 261
 
262
+    /**
263
+     * @param CSSContentParser $parser
264
+     * @param UserDefinedForm|null $form
265
+     */
262 266
     public function checkTemplateIsCorrect($parser, $form)
263 267
     {
264 268
         $this->assertArrayHasKey(0, $parser->getBySelector('form#UserForm_Form_' . $form->ID));
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use SilverStripe\Core\Config\Config;
6 6
 use SilverStripe\Dev\CSSContentParser;
7 7
 use SilverStripe\Dev\FunctionalTest;
8
-use SilverStripe\Dev\TestOnly;
9 8
 use SilverStripe\Forms\FieldList;
10 9
 use SilverStripe\Forms\FormAction;
11 10
 use SilverStripe\ORM\DataObject;
Please login to merge, or discard this patch.