Completed
Pull Request — master (#454)
by Michael
33:16
created

EditableFormFieldTest::testEditableRadioField()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 10
Code Lines 6

Duplication

Lines 10
Ratio 100 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 10
loc 10
rs 9.4285
cc 1
eloc 6
nc 1
nop 0
1
<?php
2
3
/**
4
 * @package userforms
5
 */
6
7
class EditableFormFieldTest extends FunctionalTest {
0 ignored issues
show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
8
9
	static $fixture_file = 'userforms/tests/EditableFormFieldTest.yml';
0 ignored issues
show
Coding Style introduced by
The visibility should be declared for property $fixture_file.

The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using

class A {
    var $property;
}

the property is implicitly global.

To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.

Loading history...
10
11
	function testFormFieldPermissions() {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
12
		$text = $this->objFromFixture('EditableTextField', 'basic-text');
13
14
		$this->logInWithPermission('ADMIN');
15
		$this->assertTrue($text->canCreate());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
16
		$this->assertTrue($text->canView());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
17
		$this->assertTrue($text->canEdit());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
18
		$this->assertTrue($text->canDelete());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
19
20
		$text->setReadonly(true);
21
		$this->assertTrue($text->canView());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
22
		$this->assertFalse($text->canEdit());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
23
		$this->assertFalse($text->canDelete());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
24
25
		$text->setReadonly(false);
26
		$this->assertTrue($text->canView());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
27
		$this->assertTrue($text->canEdit());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
28
		$this->assertTrue($text->canDelete());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
29
30
		$member = Member::currentUser();
31
		$member->logout();
32
33
		$this->logInWithPermission('SITETREE_VIEW_ALL');
34
		$this->assertFalse($text->canCreate());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
35
36
		$text->setReadonly(false);
37
		$this->assertTrue($text->canView());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
38
		$this->assertFalse($text->canEdit());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
39
		$this->assertFalse($text->canDelete());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
40
41
		$text->setReadonly(true);
42
		$this->assertTrue($text->canView());
0 ignored issues
show
Bug introduced by
The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
43
		$this->assertFalse($text->canEdit());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
44
		$this->assertFalse($text->canDelete());
0 ignored issues
show
Bug introduced by
The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
45
	}
46
47
	function testCustomRules() {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
48
		$this->logInWithPermission('ADMIN');
49
		$form = $this->objFromFixture('UserDefinedForm', 'custom-rules-form');
50
51
		$checkbox = $form->Fields()->find('ClassName', 'EditableCheckbox');
0 ignored issues
show
Bug introduced by
The method Fields() does not exist on DataObject. Did you maybe mean beforeUpdateCMSFields()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
52
		$field = $form->Fields()->find('ClassName', 'EditableTextField');
0 ignored issues
show
Bug introduced by
The method Fields() does not exist on DataObject. Did you maybe mean beforeUpdateCMSFields()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
53
54
		$rules = $checkbox->DisplayRules();
55
56
		// form has 2 fields - a checkbox and a text field
57
		// it has 1 rule - when ticked the checkbox hides the text field
58
		$this->assertEquals(1, $rules->Count());
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
59
		$this->assertEquals($rules, $checkbox->EffectiveDisplayRules());
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
60
61
		$checkboxRule = $rules->First();
62
		$checkboxRule->ConditionFieldID = $field->ID;
63
64
		$this->assertEquals($checkboxRule->Display, 'Hide');
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
65
		$this->assertEquals($checkboxRule->ConditionOption, 'HasValue');
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
66
		$this->assertEquals($checkboxRule->FieldValue, '6');
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
67
68
		// If field is required then all custom rules are disabled
69
		$checkbox->Required = true;
70
		$this->assertEquals(0, $checkbox->EffectiveDisplayRules()->count());
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
71
	}
72
73
    /**
74
     * @covers EditableOption::getValue
75
     */
76
    public function testEditableOptionEmptyValue() {
77
         $option = $this->objFromFixture('EditableOption', 'option-1');
78
         $option->Value = '';
79
80
         // Disallow empty values
81
         EditableOption::set_allow_empty_values(false);
82
         $this->assertEquals($option->Title, $option->Value);
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
83
84
         $option->Value = 'test';
85
         $this->assertEquals('test', $option->Value);
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
86
87
         // Allow empty values
88
         EditableOption::set_allow_empty_values(true);
89
         $option->Value = '';
90
         $this->assertEquals('', $option->Value);
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
91
    }
92
93 View Code Duplication
	function testEditableDropdownField() {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
94
		$dropdown = $this->objFromFixture('EditableDropdown', 'basic-dropdown');
95
96
		$field = $dropdown->getFormField();
97
98
99
		$this->assertThat($field, $this->isInstanceOf('DropdownField'));
0 ignored issues
show
Bug introduced by
The method isInstanceOf() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
Bug introduced by
The method assertThat() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
100
		$values = $field->getSource();
101
102
		$this->assertEquals(array('Option 1' => 'Option 1', 'Option 2' => 'Option 2'), $values);
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
103
	}
104
105 View Code Duplication
	function testEditableRadioField() {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
106
		$radio = $this->objFromFixture('EditableRadioField', 'radio-field');
107
108
		$field = $radio->getFormField();
109
110
		$this->assertThat($field, $this->isInstanceOf('OptionsetField'));
0 ignored issues
show
Bug introduced by
The method isInstanceOf() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
Bug introduced by
The method assertThat() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
111
		$values = $field->getSource();
112
113
		$this->assertEquals(array('Option 5' => 'Option 5', 'Option 6' => 'Option 6'), $values);
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
114
	}
115
116
	function testMultipleOptionDuplication() {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
117
		$dropdown = $this->objFromFixture('EditableDropdown','basic-dropdown');
118
119
		$clone = $dropdown->duplicate();
120
121
		$this->assertEquals($clone->Options()->Count(), $dropdown->Options()->Count());
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
122
123
		foreach($clone->Options() as $option) {
124
			$orginal = $dropdown->Options()->find('Title', $option->Title);
125
126
			$this->assertEquals($orginal->Sort, $option->Sort);
0 ignored issues
show
Bug introduced by
The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
127
		}
128
	}
129
130
	public function testFileField() {
131
		$fileField = $this->objFromFixture('EditableFileField', 'file-field');
132
		$formField = $fileField->getFormField();
133
134
		$this->assertContains('jpg', $formField->getValidator()->getAllowedExtensions());
135
		$this->assertNotContains('notallowedextension', $formField->getValidator()->getAllowedExtensions());
136
	}
137
138
	public function testFileFieldAllowedExtensionsBlacklist() {
139
		Config::inst()->update('EditableFileField', 'allowed_extensions_blacklist', array('jpg'));
140
		$fileField = $this->objFromFixture('EditableFileField', 'file-field');
141
		$formField = $fileField->getFormField();
142
143
		$this->assertNotContains('jpg', $formField->getValidator()->getAllowedExtensions());
144
	}
145
146
	/**
147
	 * Verify that unique names are automatically generated for each formfield
148
	 */
149
	public function testUniqueName() {
150
		$textfield1 = new EditableTextField();
151
		$this->assertEmpty($textfield1->Name);
0 ignored issues
show
Bug introduced by
The method assertEmpty() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
152
153
		// Write values
154
		$textfield1->write();
155
		$textfield2 = new EditableTextField();
156
		$textfield2->write();
157
		$checkboxField = new EditableCheckbox();
158
		$checkboxField->write();
159
160
		// Test values are in the expected format
161
		$this->assertRegExp('/^EditableTextField_.+/', $textfield1->Name);
0 ignored issues
show
Bug introduced by
The method assertRegExp() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
162
		$this->assertRegExp('/^EditableTextField_.+/', $textfield2->Name);
0 ignored issues
show
Bug introduced by
The method assertRegExp() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
163
		$this->assertRegExp('/^EditableCheckbox_.+/', $checkboxField->Name);
0 ignored issues
show
Bug introduced by
The method assertRegExp() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
164
		$this->assertNotEquals($textfield1->Name, $textfield2->Name);
0 ignored issues
show
Bug introduced by
The method assertNotEquals() does not seem to exist on object<EditableFormFieldTest>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
165
	}
166
167
}
168