EditableOption

Complexity

Total Complexity

19

Size/Duplication

Total Lines	163
Duplicated Lines	14.11 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	6
Bugs	0	Features	2

12 Methods

Rating	Name	Duplication	Size	Complexity
A	allow_empty_values()	0	4	1
A	set_allow_empty_values()	0	4	1
A	canEdit()	0	4	1
A	canDelete()	0	4	1
A	getEscapedTitle()	0	4	1
A	canView()	0	4	1
A	canCreate()	10	11	2
A	getCanCreateContext()	13	14	4
A	canPublish()	0	4	1
A	canUnpublish()	0	4	1
A	getValue()	0	8	3
A	onBeforeWrite()	0	7	2

<?php

/**
 * Base Class for EditableOption Fields such as the ones used in
 * dropdown fields and in radio check box groups
 *
 * @method EditableMultipleOptionField Parent()
 * @package userforms
 */
class EditableOption extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

	private static $default_sort = "Sort";

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

	private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

		"Name" => "Varchar(255)",
		"Title" => "Varchar(255)",
		"Default" => "Boolean",
        "Sort" => "Int",
        "Value" => "Varchar(255)",
	);

	private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

		"Parent" => "EditableMultipleOptionField",
	);

	private static $extensions = array(

Consider using a different property name as you override a private property of the parent class.

The property $extensions is not used and could be removed.

		"Versioned('Stage', 'Live')"
	);

	private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

		'Title',
		'Default'
	);

    protected static $allow_empty_values = false;

	/**
     * Returns whether to allow empty values or not.
     *
     * @return boolean
     */
    public static function allow_empty_values()
    {
        return (bool) self::$allow_empty_values;
    }

    /**
     * Set whether to allow empty values.
     *
     * @param boolean $allow
     */
    public static function set_allow_empty_values($allow)
    {
        self::$allow_empty_values = (bool) $allow;
    }

    /**
	 * @param Member $member
	 *
	 * @return boolean
	 */
    public function canEdit($member = null)
    {
		return $this->Parent()->canEdit($member);
	}

	/**
	 * @param Member $member
	 *
	 * @return boolean
	 */
    public function canDelete($member = null)
    {
		return $this->canEdit($member);
	}

    public function getEscapedTitle()
    {
		return Convert::raw2att($this->Title);

The property Title does not exist on object<EditableOption>. Since you implemented __get, maybe consider adding a @property annotation.

	}

    /**
     * @param Member $member
     * @return bool
     */
    public function canView($member = null)
    {
		return $this->Parent()->canView($member);
	}

	/**
	 * Return whether a user can create an object of this type
	 *
     * @param Member $member
     * @param array $context Virtual parameter to allow context to be passed in to check

There is no parameter named $context. Was it maybe removed?

	 * @return bool
	 */
    public function canCreate($member = null)

This method seems to be duplicated in your project.

    {
		// Check parent page
        $parent = $this->getCanCreateContext(func_get_args());
        if($parent) {
            return $parent->canEdit($member);
        }

        // Fall back to secure admin permissions
        return parent::canCreate($member);
	}

    /**
     * Helper method to check the parent for this object
     *
     * @param array $args List of arguments passed to canCreate
     * @return DataObject Some parent dataobject to inherit permissions from
     */
    protected function getCanCreateContext($args)

This method seems to be duplicated in your project.

    {
        // Inspect second parameter to canCreate for a 'Parent' context
        if(isset($args[1]['Parent'])) {
            return $args[1]['Parent'];
        }
        // Hack in currently edited page if context is missing
        if(Controller::has_curr() && Controller::curr() instanceof CMSMain) {
            return Controller::curr()->currentPage();
        }

        // No page being edited
        return null;
    }

    /**
     * @param Member $member
     * @return bool
     */
    public function canPublish($member = null)
    {
        return $this->canEdit($member);
    }

    /**
     * @param Member $member
     * @return bool
     */
    public function canUnpublish($member = null)
    {
        return $this->canDelete($member);
    }

    /**
     * Fetches a value for $this->Value. If empty values are not allowed,
     * then this will return the title in the case of an empty value.
     *
     * @return string
     */
    public function getValue()
    {
        $value = $this->getField('Value');
        if (empty($value) && !self::allow_empty_values()) {
            return $this->Title;

The property Title does not exist on object<EditableOption>. Since you implemented __get, maybe consider adding a @property annotation.

        }
        return $value;
    }

    protected function onBeforeWrite() {
        if (!$this->Sort) {

The property Sort does not exist on object<EditableOption>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->Sort = EditableOption::get()->max('Sort') + 1;

The property Sort does not exist on object<EditableOption>. Since you implemented __set, maybe consider adding a @property annotation.

        }

        parent::onBeforeWrite();
    }
}