UserFormsRequiredFields::php() - Code Metrics - Inspection of "WIP: Feature/conditional required fields" - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#770)

by Jess

created 2018-05-14 00:52 UTC

UserFormsRequiredFields::php() C

↳ Parent: UserFormsRequiredFields

Complexity

Conditions	11
Paths	33

Size

Total Lines	46
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	23
nc	33
nop	1
dl	0
loc	46
rs	5.2653
c	0
b	0
f	0

How to fix Complexity

<?php

namespace SilverStripe\UserForms\Form;

use SilverStripe\Dev\Debug;
use SilverStripe\Forms\RequiredFields;
use SilverStripe\ORM\ArrayLib;
use SilverStripe\UserForms\Model\EditableFormField;

/**
 * An extension of RequiredFields which handles conditionally required fields.
 *
 * A conditionally required is a field that is required, but can be hidden by display rules.
 * When it is visible, (according to the submitted form data) it will be validated as required.
 * When it is hidden, it will skip required validation.
 *
 * Required fields will nb validated as usual.
 * Conditionally required fields will be validated if the display rules are satisfied in the submitted dataset.
 */
class UserFormsRequiredFields extends RequiredFields
{
    /**
     * Allows validation of fields via specification of a php function for
     * validation which is executed after the form is submitted.
     *
     * @param array $data
     *
     * @return boolean
     */
    public function php($data)
    {
        $valid = true;
        $fields = $this->form->Fields();

        foreach ($fields as $field) {
            $valid = ($field->validate($this) && $valid);
        }

        if (!$this->required) {

            return $valid;
        }

        foreach ($this->required as $fieldName) {
            if (!$fieldName) {
                continue;
            }

            // get form field
            if ($fieldName instanceof FormField) {
filter:
    dependency_paths: ["lib/*"]
                $formField = $fieldName;
                $fieldName = $fieldName->getName();
            } else {
                $formField = $fields->dataFieldByName($fieldName);
            }

            // get editable form field - owns display rules for field
            $editableFormField = $this->getEditableFormFieldByName($fieldName);

            $error = false;

            // validate if there are no display rules or the field is conditionally visible
            if (!$this->hasDisplayRules($editableFormField) ||
                $this->conditionalFieldEnabled($editableFormField, $data)) {
                $error = $this->validateRequired($formField, $data);
            }

            // handle error case
            if ($formField && $error) {
                $this->handleError($formField, $fieldName);

                $valid = false;
            }
        }

        return $valid;
    }

    private function getEditableFormFieldByName($name)
    {
        return EditableFormField::get()->filter(['name' => $name])->first();
    }

    private function getEditableFormFieldByID($id)

    {
        return EditableFormField::get_by_id($id);
        return EditableFormField::/** @scrutinizer ignore-call */ get_by_id($id);
    }

    private function hasDisplayRules($field)
    {
        return ($field->DisplayRules()->count() > 0);
    }

    private function conditionalFieldEnabled($editableFormField, $data)
    {
        $displayRules = $editableFormField->DisplayRules();

        $conjunction = $editableFormField->DisplayRulesConjunctionNice();

        $displayed = ($editableFormField->ShowOnLoadNice() === 'show');

        // && start with true and find and condition that doesn't satisfy
        // || start with false and find and condition that satisfies
        $conditionsSatisfied = ($conjunction === '&&');

        foreach ($displayRules as $rule) {
            $controllingField = EditableFormField::get()->byID($rule->ConditionFieldID);
            $valid = false;


            if ($controllingField->DisplayRules()->count() > 0) { // controllingField is also a conditional field
                // recursively check - if any of the dependant fields are hidden, then this field cannot be visible.
                if ($this->conditionalFieldEnabled($controllingField, $data)) {
                    return false;
                };
            }

            $ruleSatisfied = $rule->validateAgainstFormData($data);

            if ($conjunction === '||' && $ruleSatisfied) {
                $conditionsSatisfied = true;
                break;
            }
            if ($conjunction === '&&' && !$ruleSatisfied) {
                $conditionsSatisfied = false;
                break;
            }
        }

        // initially displayed - condition fails || initially hidden, condition passes
        return ($displayed xor $conditionsSatisfied);
    }

    private function validateRequired($field, $data)
    {
        $error = false;
        $fieldName = $field->getName();
        // submitted data for file upload fields come back as an array
        $value = isset($data[$fieldName]) ? $data[$fieldName] : null;

        if (is_array($value)) {
            if ($formField instanceof FileField && isset($value['error']) && $value['error']) {
filter:
    dependency_paths: ["lib/*"]
                $error = true;
            } else {
                $error = (count($value)) ? false : true;
            }
        } else {
            // assume a string or integer
            $error = (strlen($value)) ? false : true;
        }

        return $error;
    }

    private function handleError($formField, $fieldName)
    {
        $errorMessage = _t(
            'SilverStripe\\Forms\\Form.FIELDISREQUIRED',
            '{name} is required',
            array(
                'name' => strip_tags(
                    '"' . ($formField->Title() ? $formField->Title() : $fieldName) . '"'
                )
            )
        );

        if ($msg = $formField->getCustomValidationMessage()) {
            $errorMessage = $msg;
        }

        $this->validationError(
            $fieldName,
            $errorMessage,
            "required"
        );
    }
}


silverstripe / silverstripe-userforms

Pull Request — master (#770)

UserFormsRequiredFields::php() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like