SubmittedForm

Complexity

Total Complexity

17

Size/Duplication

Total Lines	163
Duplicated Lines	17.18 %

Coupling/Cohesion

Components	2
Dependencies	9

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	relField()	0	17	3
A	canCreate()	7	8	2
A	canView()	7	8	2
A	canEdit()	7	8	2
A	canDelete()	7	8	2
B	getCMSFields()	0	43	3
A	onBeforeDelete()	0	10	3

<?php
/**
 * Contents of an UserDefinedForm submission
 *
 * @package userforms
 */

class SubmittedForm extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        "SubmittedBy" => "Member",
        "Parent" => "UserDefinedForm",
    );

    private static $has_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        "Values" => "SubmittedFormField"
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'ID',
        'Created'
    );

    /**
     * Returns the value of a relation or, in the case of this form, the value
     * of a given child {@link SubmittedFormField}
     *
     * @param string
     *
     * @return mixed
     */
    public function relField($fieldName)
    {
        // default case
        if ($value = parent::relField($fieldName)) {
            return $value;
        }

        // check values for a form field with the matching name.
        $formField = SubmittedFormField::get()->filter(array(
            'ParentID' => $this->ID,
            'Name' => $fieldName
        ))->first();

        if ($formField) {
            return $formField->getFormattedValue();
        }
    }

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $self = $this;

        $this->beforeUpdateCMSFields(function ($fields) use ($self) {
            $fields->removeByName('Values');

            //check to ensure there is a Member to extract an Email from else null value
            if($self->SubmittedBy() && $self->SubmittedBy()->exists()){

The method SubmittedBy does not exist on object<SubmittedForm>? Since you implemented __call, maybe consider adding a @method annotation.

                $submitter =  $self->SubmittedBy()->Email;

The method SubmittedBy does not exist on object<SubmittedForm>? Since you implemented __call, maybe consider adding a @method annotation.

            } else {
                $submitter = null;
            }

            //replace scaffolded field with readonly submitter
            $fields->replaceField(
                'SubmittedByID',
                ReadonlyField::create(
                    'Submitter',
                    'Submitter',
                    $submitter
                )
            );

            $values = new GridField(
                'Values',
                'SubmittedFormField',
                $self->Values()->sort('Created', 'ASC')

The method Values() does not exist on SubmittedForm. Did you maybe mean getXMLValues()?

            );

            $config = new GridFieldConfig();
            $config->addComponent(new GridFieldDataColumns());
            $config->addComponent(new GridFieldExportButton());
            $config->addComponent(new GridFieldPrintButton());
            $values->setConfig($config);

            $fields->addFieldToTab('Root.Main', $values);
        });

        $fields = parent::getCMSFields();

        return $fields;
    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canCreate($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        return $this->Parent()->canCreate();

The method Parent() does not exist on SubmittedForm. Did you maybe mean parentClass()?

    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canView($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        return $this->Parent()->canView();

The method Parent() does not exist on SubmittedForm. Did you maybe mean parentClass()?

    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canEdit($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        return $this->Parent()->canEdit();

The method Parent() does not exist on SubmittedForm. Did you maybe mean parentClass()?

    }

    /**
     * @param Member
     *
     * @return boolean
     */
    public function canDelete($member = null)

This method seems to be duplicated in your project.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        return $this->Parent()->canDelete();

The method Parent() does not exist on SubmittedForm. Did you maybe mean parentClass()?

    }

    /**
     * Before we delete this form make sure we delete all the
     * field values so that we don't leave old data round
     *
     * @return void
     */
    protected function onBeforeDelete()
    {
        if ($this->Values()) {

The method Values() does not exist on SubmittedForm. Did you maybe mean getXMLValues()?

            foreach ($this->Values() as $value) {

The method Values() does not exist on SubmittedForm. Did you maybe mean getXMLValues()?

                $value->delete();
            }
        }

        parent::onBeforeDelete();
    }
}