EditableFieldGroupEnd - Code Metrics - Inspection of "Use precise distro for PHP 5.3 support in Travis" - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c6b309...12981b )

by Robbie

created 2017-08-11 04:24 UTC

EditableFieldGroupEnd A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

34.09%

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	6
dl	0
loc	97
ccs	15
cts	44
cp	0.3409
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	getCMSTitle()	11	3
A	getCMSFields()	6	1
A	getInlineClassnameField()	4	1
A	getInlineTitleField()	4	1
A	getFormField()	4	1
A	showInReports()	4	1
B	onAfterWrite()	24	5
A	onAfterDelete()	9	3

<?php

/**
 * Specifies that this ends a group of fields
 */
class EditableFieldGroupEnd extends EditableFormField
namespace YourVendor;

class YourClass { }
{

    private static $belongs_to = array(

        'Group' => 'EditableFieldGroup'
    );

    /**
     * Disable selection of group class
     *
     * @config
     * @var bool
     */
    private static $hidden = true;


    /**
     * Non-data type
     *
     * @config
     * @var bool
     */
    private static $literal = true;


    public function getCMSTitle()
    {
        $group = $this->Group();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return _t(
            'EditableFieldGroupEnd.FIELD_GROUP_END',
            '{group} end',
            array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'group' => ($group && $group->exists()) ? $group->CMSTitle : 'Group'
            )
        );
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName(array('MergeField', 'Default', 'Validation', 'DisplayRules'));
        return $fields;
    }

    public function getInlineClassnameField($column, $fieldClasses)
    {
        return new LabelField($column, $this->CMSTitle);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getInlineTitleField($column)
    {
        return HiddenField::create($column);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getFormField()
    {
        return null;
    }

    public function showInReports()
    {
        return false;
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();

        // If this is not attached to a group, find the first group prior to this
        // with no end attached
        $group = $this->Group();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if (!($group && $group->exists()) && $this->ParentID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $group = EditableFieldGroup::get()
                ->filter(array(
                    'ParentID' => $this->ParentID,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Sort:LessThanOrEqual' => $this->Sort
                ))
                ->where('"EditableFieldGroup"."EndID" IS NULL OR "EditableFieldGroup"."EndID" = 0')
                ->sort('"Sort" DESC')
                ->first();

            // When a group is found, attach it to this end
            if ($group) {
                $group->EndID = $this->ID;
                $group->write();
            }
        }
    }

    protected function onAfterDelete()
    {
        parent::onAfterDelete();

        // Delete group
        if (($group = $this->Group()) && $group->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $group->delete();
        }
    }
}


1		<?php
2
3		/**
4		* Specifies that this ends a group of fields
5		*/
6		class EditableFieldGroupEnd extends EditableFormField
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8
9		private static $belongs_to = array(
		0 ignored issues – show Comprehensibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `$belongs_to` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10		'Group' => 'EditableFieldGroup'
11		);
12
13		/**
14		* Disable selection of group class
15		*
16		* @config
17		* @var bool
18		*/
19		private static $hidden = true;
		0 ignored issues – show Comprehensibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `$hidden` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20
21		/**
22		* Non-data type
23		*
24		* @config
25		* @var bool
26		*/
27		private static $literal = true;
		0 ignored issues – show Comprehensibility introduced 2017-08-11 04:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-11 04:49 UTC by Report Bug Copy Issue Report The property `$literal` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28
29		public function getCMSTitle()
30		{
31		$group = $this->Group();
		0 ignored issues – show Documentation Bug introduced 2017-08-11 04:49 UTC by Report Bug Copy Issue Report The method `Group` does not exist on `object<EditableFieldGroupEnd>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
32		return _t(
33		'EditableFieldGroupEnd.FIELD_GROUP_END',
34		'{group} end',
35		array(
		0 ignored issues – show Documentation introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report `array('group' => $group ...up->CMSTitle : 'Group')` is of type `array<string,?,{"group":"?"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36		'group' => ($group && $group->exists()) ? $group->CMSTitle : 'Group'
37		)
38		);
39		}
40
41		public function getCMSFields()
42		{
43		$fields = parent::getCMSFields();
44		$fields->removeByName(array('MergeField', 'Default', 'Validation', 'DisplayRules'));
45		return $fields;
46		}
47
48		public function getInlineClassnameField($column, $fieldClasses)
49		{
50		return new LabelField($column, $this->CMSTitle);
		0 ignored issues – show Documentation introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `CMSTitle` does not exist on `object<EditableFieldGroupEnd>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug Best Practice introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The return type of `return new \LabelField($column, $this->CMSTitle);` (`LabelField`) is incompatible with the return type of the parent method `EditableFormField::getInlineClassnameField` of type `DropdownField`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { / ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
51		}
52
53		public function getInlineTitleField($column)
54		{
55		return HiddenField::create($column);
		0 ignored issues – show Bug Best Practice introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The return type of `return \HiddenField::create($column);` (`HiddenField`) is incompatible with the return type of the parent method `EditableFormField::getInlineTitleField` of type `TextField`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
56		}
57
58		public function getFormField()
59		{
60		return null;
61		}
62
63		public function showInReports()
64		{
65		return false;
66		}
67
68	26	public function onAfterWrite()
69		{
70	26	parent::onAfterWrite();
71
72		// If this is not attached to a group, find the first group prior to this
73		// with no end attached
74	26	$group = $this->Group();
		0 ignored issues – show Documentation Bug introduced 2015-12-17 07:20 UTC by Report Bug Copy Issue Report The method `Group` does not exist on `object<EditableFieldGroupEnd>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
75	26	if (!($group && $group->exists()) && $this->ParentID) {
		0 ignored issues – show Documentation introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<EditableFieldGroupEnd>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76	1	$group = EditableFieldGroup::get()
77	1	->filter(array(
78	1	'ParentID' => $this->ParentID,
		0 ignored issues – show Documentation introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<EditableFieldGroupEnd>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
79	1	'Sort:LessThanOrEqual' => $this->Sort
80	1	))
81	1	->where('"EditableFieldGroup"."EndID" IS NULL OR "EditableFieldGroup"."EndID" = 0')
82	1	->sort('"Sort" DESC')
83	1	->first();
84
85		// When a group is found, attach it to this end
86	1	if ($group) {
87		$group->EndID = $this->ID;
88		$group->write();
89		}
90	1	}
91	26	}
92
93		protected function onAfterDelete()
94		{
95		parent::onAfterDelete();
96
97		// Delete group
98		if (($group = $this->Group()) && $group->exists()) {
		0 ignored issues – show Documentation Bug introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The method `Group` does not exist on `object<EditableFieldGroupEnd>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
99		$group->delete();
100		}
101		}
102		}
103

silverstripe / silverstripe-userforms

Push — master ( c6b309...12981b )

EditableFieldGroupEnd A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like