UserFormFieldEditorExtension

Complexity

Total Complexity

29

Size/Duplication

Total Lines	256
Duplicated Lines	2.34 %

Coupling/Cohesion

Components	1
Dependencies	20

Test Coverage

Coverage

83.62%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	9	1
A	onAfterWrite()	0	4	1
A	getFieldEditorGrid()	0	50	3
B	createInitialFormStep()	0	34	6
B	onAfterPublish()	0	30	4
A	onAfterUnpublish()	0	6	2
B	onAfterDuplicate()	6	34	6
A	getIsModifiedOnStage()	0	13	4
A	onAfterRevertToLive()	0	7	2

<?php

/**
 * @package userforms
 */
class UserFormFieldEditorExtension extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @var array
     */
    private static $has_many = array(

The property $has_many is not used and could be removed.

        'Fields' => 'EditableFormField'
    );

    /**
     * Adds the field editor to the page.
     *
     * @return FieldList
     */
    public function updateCMSFields(FieldList $fields)
    {
        $fieldEditor = $this->getFieldEditorGrid();

        $fields->insertAfter(new Tab('FormFields', _t('UserFormFieldEditorExtension.FORMFIELDS', 'Form Fields')), 'Main');

'Main' is of type string, but the function expects a object<FormField>.

        $fields->addFieldToTab('Root.FormFields', $fieldEditor);

        return $fields;
    }

    /**
     * Gets the field editor, for adding and removing EditableFormFields.
     *
     * @return GridField
     */
    public function getFieldEditorGrid()
    {
        Requirements::javascript(USERFORMS_DIR . '/javascript/FieldEditor.js');

        $fields = $this->owner->Fields();

        $this->createInitialFormStep(true);

        $editableColumns = new GridFieldEditableColumns();
        $fieldClasses = singleton('EditableFormField')->getEditableFieldClasses();
        $editableColumns->setDisplayFields(array(
            'ClassName' => function ($record, $column, $grid) use ($fieldClasses) {

The parameter $grid is not used and could be removed.

                if ($record instanceof EditableFormField) {
                    return $record->getInlineClassnameField($column, $fieldClasses);
                }
            },
            'Title' => function ($record, $column, $grid) {

The parameter $grid is not used and could be removed.

                if ($record instanceof EditableFormField) {
                    return $record->getInlineTitleField($column);
                }
            }
        ));

        $config = GridFieldConfig::create()
            ->addComponents(
                $editableColumns,
                new GridFieldButtonRow(),
                GridFieldAddClassesButton::create('EditableTextField')
                    ->setButtonName(_t('UserFormFieldEditorExtension.ADD_FIELD', 'Add Field'))
                    ->setButtonClass('ss-ui-action-constructive'),
                GridFieldAddClassesButton::create('EditableFormStep')
                    ->setButtonName(_t('UserFormFieldEditorExtension.ADD_PAGE_BREAK', 'Add Page Break')),
                GridFieldAddClassesButton::create(array('EditableFieldGroup', 'EditableFieldGroupEnd'))
                    ->setButtonName(_t('UserFormFieldEditorExtension.ADD_FIELD_GROUP', 'Add Field Group')),
                new GridFieldEditButton(),
                new GridFieldDeleteAction(),
                new GridFieldToolbarHeader(),
                new GridFieldOrderableRows('Sort'),
                new GridFieldDetailForm()
            );

        $fieldEditor = GridField::create(
            'Fields',
            _t('UserDefinedForm.FIELDS', 'Fields'),
            $fields,
            $config
        )->addExtraClass('uf-field-editor');

        return $fieldEditor;
    }

    /**
     * A UserForm must have at least one step.
     * If no steps exist, create an initial step, and put all fields inside it.
     *
     * @param bool $force
     * @return void
     */
    public function createInitialFormStep($force = false)
    {
        // Only invoke once saved
        if (!$this->owner->exists()) {
            return;
        }

        // Check if first field is a step
        $fields = $this->owner->Fields();
        $firstField = $fields->first();
        if ($firstField instanceof EditableFormStep) {
            return;
        }

        // Don't create steps on write if there are no formfields, as this
        // can create duplicate first steps during publish of new records
        if (!$force && !$firstField) {
            return;
        }

        // Re-apply sort to each field starting at 2
        $next = 2;
        foreach ($fields as $field) {
            $field->Sort = $next++;
            $field->write();
        }

        // Add step
        $step = EditableFormStep::create();
        $step->Title = _t('EditableFormStep.TITLE_FIRST', 'First Page');
        $step->Sort = 1;
        $step->write();
        $fields->add($step);
    }

    /**
     * Ensure that at least one page exists at the start
     */
    public function onAfterWrite()
    {
        $this->createInitialFormStep();
    }

    /**
     * @see SiteTree::doPublish
     * @param Page $original
     *
     * @return void
     */
    public function onAfterPublish($original)
    {
        // store IDs of fields we've published
        $seenIDs = array();

        foreach ($this->owner->Fields() as $field) {
            // store any IDs of fields we publish so we don't unpublish them
            $seenIDs[] = $field->ID;
            $field->doPublish('Stage', 'Live');
            $field->destroy();
        }

        // fetch any orphaned live records
        $live = Versioned::get_by_stage("EditableFormField", "Live")
            ->filter(array(
                'ParentID' => $original->ID,
            ));

        if (!empty($seenIDs)) {
            $live = $live->exclude(array(
                'ID' => $seenIDs,
            ));
        }

        // delete orphaned records
        foreach ($live as $field) {
            $field->doDeleteFromStage('Live');
            $field->destroy();
        }
    }

    /**
     * @see SiteTree::doUnpublish
     * @param Page $page
     *
     * @return void
     */
    public function onAfterUnpublish($page)
    {
        foreach ($page->Fields() as $field) {
            $field->doDeleteFromStage('Live');
        }
    }

    /**
     * @see SiteTree::duplicate
     * @param DataObject $newPage
     *
     * @return DataObject
     */
    public function onAfterDuplicate($newPage)
    {
        // List of EditableFieldGroups, where the
        // key of the array is the ID of the old end group
        $fieldGroups = array();
        foreach ($this->owner->Fields() as $field) {
            $newField = $field->duplicate(false);
            $newField->ParentID = $newPage->ID;
            $newField->ParentClass = $newPage->ClassName;
            $newField->Version = 0;
            $newField->write();

            // If we encounter a group start, record it for later use
            if ($field instanceof EditableFieldGroup) {
                $fieldGroups[$field->EndID] = $newField;

The property EndID does not exist on object<EditableFieldGroup>. Since you implemented __get, maybe consider adding a @property annotation.

            }

            // If we encounter an end group, link it back to the group start
            if ($field instanceof EditableFieldGroupEnd && isset($fieldGroups[$field->ID])) {
                $groupStart = $fieldGroups[$field->ID];
                $groupStart->EndID = $newField->ID;
                $groupStart->write();
            }

            foreach ($field->DisplayRules() as $customRule) {

This code seems to be duplicated across your project.

                $newRule = $customRule->duplicate(false);
                $newRule->ParentID = $newField->ID;
                $newRule->Version = 0;
                $newRule->write();
            }
        }

        return $newPage;
    }

    /**
     * @see SiteTree::getIsModifiedOnStage
     * @param boolean $isModified
     *
     * @return boolean
     */
    public function getIsModifiedOnStage($isModified)
    {
        if (!$isModified) {
            foreach ($this->owner->Fields() as $field) {
                if ($field->getIsModifiedOnStage()) {
                    $isModified = true;
                    break;
                }
            }
        }

        return $isModified;
    }

    /**
     * @see SiteTree::doRevertToLive
     * @param Page $page
     *
     * @return void
     */
    public function onAfterRevertToLive($page)
    {
        foreach ($page->Fields() as $field) {
            $field->publish('Live', 'Stage', false);
            $field->writeWithoutVersion();
        }
    }
}