EditableDateField_FormField - Code Metrics - Inspection of "NEW Email custom rules now supports GreaterThan, L..." - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b78927...2357ce )

by Damian

created 2017-05-15 02:05 UTC

EditableDateField_FormField A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	8
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	0
loc	8
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Type()	0	4	1

<?php
/**
 * EditableDateField
 *
 * Allows a user to add a date field.
 *
 * @package userforms
 */

class EditableDateField extends EditableFormField
namespace YourVendor;

class YourClass { }
{

    private static $singular_name = 'Date Field';


    private static $plural_name = 'Date Fields';


    private static $has_placeholder = true;


    private static $db = array(

        'DefaultToToday' => 'Boolean' // From customsettings
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->addFieldToTab(
                'Root.Main',
                CheckboxField::create(
                    'DefaultToToday',
                    _t('EditableFormField.DEFAULTTOTODAY', 'Default to Today?')
                ),
                'RightTitle'
            );
        });

        return parent::getCMSFields();
    }

    /**
     * Return the form field
     *
     */
    public function getFormField()
    {
        $defaultValue = $this->DefaultToToday

            ? SS_Datetime::now()->Format('Y-m-d')
            : $this->Default;

        $field = EditableDateField_FormField::create($this->Name, $this->EscapedTitle, $defaultValue)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->setConfig('showcalendar', true)
            ->setFieldHolderTemplate('UserFormsField_holder')
            ->setTemplate('UserFormsField');

        $this->doUpdateFormField($field);

        return $field;
    }
}

/**
  * @package userforms
 */
class EditableDateField_FormField extends DateField
namespace YourVendor;

class YourClass { }
{

    public function Type()
    {
        return "date-alt text";
    }
}


1			<?php
2			/**
3			* EditableDateField
4			*
5			* Allows a user to add a date field.
6			*
7			* @package userforms
8			*/
9
10			class EditableDateField extends EditableFormField
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12
13			private static $singular_name = 'Date Field';
			0 ignored issues – show Comprehensibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14
15			private static $plural_name = 'Date Fields';
			0 ignored issues – show Comprehensibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16
17			private static $has_placeholder = true;
			0 ignored issues – show Comprehensibility introduced 2017-04-25 12:00 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-04-25 12:00 UTC by Report Bug Copy Issue Report The property `$has_placeholder` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18
19			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			'DefaultToToday' => 'Boolean' // From customsettings
21			);
22
23			/**
24			* @return FieldList
25			*/
26			public function getCMSFields()
27			{
28			$this->beforeUpdateCMSFields(function (FieldList $fields) {
29			$fields->addFieldToTab(
30			'Root.Main',
31			CheckboxField::create(
32			'DefaultToToday',
33			_t('EditableFormField.DEFAULTTOTODAY', 'Default to Today?')
34			),
35			'RightTitle'
36			);
37			});
38
39			return parent::getCMSFields();
40			}
41
42			/**
43			* Return the form field
44			*
45			*/
46			public function getFormField()
47			{
48			$defaultValue = $this->DefaultToToday
			0 ignored issues – show Bug introduced 2015-12-11 05:10 UTC by Report Bug Copy Issue Report The property `DefaultToToday` does not seem to exist. Did you mean `Default`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
49			? SS_Datetime::now()->Format('Y-m-d')
50			: $this->Default;
51
52			$field = EditableDateField_FormField::create($this->Name, $this->EscapedTitle, $defaultValue)
			0 ignored issues – show Documentation introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The property `EscapedTitle` does not exist on `object<EditableDateField>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
53			->setConfig('showcalendar', true)
54			->setFieldHolderTemplate('UserFormsField_holder')
55			->setTemplate('UserFormsField');
56
57			$this->doUpdateFormField($field);
58
59			return $field;
60			}
61			}
62
63			/**
64			* @package userforms
65			*/
66			class EditableDateField_FormField extends DateField
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
67			{
68
69			public function Type()
70			{
71			return "date-alt text";
72			}
73			}
74

silverstripe / silverstripe-userforms

Push — master ( b78927...2357ce )

EditableDateField_FormField A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like