EditableFormFieldTest::testCustomTemplates() - Code Metrics - Inspection of "Removed unneeded list markup from EditableRadioFie..." - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#636)

by Franco

created 2017-07-11 04:46 UTC

EditableFormFieldTest::testCustomTemplates() A

↳ Parent: EditableFormFieldTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

/**
 * @package userforms
 */

class EditableFormFieldTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{

    public static $fixture_file = 'userforms/tests/EditableFormFieldTest.yml';

    public function testFormFieldPermissions()
    {
        $text = $this->objFromFixture('EditableTextField', 'basic-text');

        $this->logInWithPermission('ADMIN');
        $this->assertTrue($text->canCreate());

        $this->assertTrue($text->canView());

        $this->assertTrue($text->canEdit());

        $this->assertTrue($text->canDelete());


        $text->setReadonly(true);
        $this->assertTrue($text->canView());

        $this->assertFalse($text->canEdit());

        $this->assertFalse($text->canDelete());


        $text->setReadonly(false);
        $this->assertTrue($text->canView());

        $this->assertTrue($text->canEdit());

        $this->assertTrue($text->canDelete());


        $member = Member::currentUser();
        $member->logout();

        $this->logInWithPermission('SITETREE_VIEW_ALL');
        $this->assertFalse($text->canCreate());


        $text->setReadonly(false);
        $this->assertTrue($text->canView());

        $this->assertFalse($text->canEdit());

        $this->assertFalse($text->canDelete());


        $text->setReadonly(true);
        $this->assertTrue($text->canView());

        $this->assertFalse($text->canEdit());

        $this->assertFalse($text->canDelete());

    }

    public function testCustomRules()
    {
        $this->logInWithPermission('ADMIN');
        $form = $this->objFromFixture('UserDefinedForm', 'custom-rules-form');

        $checkbox = $form->Fields()->find('ClassName', 'EditableCheckbox');

        $field = $form->Fields()->find('ClassName', 'EditableTextField');


        $rules = $checkbox->DisplayRules();

        // form has 2 fields - a checkbox and a text field
        // it has 1 rule - when ticked the checkbox hides the text field
        $this->assertEquals(1, $rules->Count());

        $this->assertEquals($rules, $checkbox->EffectiveDisplayRules());


        $checkboxRule = $rules->First();
        $checkboxRule->ConditionFieldID = $field->ID;

        $this->assertEquals($checkboxRule->Display, 'Hide');

        $this->assertEquals($checkboxRule->ConditionOption, 'HasValue');

        $this->assertEquals($checkboxRule->FieldValue, '6');


        // If field is required then all custom rules are disabled
        $checkbox->Required = true;
        $this->assertEquals(0, $checkbox->EffectiveDisplayRules()->count());

    }

    /**
     * @covers EditableOption::getValue
     */
    public function testEditableOptionEmptyValue()
    {
        $option = $this->objFromFixture('EditableOption', 'option-1');
        $option->Value = '';

         // Disallow empty values
         EditableOption::set_allow_empty_values(false);
        $this->assertEquals($option->Title, $option->Value);


        $option->Value = 'test';
        $this->assertEquals('test', $option->Value);


         // Allow empty values
         EditableOption::set_allow_empty_values(true);
        $option->Value = '';
        $this->assertEquals('', $option->Value);

    }

    public function testEditableDropdownField()

    {
        $dropdown = $this->objFromFixture('EditableDropdown', 'basic-dropdown');

        $field = $dropdown->getFormField();


        $this->assertThat($field, $this->isInstanceOf('DropdownField'));

        $values = $field->getSource();

        $this->assertEquals(array('Option 1' => 'Option 1', 'Option 2' => 'Option 2'), $values);

    }

    public function testEditableRadioField()

    {
        $radio = $this->objFromFixture('EditableRadioField', 'radio-field');

        $field = $radio->getFormField();

        $this->assertThat($field, $this->isInstanceOf('OptionsetField'));

        $values = $field->getSource();

        $this->assertEquals(array('Option 5' => 'Option 5', 'Option 6' => 'Option 6'), $values);

    }

    public function testMultipleOptionDuplication()
    {
        $dropdown = $this->objFromFixture('EditableDropdown', 'basic-dropdown');

        $clone = $dropdown->duplicate();

        $this->assertEquals($clone->Options()->Count(), $dropdown->Options()->Count());


        foreach ($clone->Options() as $option) {
            $orginal = $dropdown->Options()->find('Title', $option->Title);

            $this->assertEquals($orginal->Sort, $option->Sort);

        }
    }

    public function testFileField()
    {
        $fileField = $this->objFromFixture('EditableFileField', 'file-field');
        $formField = $fileField->getFormField();

        $this->assertContains('jpg', $formField->getValidator()->getAllowedExtensions());
        $this->assertNotContains('notallowedextension', $formField->getValidator()->getAllowedExtensions());
    }

    public function testFileFieldAllowedExtensionsBlacklist()
    {
        Config::inst()->update('EditableFileField', 'allowed_extensions_blacklist', array('jpg'));
        $fileField = $this->objFromFixture('EditableFileField', 'file-field');
        $formField = $fileField->getFormField();

        $this->assertNotContains('jpg', $formField->getValidator()->getAllowedExtensions());
    }

    /**
     * Verify that unique names are automatically generated for each formfield
     */
    public function testUniqueName()
    {
        $textfield1 = new EditableTextField();
        $this->assertEmpty($textfield1->Name);


        // Write values
        $textfield1->write();
        $textfield2 = new EditableTextField();
        $textfield2->write();
        $checkboxField = new EditableCheckbox();
        $checkboxField->write();

        // Test values are in the expected format
        $this->assertRegExp('/^EditableTextField_.+/', $textfield1->Name);

        $this->assertRegExp('/^EditableTextField_.+/', $textfield2->Name);

        $this->assertRegExp('/^EditableCheckbox_.+/', $checkboxField->Name);

        $this->assertNotEquals($textfield1->Name, $textfield2->Name);

    }

    public function testLengthRange()
    {
        /** @var EditableTextField $textField */
        $textField = $this->objFromFixture('EditableTextField', 'basic-text');

        // Empty range
        /** @var TextField $formField */
        $textField->MinLength = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $textField->MaxLength = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $attributes = $textField->getFormField()->getAttributes();
        $this->assertFalse(isset($attributes['maxLength']));

        $this->assertFalse(isset($attributes['data-rule-minlength']));

        $this->assertFalse(isset($attributes['data-rule-maxlength']));


        // Test valid range
        $textField->MinLength = 10;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $textField->MaxLength = 20;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $attributes = $textField->getFormField()->getAttributes();
        $this->assertEquals(20, $attributes['maxLength']);

        $this->assertEquals(20, $attributes['size']);

        $this->assertEquals(10, $attributes['data-rule-minlength']);

        $this->assertEquals(20, $attributes['data-rule-maxlength']);


        // textarea
        $textField->Rows = 3;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $attributes = $textField->getFormField()->getAttributes();
        $this->assertFalse(isset($attributes['maxLength']));

        $this->assertEquals(10, $attributes['data-rule-minlength']);

        $this->assertEquals(20, $attributes['data-rule-maxlength']);

    }

    public function testFormatDisplayRules()
    {
        $field = $this->objFromFixture('EditableFormField', 'irdNumberField');
        $displayRules = $field->formatDisplayRules();
        $this->assertNotNull($displayRules);

        $this->assertCount(1, $displayRules['operations']);


        // Field is initially visible, so the "view" method should be to hide it
        $this->assertSame('addClass("hide")', $displayRules['view']);

        // The opposite method should be to return it to its original state, i.e. show it again
        $this->assertSame('removeClass("hide")', $displayRules['opposite']);

    }

    /**
     * Tests that certain elements are rendered with custom templates
     */
    public function testCustomTemplates()
    {
        $radio = $this->objFromFixture('EditableRadioField', 'radio-field');
        $this->assertEquals('UserFormsOptionSetField', $radio->getFormField()->getTemplate());


        $checkboxGroup = $this->objFromFixture('EditableCheckboxGroupField', 'checkbox-group');
        $this->assertEquals('UserFormsCheckboxSetField', $checkboxGroup->getFormField()->getTemplate());

    }
}


1			<?php
2
3			/**
4			* @package userforms
5			*/
6
7			class EditableFormFieldTest extends FunctionalTest
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9
10			public static $fixture_file = 'userforms/tests/EditableFormFieldTest.yml';
11
12			public function testFormFieldPermissions()
13			{
14			$text = $this->objFromFixture('EditableTextField', 'basic-text');
15
16			$this->logInWithPermission('ADMIN');
17			$this->assertTrue($text->canCreate());
			0 ignored issues – show Bug introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
18			$this->assertTrue($text->canView());
			0 ignored issues – show Bug introduced 2015-12-17 07:20 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
19			$this->assertTrue($text->canEdit());
			0 ignored issues – show Bug introduced 2016-07-21 06:25 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
20			$this->assertTrue($text->canDelete());
			0 ignored issues – show Bug introduced 2016-07-21 06:25 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
21
22			$text->setReadonly(true);
23			$this->assertTrue($text->canView());
			0 ignored issues – show Bug introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
24			$this->assertFalse($text->canEdit());
			0 ignored issues – show Bug introduced 2016-07-21 06:25 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25			$this->assertFalse($text->canDelete());
			0 ignored issues – show Bug introduced 2016-07-21 06:25 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
26
27			$text->setReadonly(false);
28			$this->assertTrue($text->canView());
			0 ignored issues – show Bug introduced 2016-03-14 01:35 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29			$this->assertTrue($text->canEdit());
			0 ignored issues – show Bug introduced 2016-07-21 06:25 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<EditableFormFieldTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
30			$this->assertTrue($text->canDelete());

silverstripe / silverstripe-userforms

Pull Request — master (#636)

EditableFormFieldTest::testCustomTemplates() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like