EditableCheckbox

Complexity

Total Complexity

8

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

28%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	11	1
A	getFormField()	0	10	1
A	migrateSettings()	0	10	2
A	getValueFromData()	0	6	3
A	isCheckBoxField()	0	3	1

<?php
/**
 * EditableCheckbox
 *
 * A user modifiable checkbox on a UserDefinedForm
 *
 * @package userforms
 */

class EditableCheckbox extends EditableFormField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $singular_name = 'Checkbox Field';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = 'Checkboxes';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    protected $jsEventHandler = 'click';

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'CheckedDefault' => 'Boolean' // from CustomSettings
    );

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->replaceField('Default', CheckboxField::create(
            "CheckedDefault",
            _t('EditableFormField.CHECKEDBYDEFAULT', 'Checked by Default?')
        ));

        return $fields;
    }

    public function getFormField()
    {
        $field = CheckboxField::create($this->Name, $this->EscapedTitle, $this->CheckedDefault)

The property EscapedTitle does not exist on object<EditableCheckbox>. Since you implemented __get, maybe consider adding a @property annotation.

The property CheckedDefault does not seem to exist. Did you mean Default?

            ->setFieldHolderTemplate('UserFormsCheckboxField_holder')
            ->setTemplate('UserFormsCheckboxField');

        $this->doUpdateFormField($field);

        return $field;
    }

    public function getValueFromData($data)
    {
        $value = (isset($data[$this->Name])) ? $data[$this->Name] : false;

        return ($value) ? _t('EditableFormField.YES', 'Yes') : _t('EditableFormField.NO', 'No');
    }

    public function migrateSettings($data)
    {
        // Migrate 'Default' setting to 'CheckedDefault'
        if (isset($data['Default'])) {
            $this->CheckedDefault = (bool)$data['Default'];

The property CheckedDefault does not seem to exist. Did you mean Default?

            unset($data['Default']);
        }

        parent::migrateSettings($data);
    }

	public function isCheckBoxField() {
		return true;
	}
}