EmailRecipientTest::testEmptyRecipientFailsValidation() - Code Metrics - Inspection of "Merge branch '5.4'" - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6eb661...4d39c8 )

by Robbie

created 2019-05-07 23:30 UTC

testEmptyRecipientFailsValidation() A

↳ Parent: EmailRecipientTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php

namespace SilverStripe\UserForms\Tests\Model\Recipient;

use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\UserForms\Model\Recipient\EmailRecipient;

class EmailRecipientTest extends SapphireTest
{
    protected static $fixture_file = 'EmailRecipientTest.yml';

    public function testShortcodesAreRenderedInEmailPreviewContent()
    {
        $page = $this->objFromFixture(SiteTree::class, 'about_us');

        $recipient = EmailRecipient::create();
        $recipient->SendPlain = false;
        $recipient->EmailBodyHtml = '<p>Some email content. About us: [sitetree_link,id=' . $page->ID . '].</p>';

        $result = $recipient->getEmailBodyContent();
        $this->assertContains('/about-us/', $result);

        $recipient->SendPlain = true;
        $recipient->EmailBody = 'Some email content. About us: [sitetree_link,id=' . $page->ID . '].';

        $result = $recipient->getEmailBodyContent();
        $this->assertContains('/about-us/', $result);
    }

    /**
     * @expectedException SilverStripe\ORM\ValidationException
     * @expectedExceptionMessage "Send email to" address or field is required
     */
    public function testEmptyRecipientFailsValidation()
    {
        $recipient = new EmailRecipient();
        $recipient->EmailFrom = '[email protected]';

        $recipient->write();
    }
}


1			<?php
2
3			namespace SilverStripe\UserForms\Tests\Model\Recipient;
4
5			use SilverStripe\CMS\Model\SiteTree;
6			use SilverStripe\Dev\SapphireTest;
7			use SilverStripe\UserForms\Model\Recipient\EmailRecipient;
8
9			class EmailRecipientTest extends SapphireTest
10			{
11			protected static $fixture_file = 'EmailRecipientTest.yml';
12
13			public function testShortcodesAreRenderedInEmailPreviewContent()
14			{
15			$page = $this->objFromFixture(SiteTree::class, 'about_us');
16
17			$recipient = EmailRecipient::create();
18			$recipient->SendPlain = false;
19			$recipient->EmailBodyHtml = '<p>Some email content. About us: [sitetree_link,id=' . $page->ID . '].</p>';
20
21			$result = $recipient->getEmailBodyContent();
22			$this->assertContains('/about-us/', $result);
23
24			$recipient->SendPlain = true;
25			$recipient->EmailBody = 'Some email content. About us: [sitetree_link,id=' . $page->ID . '].';
26
27			$result = $recipient->getEmailBodyContent();
28			$this->assertContains('/about-us/', $result);
29			}
30
31			/**
32			* @expectedException SilverStripe\ORM\ValidationException
33			* @expectedExceptionMessage "Send email to" address or field is required
34			*/
35			public function testEmptyRecipientFailsValidation()
36			{
37			$recipient = new EmailRecipient();
38			$recipient->EmailFrom = '[email protected]';
			0 ignored issues – show Bug Best Practice introduced 2019-05-07 23:35 UTC by Report Bug Copy Issue Report The property `EmailFrom` does not exist on `SilverStripe\UserForms\M...ecipient\EmailRecipient`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
39			$recipient->write();
40			}
41			}
42

silverstripe / silverstripe-userforms

Push — master ( 6eb661...4d39c8 )

testEmptyRecipientFailsValidation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like