Issues in UserFormsCompositeField.php - All Issues - Inspection of "Merge pull request #717 from creative-commoners/pu..." - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ebdfbb...20570e )

unknown

created 2018-02-14 21:41 UTC

code/FormField/UserFormsCompositeField.php (4 issues)

Labels

Severity

<?php

namespace SilverStripe\UserForms\FormField;

use SilverStripe\Forms\CompositeField;
use SilverStripe\UserForms\Model\EditableFormField;
use SilverStripe\UserForms\Model\EditableFormField\EditableFormStep;

/**
 * Represents a composite field group, which may contain other groups
 */
abstract class UserFormsCompositeField extends CompositeField implements UserFormsFieldContainer
{
    /**
     * Parent field
     *
     * @var UserFormsFieldContainer
     */
    protected $parent = null;

    public function getParent()
    {
        return $this->parent;
    }

    public function setParent(UserFormsFieldContainer $parent)
    {
        $this->parent = $parent;
        return $this;
    }

    public function processNext(EditableFormField $field)
    {
        // When we find a step, bubble up to the top
        if ($field instanceof EditableFormStep) {
            return $this->getParent()->processNext($field);
        }

        // Skip over fields that don't generate formfields
        if (get_class($field) === EditableFormField::class || !$field->getFormField()) {
            return $this;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }
        /** @var EditableFormField $formField */
        $formField = $field->getFormField();

        // Save this field
        $this->push($formField);
        $this->push(/** @scrutinizer ignore-type */ $formField);

        // Nest fields that are containers
        if ($formField instanceof UserFormsFieldContainer) {
            return $formField->setParent($this);
            return $formField->/** @scrutinizer ignore-call */ setParent($this);
        }

        // Add any subsequent fields to this
        return $this;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


silverstripe / silverstripe-userforms

Push — master ( ebdfbb...20570e )

code/FormField/UserFormsCompositeField.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like