UserFormsCheckboxSetField::validate() - Code Metrics - Inspection of "BUG Fix issue with UserFormsCheckboxSetField" - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#534)

by Damian

created 2016-12-15 21:15 UTC

UserFormsCheckboxSetField::validate() A

↳ Parent: UserFormsCheckboxSetField

Complexity

Conditions	3
Paths	2

Size

Total Lines	22
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.2
c	0
b	0
f	0
cc	3
eloc	8
nc	2
nop	1

<?php

/**
 * @package userforms
 */
class UserFormsCheckboxSetField extends CheckboxSetField
namespace YourVendor;

class YourClass { }
{

    /**
     * jQuery validate requires that the value of the option does not contain
     * the actual value of the input.
     *
     * @return ArrayList
     */
    public function getOptions()
    {
        $options = parent::getOptions();

        foreach ($options as $option) {
            $option->Name = "{$this->name}[]";
        }

        return $options;
    }

    /**
     * @inheritdoc
     *
     * @param Validator $validator
     *
     * @return bool
     */
    public function validate($validator)
    {
        // get the previous values (could contain comma-delimited list)

        $previous = $value = $this->Value();

        if (is_string($value) && strstr($value, ",")) {
            $value = explode(",", $value);
        }

        // set the value as an array for parent validation

        $this->setValue($value);

        $validated = parent::validate($validator);

        // restore previous value after validation

        $this->setValue($previous);

        return $validated;
    }
}


1			<?php
2
3			/**
4			* @package userforms
5			*/
6			class UserFormsCheckboxSetField extends CheckboxSetField
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8
9			/**
10			* jQuery validate requires that the value of the option does not contain
11			* the actual value of the input.
12			*
13			* @return ArrayList
14			*/
15			public function getOptions()
16			{
17			$options = parent::getOptions();
18
19			foreach ($options as $option) {
20			$option->Name = "{$this->name}[]";
21			}
22
23			return $options;
24			}
25
26			/**
27			* @inheritdoc
28			*
29			* @param Validator $validator
30			*
31			* @return bool
32			*/
33			public function validate($validator)
34			{
35			// get the previous values (could contain comma-delimited list)
36
37			$previous = $value = $this->Value();
38
39			if (is_string($value) && strstr($value, ",")) {
40			$value = explode(",", $value);
41			}
42
43			// set the value as an array for parent validation
44
45			$this->setValue($value);
46
47			$validated = parent::validate($validator);
48
49			// restore previous value after validation
50
51			$this->setValue($previous);
52
53			return $validated;
54			}
55			}
56

silverstripe / silverstripe-userforms

Pull Request — master (#534)

UserFormsCheckboxSetField::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like