EditableCustomRule

Complexity

Total Complexity

13

Size/Duplication

Total Lines	131
Duplicated Lines	17.56 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	doPublish()	0	3	1
A	doDeleteFromStage()	0	3	1
A	canDelete()	0	3	1
A	canEdit()	0	3	1
A	canView()	0	3	1
A	canCreate()	10	10	2
A	getCanCreateContext()	13	13	4
A	canPublish()	0	3	1
A	canUnpublish()	0	3	1

<?php

/**
 * A custom rule for showing / hiding an EditableFormField
 * based the value of another EditableFormField.
 *
 * @method EditableFormField Parent()
 * @package userforms
 */
class EditableCustomRule extends DataObject {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	private static $condition_options = array(

The property $condition_options is not used and could be removed.

		"IsBlank" => "Is blank",
		"IsNotBlank" => "Is not blank",
		"HasValue" => "Equals",
		"ValueNot" => "Doesn't equal",
		"ValueLessThan" => "Less than",
		"ValueLessThanEqual" => "Less than or equal",
		"ValueGreaterThan" => "Greater than",
		"ValueGreaterThanEqual" => "Greater than or equal"
	);

	private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

		'Display' => 'Enum("Show,Hide")',
		'ConditionOption' => 'Enum("IsBlank,IsNotBlank,HasValue,ValueNot,ValueLessThan,ValueLessThanEqual,ValueGreaterThan,ValueGreaterThanEqual")',
		'FieldValue' => 'Varchar'
	);

	private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

		'Parent' => 'EditableFormField',
		'ConditionField' => 'EditableFormField'
	);

	/**
	 * Built in extensions required
	 *
	 * @config
	 * @var array
	 */
	private static $extensions = array(

Consider using a different property name as you override a private property of the parent class.

The property $extensions is not used and could be removed.

		"Versioned('Stage', 'Live')"
	);

	/**
	 * Publish this custom rule to the live site
	 *
	 * Wrapper for the {@link Versioned} publish function
	 */
	public function doPublish($fromStage, $toStage, $createNewVersion = false) {
		$this->publish($fromStage, $toStage, $createNewVersion);

The method publish() does not exist on EditableCustomRule. Did you maybe mean doPublish()?

	}

	/**
	 * Delete this custom rule from a given stage
	 *
	 * Wrapper for the {@link Versioned} deleteFromStage function
	 */
	public function doDeleteFromStage($stage) {
		$this->deleteFromStage($stage);

The method deleteFromStage() does not exist on EditableCustomRule. Did you maybe mean doDeleteFromStage()?

	}


    /**
     * @param Member $member
     * @return bool
     */
	public function canDelete($member = null) {
		return $this->canEdit($member);
	}

    /**
     * @param Member $member
     * @return bool
     */
	public function canEdit($member = null) {
        return $this->Parent()->canEdit($member);
	}

    /**
     * @param Member $member
     * @return bool
     */
	public function canView($member = null) {
		return $this->Parent()->canView($member);
	}

	/**
	 * Return whether a user can create an object of this type
	 *
     * @param Member $member
     * @param array $context Virtual parameter to allow context to be passed in to check

There is no parameter named $context. Was it maybe removed?

	 * @return bool
	 */
	public function canCreate($member = null) {

This method seems to be duplicated in your project.

		// Check parent page
        $parent = $this->getCanCreateContext(func_get_args());
        if($parent) {
            return $parent->canEdit($member);
        }

        // Fall back to secure admin permissions
        return parent::canCreate($member);
	}

    /**
     * Helper method to check the parent for this object
     *
     * @param array $args List of arguments passed to canCreate
     * @return DataObject Some parent dataobject to inherit permissions from
     */
    protected function getCanCreateContext($args) {

This method seems to be duplicated in your project.

        // Inspect second parameter to canCreate for a 'Parent' context
        if(isset($args[1]['Parent'])) {
            return $args[1]['Parent'];
        }
        // Hack in currently edited page if context is missing
        if(Controller::has_curr() && Controller::curr() instanceof CMSMain) {
            return Controller::curr()->currentPage();
        }

        // No page being edited
        return null;
    }

    /**
     * @param Member $member
     * @return bool
     */
    public function canPublish($member = null) {
        return $this->canEdit($member);
    }

    /**
     * @param Member $member
     * @return bool
     */
    public function canUnpublish($member = null) {
        return $this->canDelete($member);
    }
}