EmailRecipientTest::testShortcodesAreRenderedInEmailPreviewContent() - Code Metrics - Inspection of "Merge pull request #647 from creative-commoners/pu..." - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 016a0b...25fc98 )

by Franco

created 2017-09-05 22:25 UTC

testShortcodesAreRenderedInEmailPreviewContent() A

↳ Parent: EmailRecipientTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	17
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	11
nc	1
nop	0

<?php

namespace SilverStripe\UserForms\Tests\Model\Recipient;

use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\UserForms\Model\Recipient\EmailRecipient;

class EmailRecipientTest extends SapphireTest
{
    protected static $fixture_file = 'EmailRecipientTest.yml';

    public function testShortcodesAreRenderedInEmailPreviewContent()
    {
        $page = $this->objFromFixture(SiteTree::class, 'about_us');

        $recipient = EmailRecipient::create();
        $recipient->SendPlain = false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $recipient->EmailBodyHtml = '<p>Some email content. About us: [sitetree_link,id=' . $page->ID . '].</p>';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $result = $recipient->getEmailBodyContent();
        $this->assertContains('/about-us/', $result);

        $recipient->SendPlain = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $recipient->EmailBody = 'Some email content. About us: [sitetree_link,id=' . $page->ID . '].';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $result = $recipient->getEmailBodyContent();
        $this->assertContains('/about-us/', $result);
    }
}


1			<?php
2
3			namespace SilverStripe\UserForms\Tests\Model\Recipient;
4
5			use SilverStripe\CMS\Model\SiteTree;
6			use SilverStripe\Dev\SapphireTest;
7			use SilverStripe\UserForms\Model\Recipient\EmailRecipient;
8
9			class EmailRecipientTest extends SapphireTest
10			{
11			protected static $fixture_file = 'EmailRecipientTest.yml';
12
13			public function testShortcodesAreRenderedInEmailPreviewContent()
14			{
15			$page = $this->objFromFixture(SiteTree::class, 'about_us');
16
17			$recipient = EmailRecipient::create();
18			$recipient->SendPlain = false;
			0 ignored issues – show Documentation introduced 2017-08-22 01:20 UTC by Report Bug Copy Issue Report The property `SendPlain` does not exist on `object<SilverStripe\User...cipient\EmailRecipient>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
19			$recipient->EmailBodyHtml = '<p>Some email content. About us: [sitetree_link,id=' . $page->ID . '].</p>';
			0 ignored issues – show Documentation introduced 2017-08-22 01:20 UTC by Report Bug Copy Issue Report The property `EmailBodyHtml` does not exist on `object<SilverStripe\User...cipient\EmailRecipient>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20
21			$result = $recipient->getEmailBodyContent();
22			$this->assertContains('/about-us/', $result);
23
24			$recipient->SendPlain = true;
			0 ignored issues – show Documentation introduced 2017-08-22 01:20 UTC by Report Bug Copy Issue Report The property `SendPlain` does not exist on `object<SilverStripe\User...cipient\EmailRecipient>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			$recipient->EmailBody = 'Some email content. About us: [sitetree_link,id=' . $page->ID . '].';
			0 ignored issues – show Documentation introduced 2017-08-22 01:20 UTC by Report Bug Copy Issue Report The property `EmailBody` does not exist on `object<SilverStripe\User...cipient\EmailRecipient>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26
27			$result = $recipient->getEmailBodyContent();
28			$this->assertContains('/about-us/', $result);
29			}
30			}
31

silverstripe / silverstripe-userforms

Push — master ( 016a0b...25fc98 )

testShortcodesAreRenderedInEmailPreviewContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like