UserFormsCheckboxSetFieldTest - Code Metrics - Inspection of "Merge pull request #647 from creative-commoners/pu..." - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 016a0b...25fc98 )

by Franco

created 2017-09-05 22:25 UTC

UserFormsCheckboxSetFieldTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	3
dl	0
loc	28
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	testValidate()	0	25	1

<?php

namespace SilverStripe\UserForms\Tests\FormField;

use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\RequiredFields;
use SilverStripe\UserForms\FormField\UserFormsCheckboxSetField;

class UserFormsCheckboxSetFieldTest extends SapphireTest
{
    public function testValidate()
    {
        $field = new UserFormsCheckboxSetField('Field', 'My field', ['One' => 'One', 'Two' => 'Two']);
        $validator = new RequiredFields();

        // String values
        $field->setValue('One');
        $this->assertTrue($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $field->setValue('One,Two');
        $this->assertTrue($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $field->setValue('Three,Four');
        $this->assertFalse($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // Array values
        $field->setValue(array('One'));
        $this->assertTrue($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $field->setValue(array('One', 'Two'));
        $this->assertTrue($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // Invalid
        $field->setValue('Three');
        $this->assertFalse($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $field->setValue(array('Three', 'Four'));
        $this->assertFalse($field->validate($validator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace SilverStripe\UserForms\Tests\FormField;
4
5			use SilverStripe\Dev\SapphireTest;
6			use SilverStripe\Forms\RequiredFields;
7			use SilverStripe\UserForms\FormField\UserFormsCheckboxSetField;
8
9			class UserFormsCheckboxSetFieldTest extends SapphireTest
10			{
11			public function testValidate()
12			{
13			$field = new UserFormsCheckboxSetField('Field', 'My field', ['One' => 'One', 'Two' => 'Two']);
14			$validator = new RequiredFields();
15
16			// String values
17			$field->setValue('One');
18			$this->assertTrue($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			$field->setValue('One,Two');
20			$this->assertTrue($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			$field->setValue('Three,Four');
22			$this->assertFalse($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23
24			// Array values
25			$field->setValue(array('One'));
26			$this->assertTrue($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			$field->setValue(array('One', 'Two'));
28			$this->assertTrue($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29
30			// Invalid
31			$field->setValue('Three');
32			$this->assertFalse($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			$field->setValue(array('Three', 'Four'));
34			$this->assertFalse($field->validate($validator));
			0 ignored issues – show Documentation introduced 2017-08-16 02:04 UTC by Report Bug Copy Issue Report `$validator` is of type `object<SilverStripe\Forms\RequiredFields>`, but the function expects a `object<SilverStripe\User...ms\FormField\Validator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			}
36			}
37

silverstripe / silverstripe-userforms

Push — master ( 016a0b...25fc98 )

UserFormsCheckboxSetFieldTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like