Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | class EditableMultipleOptionField extends EditableFormField |
||
|
|
|||
| 17 | { |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Define this field as abstract (not inherited) |
||
| 21 | * |
||
| 22 | * @config |
||
| 23 | * @var bool |
||
| 24 | */ |
||
| 25 | private static $abstract = true; |
||
| 26 | |||
| 27 | private static $has_many = array( |
||
| 28 | "Options" => "EditableOption" |
||
| 29 | ); |
||
| 30 | |||
| 31 | /** |
||
| 32 | * @return FieldList |
||
| 33 | */ |
||
| 34 | 3 | public function getCMSFields() |
|
| 85 | |||
| 86 | /** |
||
| 87 | * Publishing Versioning support. |
||
| 88 | * |
||
| 89 | * When publishing it needs to handle copying across / publishing |
||
| 90 | * each of the individual field options |
||
| 91 | * |
||
| 92 | * @return void |
||
| 93 | */ |
||
| 94 | 1 | public function doPublish($fromStage, $toStage, $createNewVersion = false) |
|
| 95 | { |
||
| 96 | 1 | $live = Versioned::get_by_stage("EditableOption", "Live", "\"EditableOption\".\"ParentID\" = $this->ID"); |
|
| 97 | |||
| 98 | 1 | if ($live) { |
|
| 99 | 1 | foreach ($live as $option) { |
|
| 100 | 1 | $option->delete(); |
|
| 101 | 1 | } |
|
| 102 | 1 | } |
|
| 103 | |||
| 104 | 1 | if ($this->Options()) { |
|
| 105 | 1 | foreach ($this->Options() as $option) { |
|
| 106 | 1 | $option->publish($fromStage, $toStage, $createNewVersion); |
|
| 107 | 1 | } |
|
| 108 | 1 | } |
|
| 109 | |||
| 110 | 1 | parent::doPublish($fromStage, $toStage, $createNewVersion); |
|
| 111 | 1 | } |
|
| 112 | |||
| 113 | /** |
||
| 114 | * Unpublishing Versioning support |
||
| 115 | * |
||
| 116 | * When unpublishing the field it has to remove all options attached |
||
| 117 | * |
||
| 118 | * @return void |
||
| 119 | */ |
||
| 120 | public function doDeleteFromStage($stage) |
||
| 121 | { |
||
| 122 | // Remove options |
||
| 123 | $options = Versioned::get_by_stage('EditableOption', $stage) |
||
| 124 | ->filter('ParentID', $this->ID); |
||
| 125 | foreach ($options as $option) { |
||
| 126 | $option->deleteFromStage($stage); |
||
| 127 | } |
||
| 128 | |||
| 129 | parent::doDeleteFromStage($stage); |
||
| 130 | } |
||
| 131 | |||
| 132 | /** |
||
| 133 | * Deletes all the options attached to this field before deleting the |
||
| 134 | * field. Keeps stray options from floating around |
||
| 135 | * |
||
| 136 | * @return void |
||
| 137 | */ |
||
| 138 | public function delete() |
||
| 139 | { |
||
| 140 | $options = $this->Options(); |
||
| 141 | |||
| 142 | if ($options) { |
||
| 143 | foreach ($options as $option) { |
||
| 144 | $option->delete(); |
||
| 145 | } |
||
| 146 | } |
||
| 147 | |||
| 148 | parent::delete(); |
||
| 149 | } |
||
| 150 | |||
| 151 | /** |
||
| 152 | * Duplicate a pages content. We need to make sure all the fields attached |
||
| 153 | * to that page go with it |
||
| 154 | * |
||
| 155 | * @return DataObject |
||
| 156 | */ |
||
| 157 | 1 | public function duplicate($doWrite = true) |
|
| 170 | |||
| 171 | /** |
||
| 172 | * Return whether or not this field has addable options such as a |
||
| 173 | * {@link EditableDropdownField} or {@link EditableRadioField} |
||
| 174 | * |
||
| 175 | * @return bool |
||
| 176 | */ |
||
| 177 | public function getHasAddableOptions() |
||
| 181 | |||
| 182 | /** |
||
| 183 | * Gets map of field options suitable for use in a form |
||
| 184 | * |
||
| 185 | * @return array |
||
| 186 | */ |
||
| 187 | 3 | protected function getOptionsMap() |
|
| 196 | |||
| 197 | /** |
||
| 198 | * Returns all default options |
||
| 199 | * |
||
| 200 | * @return SS_List |
||
| 201 | */ |
||
| 202 | 3 | protected function getDefaultOptions() |
|
| 206 | } |
||
| 207 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.