UserFormsCheckboxSetField::validate() - Code Metrics - Inspection of "Fixing validation for CheckboxSet field" - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#473)

by Christopher

created 2016-05-15 20:29 UTC

UserFormsCheckboxSetField::validate() A

↳ Parent: UserFormsCheckboxSetField

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	22
rs	9.2
cc	2
eloc	8
nc	2
nop	1

<?php

/**
 * @package userforms
 */
class UserFormsCheckboxSetField extends CheckboxSetField {
namespace YourVendor;

class YourClass { }

	/**
	 * jQuery validate requires that the value of the option does not contain
	 * the actual value of the input.
	 *
	 * @return ArrayList
	 */
	public function getOptions() {
		$options = parent::getOptions();

		foreach($options as $option) {
			$option->Name = "{$this->name}[]";
		}

		return $options;
	}

	/**
	 * @inheritdoc
	 *
	 * @return array
	 */
	public function getSourceAsArray()
	{
		$array = parent::getSourceAsArray();

		return array_values($array);
	}

	/**
	 * @inheritdoc
	 *
	 * @param Validator $validator
	 *
	 * @return bool
	 */
	public function validate($validator)
	{
		// get the previous values (could contain comma-delimited list)

		$previous = $value = $this->Value();

		if (strstr($value, ",")) {
			$value = explode(",", $value);
		}

		// set the value as an array for parent validation

		$this->setValue($value);

		$validated = parent::validate($validator);

		// restore previous value after validation

		$this->setValue($previous);

		return $validated;
	}
}


1			<?php
2
3			/**
4			* @package userforms
5			*/
6			class UserFormsCheckboxSetField extends CheckboxSetField {
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7
8			/**
9			* jQuery validate requires that the value of the option does not contain
10			* the actual value of the input.
11			*
12			* @return ArrayList
13			*/
14			public function getOptions() {
15			$options = parent::getOptions();
16
17			foreach($options as $option) {
18			$option->Name = "{$this->name}[]";
19			}
20
21			return $options;
22			}
23
24			/**
25			* @inheritdoc
26			*
27			* @return array
28			*/
29			public function getSourceAsArray()
30			{
31			$array = parent::getSourceAsArray();
32
33			return array_values($array);
34			}
35
36			/**
37			* @inheritdoc
38			*
39			* @param Validator $validator
40			*
41			* @return bool
42			*/
43			public function validate($validator)
44			{
45			// get the previous values (could contain comma-delimited list)
46
47			$previous = $value = $this->Value();
48
49			if (strstr($value, ",")) {
50			$value = explode(",", $value);
51			}
52
53			// set the value as an array for parent validation
54
55			$this->setValue($value);
56
57			$validated = parent::validate($validator);
58
59			// restore previous value after validation
60
61			$this->setValue($previous);
62
63			return $validated;
64			}
65			}
66

silverstripe / silverstripe-userforms

Pull Request — master (#473)

UserFormsCheckboxSetField::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like