UserFormsUpgradeService - Code Metrics - Inspection of "Merge pull request #630 from martinduparc/patch-2" - silverstripe/silverstripe-userforms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 67ead9...61a703 )

by Daniel

created 2017-06-30 15:14 UTC

UserFormsUpgradeService B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	286
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

64.41%

Importance

Changes

Metric	Value
wmc	39
lcom	1
cbo	8
dl	0
loc	286
ccs	76
cts	118
cp	0.6441
rs	8.2857
c	0
b	0
f	0

10 Methods

Rating	Name	Size	Complexity
A	upgradeFieldInStage()	14	1
A	setQuiet()	5	1
A	getQuiet()	4	1
A	run()	10	2
A	upgradeField()	17	3
D	migrateRules()	30	9
B	migrateCustomSettings()	39	4
C	findOrCreateRule()	39	7
A	log()	11	3
C	migratePlaceholder()	50	8

<?php

/**
 * Service to support upgrade of userforms module
 */
class UserFormsUpgradeService
namespace YourVendor;

class YourClass { }
{

    /**
     * @var bool
     */
    protected $quiet;

    public function run()
    {
        $this->log("Upgrading formfield rules and custom settings");

        // List of rules that have been created in all stages
        $fields = Versioned::get_including_deleted('EditableFormField');
        foreach ($fields as $field) {
            $this->upgradeField($field);
        }
    }

    /**
     * Migrate a versioned field in all stages
     *
     * @param EditableFormField $field
     */
    protected function upgradeField(EditableFormField $field)
    {
        $this->log("Upgrading formfield ID = ".$field->ID);

        // Check versions this field exists on
        $filter = sprintf('"EditableFormField"."ID" = \'%d\' AND "Migrated" = 0', $field->ID);
        $stageField = Versioned::get_one_by_stage('EditableFormField', 'Stage', $filter);
        $liveField = Versioned::get_one_by_stage('EditableFormField', 'Live', $filter);

        if ($stageField) {
            $this->upgradeFieldInStage($stageField, 'Stage');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if ($liveField) {
            $this->upgradeFieldInStage($liveField, 'Live');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * Migrate a versioned field in a single stage
     *
     * @param EditableFormField $field
     * @param stage $stage
     */
    protected function upgradeFieldInStage(EditableFormField $field, $stage)
    {
        Versioned::reading_stage($stage);

        // Migrate field rules
        $this->migrateRules($field, $stage);

        // Migrate custom settings
        $this->migrateCustomSettings($field, $stage);

        // Flag as migrated
        $field->Migrated = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $field->write();
    }

    /**
     * Migrate custom rules for the given field
     *
     * @param EditableFormField $field
     * @param string $stage
     */
    protected function migrateRules(EditableFormField $field, $stage)
    {
        $rulesData = $field->CustomRules
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ? unserialize($field->CustomRules)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            : array();

        // Skip blank rules or fields with custom rules already
        if (empty($rulesData) || $field->DisplayRules()->count()) {
            return;
        }

        // Check value of this condition
        foreach ($rulesData as $ruleDataItem) {
            if (empty($ruleDataItem['ConditionOption']) || empty($ruleDataItem['Display'])) {
                continue;
            }

            // Get data for this rule
            $conditionOption = $ruleDataItem['ConditionOption'];
            $display = $ruleDataItem['Display'];
            $conditionFieldName = empty($ruleDataItem['ConditionField']) ? null : $ruleDataItem['ConditionField'];
            $value = isset($ruleDataItem['Value'])
                ? $ruleDataItem['Value']
                : null;

            // Create rule
            $rule = $this->findOrCreateRule($field, $stage, $conditionOption, $display, $conditionFieldName, $value);
            $this->log("Upgrading rule ID = " . $rule->ID);
        }
    }



    /**
     * Migrate custom settings for the given field
     *
     * @param EditableFormField $field
     * @param string $stage
     */
    protected function migrateCustomSettings(EditableFormField $field, $stage)

    {
        // Custom settings include:
        // - ExtraClass
        // - RightTitle
        // - ShowOnLoad (show or '' are treated as true)
        //
        // - CheckedDefault (new field on EditableCheckbox - should be read from old "default" value)
        // - Default (EditableCheckbox)

        // - DefaultToToday (EditableDateField)
        // - Folder (EditableFileField)
        // - Level (EditableFormHeading)
        // - HideFromReports (EditableFormHeading / EditableLiteralField)
        // - Content (EditableLiteralField)
        // - GroupID (EditableMemberListField)
        // - MinValue (EditableNumericField)
        // - MaxValue (EditableNumericField)
        // - MinLength (EditableTextField)
        // - MaxLength (EditableTextField)
        // - Rows (EditableTextField)
        // - Placeholder (EditableTextField / EditableEmailField / EditableNumericField)

        $customSettings = $field->CustomSettings
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ? unserialize($field->CustomSettings)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            : array();

        // Skip blank rules or fields with custom rules already
        if (empty($customSettings)) {
            return;
        }

        $field->migrateSettings($customSettings);

        if ($field->config()->has_placeholder) {
            $this->migratePlaceholder($field, $field->ClassName);
        }

        $field->write();
    }

    /**
     * Create or find an existing field with the matched specification
     *
     * @param EditableFormField $field
     * @param string $stage
     * @param string $conditionOption
     * @param string $display
     * @param string $conditionFieldName
     * @param string $value
     * @return EditableCustomRule
     */
    protected function findOrCreateRule(EditableFormField $field, $stage, $conditionOption, $display, $conditionFieldName, $value)
    {
        // Get id of field
        $conditionField = $conditionFieldName
            ? EditableFormField::get()->filter('Name', $conditionFieldName)->first()
            : null;

        // If live, search stage record for matching one
        if ($stage === 'Live') {
            $list = Versioned::get_by_stage('EditableCustomRule', 'Stage')
                ->filter(array(
                    'ParentID' => $field->ID,
                    'ConditionFieldID' => $conditionField ? $conditionField->ID : 0,
                    'Display' => $display,
                    'ConditionOption' => $conditionOption
                ));
            if ($value) {
                $list = $list->filter('FieldValue', $value);
            } else {
                $list = $list->where('"FieldValue" IS NULL OR "FieldValue" = \'\'');
            }
            $rule = $list->first();
            if ($rule) {
                $rule->write();
                $rule->publish("Stage", "Live");
                return $rule;
            }
        }

        // If none found, or in stage, create new record
        $rule = new EditableCustomRule();
        $rule->ParentID = $field->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $rule->ConditionFieldID = $conditionField ? $conditionField->ID : 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $rule->Display = $display;
        $rule->ConditionOption = $conditionOption;
        $rule->FieldValue = $value;
        $rule->write();
        return $rule;
    }

    public function log($message)
    {
        if ($this->getQuiet()) {
            return;
        }
        if (Director::is_cli()) {
            echo "{$message}\n";
        } else {
            echo "{$message}<br />";
        }
    }

    /**
     * Set if this service should be quiet
     *
     * @param bool $quiet
     * @return $ths

     */
    public function setQuiet($quiet)
    {
        $this->quiet = $quiet;
        return $this;
    }

    public function getQuiet()
    {
        return $this->quiet;
    }


    /**
     * Migrate Placeholder data from field specific table to the EditableFormField table
     *
     * @param EditableFormField $field
     * @param string $tableName
     */
    private function migratePlaceholder($field, $tableName)
    {
        // Migrate Placeholder setting from $tableName table to EditableFormField table
        if ($field->Placeholder) {

            return;
        }
        // Check if draft table exists
        if (!DB::get_schema()->hasTable($tableName)) {
            // Check if _obsolete_ draft table exists
            $tableName = '_obsolete_' . $tableName;
            if (!DB::get_schema()->hasTable($tableName)) {
                return;
            }
        }
        // Check if old Placeholder column exists
        if (!DB::get_schema()->hasField($tableName, 'Placeholder')) {
            return;
        }
        // Fetch existing draft Placeholder value
        $query = "SELECT \"Placeholder\" FROM \"$tableName\" WHERE \"ID\" = '$field->ID'";
        $draftPlaceholder = DB::query($query)->value();

        if (!$draftPlaceholder) {
            return;
        }
        // Update draft Placeholder value
        DB::prepared_query(
            "UPDATE \"EditableFormField\" SET \"Placeholder\" = ? WHERE \"ID\" = ?",
            array($draftPlaceholder, $field->ID)
        );

        $livePlaceholder = $draftPlaceholder;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // Check if live table exists
        $tableName = $tableName . '_Live';
        if (DB::get_schema()->hasTable($tableName)) {
            // Fetch existing live Placeholder value
            $query = "SELECT \"Placeholder\" FROM \"$tableName\" WHERE \"ID\" = '" . $field->ID . "'";
            $livePlaceholder = DB::query($query)->value();
            if (!$livePlaceholder) {
                $livePlaceholder = $draftPlaceholder;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        }

        // Update live Placeholder value
        DB::prepared_query(
            "UPDATE \"EditableFormField_Live\" SET \"Placeholder\" = ? WHERE \"ID\" = ?",
            array($draftPlaceholder, $field->ID)
        );
    }
}


1		<?php
2
3		/**
4		* Service to support upgrade of userforms module
5		*/
6		class UserFormsUpgradeService
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 07:02 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8
9		/**
10		* @var bool
11		*/
12		protected $quiet;
13
14	2	public function run()
15		{
16	2	$this->log("Upgrading formfield rules and custom settings");
17
18		// List of rules that have been created in all stages
19	2	$fields = Versioned::get_including_deleted('EditableFormField');
20	2	foreach ($fields as $field) {
21	2	$this->upgradeField($field);
22		}
23	2	}
24
25		/**
26		* Migrate a versioned field in all stages
27		*
28		* @param EditableFormField $field
29		*/
30	2	protected function upgradeField(EditableFormField $field)
31		{
32	2	$this->log("Upgrading formfield ID = ".$field->ID);
33
34		// Check versions this field exists on
35	2	$filter = sprintf('"EditableFormField"."ID" = \'%d\' AND "Migrated" = 0', $field->ID);
36	2	$stageField = Versioned::get_one_by_stage('EditableFormField', 'Stage', $filter);
37	2	$liveField = Versioned::get_one_by_stage('EditableFormField', 'Live', $filter);
38
39	2	if ($stageField) {

silverstripe / silverstripe-userforms

Push — master ( 67ead9...61a703 )

UserFormsUpgradeService B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

Duplication Side-by-Side

Filter issues like