EditableFormFieldTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	172
Duplicated Lines	12.21 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	6
Bugs	4	Features	1

9 Methods

Rating	Name	Duplication	Size	Complexity
B	testCustomRules()	0	25	1
A	testFileField()	0	7	1
B	testFormFieldPermissions()	0	35	1
A	testEditableDropdownField()	11	11	1
A	testEditableRadioField()	10	10	1
A	testMultipleOptionDuplication()	0	13	2
A	testFileFieldAllowedExtensionsBlacklist()	0	7	1
A	testUniqueName()	0	17	1
B	testLengthRange()	0	29	1

<?php

/**
 * @package userforms
 */

class EditableFormFieldTest extends FunctionalTest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	static $fixture_file = 'userforms/tests/EditableFormFieldTest.yml';

The visibility should be declared for property $fixture_file.

	function testFormFieldPermissions() {

It is generally recommended to explicitly declare the visibility for methods.

		$text = $this->objFromFixture('EditableTextField', 'basic-text');

		$this->logInWithPermission('ADMIN');
		$this->assertTrue($text->canCreate());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertTrue($text->canView());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertTrue($text->canEdit());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertTrue($text->canDelete());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$text->setReadonly(true);
		$this->assertTrue($text->canView());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertFalse($text->canEdit());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertFalse($text->canDelete());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

		$text->setReadonly(false);
		$this->assertTrue($text->canView());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertTrue($text->canEdit());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertTrue($text->canDelete());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$member = Member::currentUser();
		$member->logout();

		$this->logInWithPermission('SITETREE_VIEW_ALL');
		$this->assertFalse($text->canCreate());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

		$text->setReadonly(false);
		$this->assertTrue($text->canView());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertFalse($text->canEdit());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertFalse($text->canDelete());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

		$text->setReadonly(true);
		$this->assertTrue($text->canView());

The method assertTrue() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertFalse($text->canEdit());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertFalse($text->canDelete());

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

	}

	function testCustomRules() {

It is generally recommended to explicitly declare the visibility for methods.

		$this->logInWithPermission('ADMIN');
		$form = $this->objFromFixture('UserDefinedForm', 'custom-rules-form');

		$checkbox = $form->Fields()->find('ClassName', 'EditableCheckbox');

The method Fields() does not exist on DataObject. Did you maybe mean beforeUpdateCMSFields()?

		$field = $form->Fields()->find('ClassName', 'EditableTextField');

The method Fields() does not exist on DataObject. Did you maybe mean beforeUpdateCMSFields()?

		$rules = $checkbox->DisplayRules();

		// form has 2 fields - a checkbox and a text field
		// it has 1 rule - when ticked the checkbox hides the text field
		$this->assertEquals(1, $rules->Count());

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertEquals($rules, $checkbox->EffectiveDisplayRules());

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		$checkboxRule = $rules->First();
		$checkboxRule->ConditionFieldID = $field->ID;

		$this->assertEquals($checkboxRule->Display, 'Hide');

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertEquals($checkboxRule->ConditionOption, 'HasValue');

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertEquals($checkboxRule->FieldValue, '6');

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		// If field is required then all custom rules are disabled
		$checkbox->Required = true;
		$this->assertEquals(0, $checkbox->EffectiveDisplayRules()->count());

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

	}

	function testEditableDropdownField() {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

		$dropdown = $this->objFromFixture('EditableDropdown', 'basic-dropdown');

		$field = $dropdown->getFormField();


		$this->assertThat($field, $this->isInstanceOf('DropdownField'));

The method isInstanceOf() does not seem to exist on object<EditableFormFieldTest>.

The method assertThat() does not seem to exist on object<EditableFormFieldTest>.

		$values = $field->getSource();

		$this->assertEquals(array('Option 1' => 'Option 1', 'Option 2' => 'Option 2'), $values);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

	}

	function testEditableRadioField() {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

		$radio = $this->objFromFixture('EditableRadioField', 'radio-field');

		$field = $radio->getFormField();

		$this->assertThat($field, $this->isInstanceOf('OptionsetField'));

The method isInstanceOf() does not seem to exist on object<EditableFormFieldTest>.

The method assertThat() does not seem to exist on object<EditableFormFieldTest>.

		$values = $field->getSource();

		$this->assertEquals(array('Option 5' => 'Option 5', 'Option 6' => 'Option 6'), $values);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

	}

	function testMultipleOptionDuplication() {

It is generally recommended to explicitly declare the visibility for methods.

		$dropdown = $this->objFromFixture('EditableDropdown','basic-dropdown');

		$clone = $dropdown->duplicate();

		$this->assertEquals($clone->Options()->Count(), $dropdown->Options()->Count());

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		foreach($clone->Options() as $option) {
			$orginal = $dropdown->Options()->find('Title', $option->Title);

			$this->assertEquals($orginal->Sort, $option->Sort);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

		}
	}

	public function testFileField() {
		$fileField = $this->objFromFixture('EditableFileField', 'file-field');
		$formField = $fileField->getFormField();

		$this->assertContains('jpg', $formField->getValidator()->getAllowedExtensions());
		$this->assertNotContains('notallowedextension', $formField->getValidator()->getAllowedExtensions());
	}

	public function testFileFieldAllowedExtensionsBlacklist() {
		Config::inst()->update('EditableFileField', 'allowed_extensions_blacklist', array('jpg'));
		$fileField = $this->objFromFixture('EditableFileField', 'file-field');
		$formField = $fileField->getFormField();

		$this->assertNotContains('jpg', $formField->getValidator()->getAllowedExtensions());
	}

	/**
	 * Verify that unique names are automatically generated for each formfield
	 */
	public function testUniqueName() {
		$textfield1 = new EditableTextField();
		$this->assertEmpty($textfield1->Name);

The method assertEmpty() does not seem to exist on object<EditableFormFieldTest>.

		// Write values
		$textfield1->write();
		$textfield2 = new EditableTextField();
		$textfield2->write();
		$checkboxField = new EditableCheckbox();
		$checkboxField->write();

		// Test values are in the expected format
		$this->assertRegExp('/^EditableTextField_.+/', $textfield1->Name);

The method assertRegExp() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertRegExp('/^EditableTextField_.+/', $textfield2->Name);

The method assertRegExp() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertRegExp('/^EditableCheckbox_.+/', $checkboxField->Name);

The method assertRegExp() does not seem to exist on object<EditableFormFieldTest>.

		$this->assertNotEquals($textfield1->Name, $textfield2->Name);

The method assertNotEquals() does not seem to exist on object<EditableFormFieldTest>.

	}

    public function testLengthRange() {
        /** @var EditableTextField $textField */
        $textField = $this->objFromFixture('EditableTextField', 'basic-text');

        // Empty range
        /** @var TextField $formField */
        $textField->MinLength = 0;

The property MinLength does not exist on object<EditableTextField>. Since you implemented __set, maybe consider adding a @property annotation.

        $textField->MaxLength = 0;

The property MaxLength does not exist on object<EditableTextField>. Since you implemented __set, maybe consider adding a @property annotation.

        $attributes = $textField->getFormField()->getAttributes();
        $this->assertFalse(isset($attributes['maxLength']));

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertFalse(isset($attributes['data-rule-minlength']));

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertFalse(isset($attributes['data-rule-maxlength']));

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

        // Test valid range
        $textField->MinLength = 10;

The property MinLength does not exist on object<EditableTextField>. Since you implemented __set, maybe consider adding a @property annotation.

        $textField->MaxLength = 20;

The property MaxLength does not exist on object<EditableTextField>. Since you implemented __set, maybe consider adding a @property annotation.

        $attributes = $textField->getFormField()->getAttributes();
        $this->assertEquals(20, $attributes['maxLength']);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertEquals(20, $attributes['size']);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertEquals(10, $attributes['data-rule-minlength']);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertEquals(20, $attributes['data-rule-maxlength']);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

        // textarea
        $textField->Rows = 3;

The property Rows does not exist on object<EditableTextField>. Since you implemented __set, maybe consider adding a @property annotation.

        $attributes = $textField->getFormField()->getAttributes();
        $this->assertFalse(isset($attributes['maxLength']));

The method assertFalse() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertEquals(10, $attributes['data-rule-minlength']);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

        $this->assertEquals(20, $attributes['data-rule-maxlength']);

The method assertEquals() does not seem to exist on object<EditableFormFieldTest>.

    }


}