UserDefinedForm_EmailRecipientCondition

Complexity

Total Complexity

14

Size/Duplication

Total Lines	113
Duplicated Lines	20.35 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	matches()	0	15	5
A	canCreate()	10	10	2
A	getCanCreateContext()	13	13	4
A	canView()	0	3	1
A	canEdit()	0	3	1
A	canDelete()	0	3	1

<?php


/**
 * Declares a condition that determines whether an email can be sent to a given recipient
 *
 * @method UserDefinedForm_EmailRecipient Parent()
 */
class UserDefinedForm_EmailRecipientCondition extends DataObject {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	/**
	 * List of options
	 *
	 * @config
	 * @var array
	 */
	private static $condition_options = array(

The property $condition_options is not used and could be removed.

		"IsBlank" => "Is blank",
		"IsNotBlank" => "Is not blank",
		"Equals" => "Equals",
		"NotEquals" => "Doesn't equal"
	);

	private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

		'ConditionOption' => 'Enum("IsBlank,IsNotBlank,Equals,NotEquals")',
		'ConditionValue' => 'Varchar'
	);

	private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

		'Parent' => 'UserDefinedForm_EmailRecipient',
		'ConditionField' => 'EditableFormField'
	);

	/**
	 * Determine if this rule matches the given condition
	 *
	 * @param array $data
	 * @param Form $form
	 * @return bool
	 */
	public function matches($data, $form) {

The parameter $form is not used and could be removed.

		$fieldName = $this->ConditionField()->Name;

The method ConditionField does not exist on object<UserDefinedForm_EmailRecipientCondition>? Since you implemented __call, maybe consider adding a @method annotation.

		$fieldValue = isset($data[$fieldName]) ? $data[$fieldName] : null;
		switch($this->ConditionOption) {

The property ConditionOption does not exist on object<UserDefinedForm_EmailRecipientCondition>. Since you implemented __get, maybe consider adding a @property annotation.

			case 'IsBlank':
				return empty($fieldValue);
			case 'IsNotBlank':
				return !empty($fieldValue);
			default:
				$matches = is_array($fieldValue)
					? in_array($this->ConditionValue, $fieldValue)

The property ConditionValue does not exist on object<UserDefinedForm_EmailRecipientCondition>. Since you implemented __get, maybe consider adding a @property annotation.

					: $this->ConditionValue === (string) $fieldValue;

The property ConditionValue does not exist on object<UserDefinedForm_EmailRecipientCondition>. Since you implemented __get, maybe consider adding a @property annotation.

				return ($this->ConditionOption === 'Equals') === (bool)$matches;

The property ConditionOption does not exist on object<UserDefinedForm_EmailRecipientCondition>. Since you implemented __get, maybe consider adding a @property annotation.

		}
	}

    	/**
	 * Return whether a user can create an object of this type
	 *
     * @param Member $member
     * @param array $context Virtual parameter to allow context to be passed in to check

There is no parameter named $context. Was it maybe removed?

	 * @return bool
	 */
	public function canCreate($member = null) {

This method seems to be duplicated in your project.

		// Check parent page
        $parent = $this->getCanCreateContext(func_get_args());
        if($parent) {
            return $parent->canEdit($member);
        }

        // Fall back to secure admin permissions
        return parent::canCreate($member);
	}

    /**
     * Helper method to check the parent for this object
     *
     * @param array $args List of arguments passed to canCreate
     * @return SiteTree Parent page instance
     */
    protected function getCanCreateContext($args) {

This method seems to be duplicated in your project.

        // Inspect second parameter to canCreate for a 'Parent' context
        if(isset($args[1]['Parent'])) {
            return $args[1]['Parent'];
        }
        // Hack in currently edited page if context is missing
        if(Controller::has_curr() && Controller::curr() instanceof CMSMain) {
            return Controller::curr()->currentPage();
        }

        // No page being edited
        return null;
    }

	/**
	 * @param Member
	 *
	 * @return boolean
	 */
	public function canView($member = null) {
		return $this->Parent()->canView($member);
	}

	/**
	 * @param Member
	 *
	 * @return boolean
	 */
	public function canEdit($member = null) {
		return $this->Parent()->canEdit($member);
	}

	/**
	 * @param Member
	 *
	 * @return boolean
	 */
	public function canDelete($member = null) {
		return $this->canEdit($member);
	}
}