EditableCheckboxGroupField

Complexity

Total Complexity

13

Size/Duplication

Total Lines	70
Duplicated Lines	21.43 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

26.67%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getSelectorField()	0	10	2
A	isCheckBoxField()	0	3	1
A	getSelectorFieldOnly()	0	4	1
A	isCheckBoxGroupField()	0	4	1
A	getFormField()	15	15	2
B	getValueFromData()	0	19	6

<?php
/**
 * EditableCheckboxGroup
 *
 * Represents a set of selectable radio buttons
 *
 * @package userforms
 */

class EditableCheckboxGroupField extends EditableMultipleOptionField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $singular_name = "Checkbox Group";

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = "Checkbox Groups";

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    protected $jsEventHandler = 'click';

    public function getFormField()

This method seems to be duplicated in your project.

    {
        $field = UserFormsCheckboxSetField::create($this->Name, $this->EscapedTitle, $this->getOptionsMap())

The property EscapedTitle does not exist on object<EditableCheckboxGroupField>. Since you implemented __get, maybe consider adding a @property annotation.

            ->setFieldHolderTemplate('UserFormsMultipleOptionField_holder')
            ->setTemplate('UserFormsCheckboxSetField');

        // Set the default checked items
        $defaultCheckedItems = $this->getDefaultOptions();
        if ($defaultCheckedItems->count()) {
            $field->setDefaultItems($defaultCheckedItems->map('Value')->keys());

The method keys cannot be called on $defaultCheckedItems->map('Value') (of type array).

        }

        $this->doUpdateFormField($field);
        return $field;
    }

    public function getValueFromData($data)
    {
        $result = '';
        $entries = (isset($data[$this->Name])) ? $data[$this->Name] : false;

        if ($entries) {
            if (!is_array($data[$this->Name])) {
                $entries = array($data[$this->Name]);
            }
            foreach ($entries as $selected => $value) {
                if (!$result) {
                    $result = $value;
                } else {
                    $result .= ", " . $value;
                }
            }
        }
        return $result;
    }

    public function getSelectorField(EditableCustomRule $rule, $forOnLoad = false)
    {
        // watch out for checkboxs as the inputs don't have values but are 'checked
        // @todo - Test this
        if ($rule->FieldValue) {
            return "$(\"input[name='{$this->Name}[]'][value='{$rule->FieldValue}']\")";
        } else {
            return "$(\"input[name='{$this->Name}[]']:first\")";
        }
    }

	public function isCheckBoxField() {
		return true;
	}

	public function getSelectorFieldOnly()
    {
        return "[name='{$this->Name}[]']";
    }

    public function isCheckBoxGroupField()
    {
        return true;
    }
}