SilverStripe\UserForms\Model\EditableFormField\EditableMemberListField

Complexity

Total Complexity

7

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	18	1
A	getValueFromData()	0	9	3
A	getFormField()	0	15	3

<?php

namespace SilverStripe\UserForms\Model\EditableFormField;

use SilverStripe\Forms\DropdownField;
use SilverStripe\Security\Group;
use SilverStripe\Security\Member;
use SilverStripe\UserForms\Model\EditableFormField;

/**
 * Creates an editable field that displays members in a given group
 *
 * @package userforms
 */
class EditableMemberListField extends EditableFormField
{
    private static $singular_name = 'Member List Field';

The private property $singular_name is not used, and could be removed.

    private static $plural_name = 'Member List Fields';

The private property $plural_name is not used, and could be removed.

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Group' => Group::class
    ];

    private static $table_name = 'EditableMemberListField';

The private property $table_name is not used, and could be removed.

    /**
     * @return FieldList

The type SilverStripe\UserForms\Model\EditableFormField\FieldList was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName('Default');
        $fields->removeByName('Validation');

        /** @skipUpgrade */
        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create(
                'GroupID',
                _t('SilverStripe\\UserForms\\Model\\EditableFormField.GROUP', 'Group'),
                Group::get()->map()
            )->setEmptyString(' ')
        );

        return $fields;

The expression return $fields returns the type SilverStripe\Forms\FieldList which is incompatible with the documented return type SilverStripe\UserForms\Model\EditableFormField\FieldList.

    }

    public function getFormField()
    {
        if (empty($this->GroupID)) {

The property GroupID does not exist on SilverStripe\UserForms\Model\EditableFormField\EditableMemberListField. Since you implemented __get, consider adding a @property annotation.

            return false;
        }

        $members = Member::map_in_groups($this->GroupID);

        $field = DropdownField::create($this->Name, $this->Title ?: false, $members)
            ->setTemplate(EditableDropdown::class)
            ->setFieldHolderTemplate(EditableFormField::class . '_holder');

        $this->doUpdateFormField($field);

        return $field;
    }

    public function getValueFromData($data)
    {
        if (isset($data[$this->Name])) {
            $memberID = $data[$this->Name];
            $member = Member::get()->byID($memberID);
            return $member ? $member->getName() : '';

$member is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

        }

        return false;
    }
}