SilverStripe\UserForms\FormField\UserFormsFieldList

Complexity

Total Complexity

9

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getParent()	0	4	1
A	setParent()	0	3	1
A	processNext()	0	14	3
A	clearEmptySteps()	0	5	4

<?php

namespace SilverStripe\UserForms\FormField;

use SilverStripe\Forms\FieldList;
use SilverStripe\UserForms\Model\EditableFormField;

/**
 * A list of formfields which allows for iterative processing of nested composite fields
 */
class UserFormsFieldList extends FieldList implements UserFormsFieldContainer
{
    public function processNext(EditableFormField $field)
    {
        $formField = $field->getFormField();
        if (!$formField) {

$formField is of type SilverStripe\Forms\FormField, thus it always evaluated to true.

            return $this;
        }

        $this->push($formField);

        if ($formField instanceof UserFormsFieldContainer) {
            return $formField->setParent($this);

The expression return $formField->setParent($this) also could return the type SilverStripe\Forms\FormField&SilverStripe\UserForms\FormField\UserFormsFieldContainer which is incompatible with the return type mandated by SilverStripe\UserForms\FormField\UserFormsFieldContainer::processNext() of SilverStripe\UserForms\FormField\EditableContainerField.

        }

        return $this;

The expression return $this returns the type SilverStripe\UserForms\FormField\UserFormsFieldList which is incompatible with the return type mandated by SilverStripe\UserForms\FormField\UserFormsFieldContainer::processNext() of SilverStripe\UserForms\FormField\EditableContainerField.

    }

    public function getParent()
    {
        // Field list does not have a parent
        return null;
    }

    public function setParent(UserFormsFieldContainer $parent)
    {
        return $this;
    }

    /**
     * Remove all empty steps
     */
    public function clearEmptySteps()
    {
        foreach ($this as $field) {
            if ($field instanceof UserFormsStepField && count($field->getChildren()) === 0) {
                $this->remove($field);
            }
        }
    }
}