SilverStripe\Translatable\Tests\TranslatableSiteConfigTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	7	1
A	tearDown()	0	7	1
A	testCurrentCreatesDefaultForLocale()	0	17	1
A	testCanEditTranslatedRootPages()	0	14	1

<?php

namespace SilverStripe\Translatable\Tests;

use Page;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Security\Member;
use SilverStripe\SiteConfig\SiteConfig;
use SilverStripe\Translatable\Model\Translatable;

/**
 * @package translatable
 */
class TranslatableSiteConfigTest extends SapphireTest
{
    protected static $fixture_file = 'TranslatableSiteConfigTest.yml';

    protected static $required_extensions = [
        SiteTree::class => [Translatable::class],
        SiteConfig::class => [Translatable::class],
    ];

    protected static $illegal_extensions = [
        // @todo: Update namespace to match subsites
        SiteTree::class => array('SiteTreeSubsites')
    ];

    private $origLocale;

    protected function setUp()
    {
        parent::setUp();

        $this->origLocale = Translatable::default_locale();
        Translatable::set_default_locale('en_US');
    }

    protected function tearDown()
    {
        Translatable::set_default_locale($this->origLocale);
        Translatable::set_current_locale($this->origLocale);

        parent::tearDown();
    }

    public function testCurrentCreatesDefaultForLocale()
    {
        Translatable::set_current_locale(Translatable::default_locale());
        $configEn = SiteConfig::current_site_config();
        Translatable::set_current_locale('fr_FR');
        $configFr = SiteConfig::current_site_config();
        Translatable::set_current_locale(Translatable::default_locale());

        $this->assertInstanceOf(SiteConfig::class, $configFr);
        $this->assertEquals($configFr->Locale, 'fr_FR');
        $this->assertEquals($configFr->Title, $configEn->Title, 'Copies title from existing config');
        $this->assertEquals(
            $configFr->getTranslationGroup(),
            $configEn->getTranslationGroup(),
            'Created in the same translation group'
        );
    }

    public function testCanEditTranslatedRootPages()
    {
        $configEn = $this->objFromFixture(SiteConfig::class, 'en_US');

$configEn is not used, you could remove the assignment.

        $configDe = $this->objFromFixture(SiteConfig::class, 'de_DE');

$configDe is not used, you could remove the assignment.

        $pageEn = $this->objFromFixture(Page::class, 'root_en');
        $pageDe = $pageEn->createTranslation('de_DE');

$pageDe is not used, you could remove the assignment.

        $translatorDe = $this->objFromFixture(Member::class, 'translator_de');
        $translatorEn = $this->objFromFixture(Member::class, 'translator_en');

        $this->assertFalse($pageEn->canEdit($translatorDe));

It seems like $translatorDe defined by $this->objFromFixture(\SilverStripe\Security\Member::class, 'translator_de') on line 73 can also be of type object<SilverStripe\ORM\DataObject>; however, SilverStripe\ORM\DataObject::canEdit() does only seem to accept object<SilverStripe\Security\Member>|null, maybe add an additional type check?

        $this->assertTrue($pageEn->canEdit($translatorEn));

It seems like $translatorEn defined by $this->objFromFixture(\SilverStripe\Security\Member::class, 'translator_en') on line 74 can also be of type object<SilverStripe\ORM\DataObject>; however, SilverStripe\ORM\DataObject::canEdit() does only seem to accept object<SilverStripe\Security\Member>|null, maybe add an additional type check?

    }
}