MigrateTranslatableTask

Complexity

Total Complexity

22

Size/Duplication

Total Lines	150
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

<?php
 * Warning: Please run dev/build on your 2.2 database to update the schema before running this task.
 * The dev/build command will rename tables like "SiteTree_lang" to "_obsolete_SiteTree_lang".
 *
 * <h3>Commandline</h3>
 * Requires "sake" tool (see http://doc.silverstripe.com/?id=sake)
 * <example>
 * sake dev/tasks/MigrateTranslatableTask
 * </example>
 *
 * <h3>Browser</h3>
 * <example>
 * http://mydomain.com/dev/tasks/MigrateTranslatableTask
 * </example>
 *
 * @package translatable
 */
class MigrateTranslatableTask extends BuildTask
{
    protected $title = "Migrate Translatable Task";

    protected $description = "Migrates site translations from SilverStripe 2.1/2.2 to new database structure.";

    private static $segment = 'MigrateTranslatableTask';

Consider using a different property name as you override a private property of the parent class.

The property $segment is not used and could be removed.

    public function run($request)
    {
        $canAccess = (Director::isDev() || Director::is_cli() || Permission::check("ADMIN"));
        if (!$canAccess) {
            return Security::permissionFailure($this);

$this is of type this<SilverStripe\Translatable\Tasks\MigrateTranslatableTask>, but the function expects a object<SilverStripe\Control\Controller>|null.

        }

        $ids = array();

        echo "#################################\n";
        echo "# Adding translation groups to existing records" . "\n";
        echo "#################################\n";

        $allSiteTreeIDs = DB::query('SELECT "ID" FROM "SiteTree"')->column();
        if ($allSiteTreeIDs) {

The expression $allSiteTreeIDs of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($allSiteTreeIDs as $id) {
                $original = DataObject::get_by_id(SiteTree::class, $id);
                $existingGroupID = $original->getTranslationGroup();
                if (!$existingGroupID) {
                    $original->addTranslationGroup($original->ID);
                }
                $original->destroy();
                unset($original);
            }
        }

        DataObject::flush_and_destroy_cache();

        echo sprintf("Created translation groups for %d records\n", count($allSiteTreeIDs));

        foreach (array('Stage', 'Live') as $stage) {
            echo "\n\n#################################\n";
            echo "# Migrating stage $stage" . "\n";
            echo "#################################\n";

            $suffix = ($stage == 'Live') ? '_Live' : '';

            // First get all entries in SiteTree_lang
            // This should be all translated pages
            $trans = DB::query(sprintf('SELECT * FROM "_obsolete_SiteTree_lang%s"', $suffix));

            // Iterate over each translated pages
            foreach ($trans as $oldtrans) {
                $newLocale = i18n::get_locale_from_lang($oldtrans['Lang']);

The method get_locale_from_lang() does not exist on SilverStripe\i18n\i18n. Did you maybe mean get_locale()?

                echo sprintf(
                    "Migrating from %s to %s translation of '%s' (#%d)\n",
                    $oldtrans['Lang'],
                    $newLocale,
                    Convert::raw2xml($oldtrans['Title']),
                    $oldtrans['OriginalLangID']
                );

                // Get the untranslated page

                $original = Versioned::get_one_by_stage(
                    $oldtrans['ClassName'],
                    $stage,
                    '"SiteTree"."ID" = ' .  $oldtrans['OriginalLangID']
                );

                if (!$original) {
                    echo sprintf("Couldn't find original for #%d", $oldtrans['OriginalLangID']);
                    continue;
                }

                // write locale to $original
                $original->Locale = i18n::get_locale_from_lang(Translatable::default_lang());

The method default_lang() does not seem to exist on object<SilverStripe\Translatable\Model\Translatable>.

The method get_locale_from_lang() does not exist on SilverStripe\i18n\i18n. Did you maybe mean get_locale()?

                $original->writeToStage($stage);

                // Clone the original, and set it up as a translation
                $existingTrans = $original->getTranslation($newLocale, $stage);

                if ($existingTrans) {
                    echo sprintf(
                        "Found existing new-style translation for #%d. Already merged? Skipping.\n",
                        $oldtrans['OriginalLangID']
                    );
                    continue;
                }

                // Doesn't work with stage/live split
                //$newtrans = $original->createTranslation($newLocale);

64% of this comment could be valid code. Did you maybe forget this after debugging?

                $newtrans = $original->duplicate(false);
                $newtrans->OriginalID = $original->ID;

The property OriginalID does not seem to exist. Did you mean original?

                // we have to "guess" a locale based on the language
                $newtrans->Locale = $newLocale;
                if ($stage == 'Live' && array_key_exists($original->ID, $ids)) {
                    $newtrans->ID = $ids[$original->ID];
                }

                // Look at each class in the ancestry, and see if there is a _lang table for it
                foreach (ClassInfo::ancestry($oldtrans['ClassName']) as $classname) {
                    $oldtransitem = false;

                    // If the class is SiteTree, we already have the DB record,
                    // else check for the table and get the record
                    if ($classname == SiteTree::class) {
                        $oldtransitem = $oldtrans;
                    } elseif (in_array(strtolower($classname) . '_lang', DB::tableList())) {

The method tableList() does not seem to exist on object<SilverStripe\ORM\DB>.

                        $oldtransitem = DB::query(sprintf(
                            'SELECT * FROM "_obsolete_%s_lang%s" WHERE "OriginalLangID" = %d AND "Lang" = \'%s\'',
                            $classname,
                            $suffix,
                            $original->ID,
                            $oldtrans['Lang']
                        ))->first();
                    }

                    // Copy each translated field into the new translation
                    if ($oldtransitem) {
                        foreach ($oldtransitem as $key => $value) {
                            if (!in_array($key, array('ID', 'OriginalLangID'))) {
                                $newtrans->$key = $value;
                            }
                        }
                    }
                }

                // Write the new translation to the database
                $sitelang = Translatable::get_current_locale();
                Translatable::set_current_locale($newtrans->Locale);
                $newtrans->writeToStage($stage);
                Translatable::set_current_locale($sitelang);

                $newtrans->addTranslationGroup($original->getTranslationGroup(), true);