FileTextExtractableTest::testExtractFileAsText() - Code Metrics - Inspection of "fix(PDFTextExtractor): Added support for Windows,..." - silverstripe/silverstripe-textextraction - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

unknown

created 2016-05-13 05:17 UTC

FileTextExtractableTest::testExtractFileAsText() A

↳ Parent: FileTextExtractableTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	22
rs	9.2
cc	2
eloc	12
nc	2
nop	0

<?php
class FileTextExtractableTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    protected $requiredExtensions = array(
        'File' => array('FileTextExtractable')
    );

    public function setUp()
    {
        parent::setUp();

        // Ensure that html is a valid extension
        Config::inst()
            ->nest()
            ->update('File', 'allowed_extensions', array('html'));
    }

    public function tearDown()
    {
        Config::unnest();
        parent::tearDown();
    }

    public function testExtractFileAsText()
    {
        // Create a copy of the file, as it may be clobbered by the test
        // ($file->extractFileAsText() calls $file->write)

        copy(BASE_PATH.'/textextraction/tests/fixtures/test1.html', BASE_PATH.'/textextraction/tests/fixtures/test1-copy.html');
        
        // Use HTML, since the extractor is always available
        $file = new File(array(
            'Name' => 'test1-copy.html',
            'Filename' => 'textextraction/tests/fixtures/test1-copy.html'
        ));
        $file->write();
    
        $content = $file->extractFileAsText();
        $this->assertContains('Test Headline', $content);
        $this->assertContains('Test Text', $content);
        $this->assertEquals($content, $file->FileContentCache);


        if (file_exists(BASE_PATH.'/textextraction/tests/fixtures/test1-copy.html')) {
            unlink(BASE_PATH.'/textextraction/tests/fixtures/test1-copy.html');
        }
    }
}


1			<?php
2			class FileTextExtractableTest extends SapphireTest
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-20 23:53 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
3			{
4			protected $requiredExtensions = array(
5			'File' => array('FileTextExtractable')
6			);
7
8			public function setUp()
9			{
10			parent::setUp();
11
12			// Ensure that html is a valid extension
13			Config::inst()
14			->nest()
15			->update('File', 'allowed_extensions', array('html'));
16			}
17
18			public function tearDown()
19			{
20			Config::unnest();
21			parent::tearDown();
22			}
23
24			public function testExtractFileAsText()
25			{
26			// Create a copy of the file, as it may be clobbered by the test
27			// ($file->extractFileAsText() calls $file->write)
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-25 03:05 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			copy(BASE_PATH.'/textextraction/tests/fixtures/test1.html', BASE_PATH.'/textextraction/tests/fixtures/test1-copy.html');
29
30			// Use HTML, since the extractor is always available
31			$file = new File(array(
32			'Name' => 'test1-copy.html',
33			'Filename' => 'textextraction/tests/fixtures/test1-copy.html'
34			));
35			$file->write();
36
37			$content = $file->extractFileAsText();
38			$this->assertContains('Test Headline', $content);
39			$this->assertContains('Test Text', $content);
40			$this->assertEquals($content, $file->FileContentCache);
			0 ignored issues – show Bug introduced 2015-11-20 23:53 UTC by Report Bug Copy Issue Report The property `FileContentCache` does not seem to exist. Did you mean `Content`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2015-11-20 23:53 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<FileTextExtractableTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41
42			if (file_exists(BASE_PATH.'/textextraction/tests/fixtures/test1-copy.html')) {
43			unlink(BASE_PATH.'/textextraction/tests/fixtures/test1-copy.html');
44			}
45			}
46			}
47

silverstripe / silverstripe-textextraction

Pull Request — master (#28)

FileTextExtractableTest::testExtractFileAsText() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like