TaxonomyTermUrlExtensionTest::testGeneratesUrlWhenNameIsInvalid() - Code Metrics - Inspection of "Adds a URLSegment to option to term directory" - silverstripe/silverstripe-taxonomy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#59)

unknown

created 2019-05-09 23:08 UTC

testGeneratesUrlWhenNameIsInvalid() A

↳ Parent: TaxonomyTermUrlExtensionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	14
nc	1
nop	0
dl	0
loc	21
rs	9.7998
c	0
b	0
f	0

<?php

namespace SilverStripe\Taxonomy\Tests;

use SilverStripe\Dev\SapphireTest;
use SilverStripe\Taxonomy\TaxonomyTerm;

class TaxonomyTermUrlExtensionTest extends SapphireTest
{
    protected static $fixture_file = 'TaxonomyTermUrlExtensionTest.yml';
    protected $usesDatabase = true;

    public function testGeneratesUrl()
    {
        $term = new TaxonomyTerm();
        $term->Name = 'Test 1';

        $term->write();

        // Reload the model
        $term = TaxonomyTerm::get_by_id($term->ID);
        $this->assertNotNull($term);
        $this->assertEquals('Test 1', $term->Name);

        $this->assertEquals('test-1', $term->URLSegment);

    }

    public function testGeneratesUniqueUrls()
    {
        $term1 = new TaxonomyTerm();
        $term1->Name = 'Testing';

        $term1->write();

        $term2 = new TaxonomyTerm();
        $term2->Name = 'Testing'; // intentionally the same
        $term2->write();

        // Reload the model
        $term2 = TaxonomyTerm::get_by_id($term2->ID);
        $this->assertNotNull($term2);
        $this->assertEquals('Testing', $term2->Name);

        $this->assertEquals('testing-2', $term2->URLSegment);

    }

    public function testRespectsSuppliedUrl()
    {
        $term = new TaxonomyTerm();
        $term->Name = 'Test 1';

        $term->URLSegment = 'something supplied';

        $term->write();

        // Reload the model
        $term = TaxonomyTerm::get_by_id($term->ID);
        $this->assertNotNull($term);
        $this->assertEquals('Test 1', $term->Name);

        $this->assertEquals('something supplied', $term->URLSegment);


        // Check it doesn't overwrite if saved multiple times
        $term->Name = 'Test changed';
        $term->write();

        $term = TaxonomyTerm::get_by_id($term->ID);
        $this->assertNotNull($term);
        $this->assertEquals('Test changed', $term->Name);
        $this->assertEquals('something supplied', $term->URLSegment);
    }

    public function testGeneratesUniqueUrlIfSuppliedIsUsed()
    {
        $term1 = new TaxonomyTerm();
        $term1->Name = 'Test 1';

        $term1->URLSegment = 'supplied-test';

        $term1->write();

        $term2 = new TaxonomyTerm();
        $term2->Name = 'Test 2';
        $term2->URLSegment = 'supplied-test'; // intentionally the same
        $term2->write();

        // Reload the model
        $term2 = TaxonomyTerm::get_by_id($term2->ID);
        $this->assertNotNull($term2);
        $this->assertEquals('Test 2', $term2->Name);

        $this->assertEquals('supplied-test-2', $term2->URLSegment);

    }

    public function testGeneratesUrlWhenNameIsInvalid()
    {
        $term = new TaxonomyTerm();
        $term->Name = '##';

        $term->write();

        // Reload the model
        $term = TaxonomyTerm::get_by_id($term->ID);
        $this->assertNotNull($term);
        $this->assertEquals('##', $term->Name);

        $this->assertEquals('term-1', $term->URLSegment);


        $term = new TaxonomyTerm();
        $term->Name = ' ';
        $term->write();

        // Reload the model
        $term = TaxonomyTerm::get_by_id($term->ID);
        $this->assertNotNull($term);
        $this->assertEquals(' ', $term->Name);
        $this->assertEquals('term-2', $term->URLSegment);
    }
}


1			<?php
2
3			namespace SilverStripe\Taxonomy\Tests;
4
5			use SilverStripe\Dev\SapphireTest;
6			use SilverStripe\Taxonomy\TaxonomyTerm;
7
8			class TaxonomyTermUrlExtensionTest extends SapphireTest
9			{
10			protected static $fixture_file = 'TaxonomyTermUrlExtensionTest.yml';
11			protected $usesDatabase = true;
12
13			public function testGeneratesUrl()
14			{
15			$term = new TaxonomyTerm();
16			$term->Name = 'Test 1';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
17			$term->write();
18
19			// Reload the model
20			$term = TaxonomyTerm::get_by_id($term->ID);
21			$this->assertNotNull($term);
22			$this->assertEquals('Test 1', $term->Name);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
23			$this->assertEquals('test-1', $term->URLSegment);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
24			}
25
26			public function testGeneratesUniqueUrls()
27			{
28			$term1 = new TaxonomyTerm();
29			$term1->Name = 'Testing';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
30			$term1->write();
31
32			$term2 = new TaxonomyTerm();
33			$term2->Name = 'Testing'; // intentionally the same
34			$term2->write();
35
36			// Reload the model
37			$term2 = TaxonomyTerm::get_by_id($term2->ID);
38			$this->assertNotNull($term2);
39			$this->assertEquals('Testing', $term2->Name);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
40			$this->assertEquals('testing-2', $term2->URLSegment);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
41			}
42
43			public function testRespectsSuppliedUrl()
44			{
45			$term = new TaxonomyTerm();
46			$term->Name = 'Test 1';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
47			$term->URLSegment = 'something supplied';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
48			$term->write();
49
50			// Reload the model
51			$term = TaxonomyTerm::get_by_id($term->ID);
52			$this->assertNotNull($term);
53			$this->assertEquals('Test 1', $term->Name);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
54			$this->assertEquals('something supplied', $term->URLSegment);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
55
56			// Check it doesn't overwrite if saved multiple times
57			$term->Name = 'Test changed';
58			$term->write();
59
60			$term = TaxonomyTerm::get_by_id($term->ID);
61			$this->assertNotNull($term);
62			$this->assertEquals('Test changed', $term->Name);
63			$this->assertEquals('something supplied', $term->URLSegment);
64			}
65
66			public function testGeneratesUniqueUrlIfSuppliedIsUsed()
67			{
68			$term1 = new TaxonomyTerm();
69			$term1->Name = 'Test 1';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
70			$term1->URLSegment = 'supplied-test';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
71			$term1->write();
72
73			$term2 = new TaxonomyTerm();
74			$term2->Name = 'Test 2';
75			$term2->URLSegment = 'supplied-test'; // intentionally the same
76			$term2->write();
77
78			// Reload the model
79			$term2 = TaxonomyTerm::get_by_id($term2->ID);
80			$this->assertNotNull($term2);
81			$this->assertEquals('Test 2', $term2->Name);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
82			$this->assertEquals('supplied-test-2', $term2->URLSegment);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
83			}
84
85			public function testGeneratesUrlWhenNameIsInvalid()
86			{
87			$term = new TaxonomyTerm();
88			$term->Name = '##';
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
89			$term->write();
90
91			// Reload the model
92			$term = TaxonomyTerm::get_by_id($term->ID);
93			$this->assertNotNull($term);
94			$this->assertEquals('##', $term->Name);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
95			$this->assertEquals('term-1', $term->URLSegment);
			0 ignored issues – show Bug Best Practice introduced 2019-05-09 23:10 UTC by Report Bug Copy Issue Report The property `URLSegment` does not exist on `SilverStripe\Taxonomy\TaxonomyTerm`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
96
97			$term = new TaxonomyTerm();
98			$term->Name = ' ';
99			$term->write();
100
101			// Reload the model
102			$term = TaxonomyTerm::get_by_id($term->ID);
103			$this->assertNotNull($term);
104			$this->assertEquals(' ', $term->Name);
105			$this->assertEquals('term-2', $term->URLSegment);
106			}
107			}
108

silverstripe / silverstripe-taxonomy

Pull Request — master (#59)

testGeneratesUrlWhenNameIsInvalid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like