TaxonomyTermUrlExtension::onBeforeWrite() - Code Metrics - Inspection of "Adds a URLSegment to option to term directory" - silverstripe/silverstripe-taxonomy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#59)

unknown

created 2019-03-19 08:22 UTC

TaxonomyTermUrlExtension::onBeforeWrite() A

↳ Parent: TaxonomyTermUrlExtension

Complexity

Conditions	4
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	7
nc	3
nop	0
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

namespace SilverStripe\Taxonomy\Extensions;

use SilverStripe\Taxonomy\TaxonomyTerm;
use SilverStripe\ORM\DataExtension;
use SilverStripe\CMS\Model\SiteTree;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\Forms\FieldList;

/**
* Adds a URLSegment to TaxonomyTerm that gets
* generated from the name if not specified.
*
* @package taxonomy
*/
class TaxonomyTermUrlExtension extends DataExtension
{
    private static $db = array(

        'URLSegment' => 'Varchar(255)',
    );

    public function updateCMSFields(FieldList $fields)
    {
        $field = $fields->dataFieldByName('URLSegment');
        if ($field) {

            $field->setDescription('Leave blank to generate from name');
            $fields->insertAfter('Name', $field);
        }
    }

    /**
     *  Set the URL segment allowing filtering by url slug
     *
     *  {@inheritDoc}
     */
    public function onBeforeWrite() {
         parent::onBeforeWrite();
         // Write the URLSegment to allow for Taxonomy navigation only if one is not supplied
        if ($this->owner->Name && $this->owner->URLSegment == null) {
            $this->owner->setField('URLSegment', SiteTree::singleton()->generateURLSegment($this->owner->Name));
             // Ensure that this object has a non-conflicting URLSegment value.
            $count = 2;
            while (TaxonomyTerm::get()->filter(['URLSegment' => $this->owner->URLSegment])->exclude(array('ID' => $this->owner->ID))->exists())
            {
                $this->owner->setField('URLSegment', preg_replace('/-[0-9]+$/', null, $this->owner->URLSegment) . '-' . $count);
                $count++;
            }
        }
    }
}


1			<?php
2
3			namespace SilverStripe\Taxonomy\Extensions;
4
5			use SilverStripe\Taxonomy\TaxonomyTerm;
6			use SilverStripe\ORM\DataExtension;
7			use SilverStripe\CMS\Model\SiteTree;
			0 ignored issues – show Bug introduced 2019-03-19 08:26 UTC by Report Bug Copy Issue Report The type `SilverStripe\CMS\Model\SiteTree` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use SilverStripe\Forms\FieldList;
9
10			/**
11			* Adds a URLSegment to TaxonomyTerm that gets
12			* generated from the name if not specified.
13			*
14			* @package taxonomy
15			*/
16			class TaxonomyTermUrlExtension extends DataExtension
17			{
18			private static $db = array(
			0 ignored issues – show introduced 2019-03-19 08:26 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
19			'URLSegment' => 'Varchar(255)',
20			);
21
22			public function updateCMSFields(FieldList $fields)
23			{
24			$field = $fields->dataFieldByName('URLSegment');
25			if ($field) {
			0 ignored issues – show introduced 2019-03-19 08:26 UTC by Report Bug Copy Issue Report `$field` is of type `SilverStripe\Forms\FormField`, thus it always evaluated to `true`. Loading history...
26			$field->setDescription('Leave blank to generate from name');
27			$fields->insertAfter('Name', $field);
28			}
29			}
30
31			/**
32			* Set the URL segment allowing filtering by url slug
33			*
34			* {@inheritDoc}
35			*/
36			public function onBeforeWrite() {
37			parent::onBeforeWrite();
38			// Write the URLSegment to allow for Taxonomy navigation only if one is not supplied
39			if ($this->owner->Name && $this->owner->URLSegment == null) {
40			$this->owner->setField('URLSegment', SiteTree::singleton()->generateURLSegment($this->owner->Name));
41			// Ensure that this object has a non-conflicting URLSegment value.
42			$count = 2;
43			while (TaxonomyTerm::get()->filter(['URLSegment' => $this->owner->URLSegment])->exclude(array('ID' => $this->owner->ID))->exists())
44			{
45			$this->owner->setField('URLSegment', preg_replace('/-[0-9]+$/', null, $this->owner->URLSegment) . '-' . $count);
46			$count++;
47			}
48			}
49			}
50			}
51

silverstripe / silverstripe-taxonomy

Pull Request — master (#59)

TaxonomyTermUrlExtension::onBeforeWrite() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like